intel_adsp: cavs: add missing lpgpdma access and ownership initialization #55738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kv2019i
requested review from
teburd,
juimonen,
edersondisouza,
abonislawski and
aborisovich
zephyrbot
requested review from
ceolin,
lgirdwood,
lyakh,
marc-hb,
MaureenHelm,
softwarecki and
tmleman
softwarecki
reviewed
Mar 13, 2023
tmleman
requested changes
Mar 14, 2023
kv2019i
force-pushed
the
202303-platform-init
branch
from
5283605 to
7ac2a56
Compare
|
V2 uploaded:
|
tmleman
requested changes
Apr 27, 2023
For Intel cavs2.5, access from LPGPDMAC to Audio Link Hub RX/TX registers needs to be explicitly enabled before use. The logic follow hardware initialization done in SOF project sof/src/platform/intel/cavs/platform.c Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
kv2019i
force-pushed
the
202303-platform-init
branch
from
7ac2a56 to
98aff27
Compare
tmleman
approved these changes
May 30, 2023
teburd
approved these changes
May 30, 2023
softwarecki
approved these changes
May 30, 2023
nashif
approved these changes
May 30, 2023
kv2019i
added a commit
to kv2019i/sof
that referenced
this pull request
Jun 5, 2023
If SOF is built with Zephyr, the GPDMA/ALH ownership programming should happen in Zephyr platform code, not on SOF side. Link: zephyrproject-rtos/zephyr#55738 Closes: thesofproject#7249 Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
kv2019i
added a commit
to thesofproject/sof
that referenced
this pull request
Jun 6, 2023
If SOF is built with Zephyr, the GPDMA/ALH ownership programming should happen in Zephyr platform code, not on SOF side. Link: zephyrproject-rtos/zephyr#55738 Closes: #7249 Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While pruning SOF code from HW access that should be done in Zephyr. a few registers were found that were programmed in SOF (i.e. in application code) where as these should be programmed in Zephyr code.
These registers are similar to DSP_INIT_IOPO which is already programmed in power_init().