-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update JSON-RPC to v0.8.0 #630
Draft
FabijanC
wants to merge
43
commits into
main
Choose a base branch
from
json-rpc-v0.8.0
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Change L1 hash repr: bytes array and string -> H256
* Move and rename tx status struct; add failure_reason * Rename InsufficientMaxFee to InsufficientResourcesForValidate * Improve panicking_contract: compile with 2.8.0, add method for distant panic
marioiordanov
force-pushed
the
json-rpc-v0.8.0
branch
from
October 23, 2024 12:00
cf2eb6c
to
9e5bc95
Compare
* SimulateTransactions integration tests (#628) * remove handle_transaction_result, refactor errors * integration tests * added new error type * typo * fixed unit tests * fixed integration test * remove fully qualified names in errors file * changed test name * reuse variable * replace declare_deploy_v1 with declare_v3_deploy_v3 * add simulate transaction validation check * add functionality * refactor if else with match * remove trait implementation * changed error variant * commment * resolve compilation errors * fix integration tests * clippy * removed let [skip ci] * removed duplicated method [skip ci] * remove duplicated test [skip ci] * clippy * clippy [skip ci]
* functions for compiling sierra to casm * removed calculate_casm_hash function * added getCompiledCasm endpoint * change used function for compiling FlattenedSierraClass to Casm * integration tests [skip ci] * Reverted changes * clippy * added check in test * change check in test
* Do interval block creation via request
This reverts commit c096337. * [skip ci]
* Simplify event receiving via new util function
* Make aborting a BackgroundDevnet method * Fix restarting behavior; check notifiability only if appropriate request * Improve fn matches
* Rename block -> block_id * Add missing BlockNotFound test * Expand invalid block ID testing; move to separate file * Add CallOnPending error * Add receive_block in tests
* Define testing type in common utils * [skip ci] - a new merge follows right away
* Assert tx status notification not sent on abort - update docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage related changes
Development related changes
Checklist:
RPC_SPEC_VERSION
constant./scripts/format.sh
./scripts/clippy_check.sh
./scripts/check_unused_deps.sh
./scripts/check_spelling.sh
./website/README.md