Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue - shoulder buttons do not perform page up/down actions #666

Open
wants to merge 1,058 commits into
base: master
Choose a base branch
from

Conversation

Oberworld
Copy link

Hi, I'm nismo from retropie forums (my nick was taken here).

There is a bug on Emulationstation that make L and R buttons to fast navigate in gamelist doesn't work.

Fieldofcows did a fix months ago and I tested without any issues.

Can you update the code to add it?

Here is the commit: fieldofcows@97f56a1

Regards.

@robertybob
Copy link

@Oberworld I think this can be closed as it's not been created properly :)

@hex007
Copy link

hex007 commented Aug 25, 2017

@Oberworld This is not the repo for EmulationStation for Retropie

Go here -> https://github.com/Retropie/EmulationStation

And close this PR. It has too many commits and this repo is not maintained

@hex007
Copy link

hex007 commented Sep 24, 2017

@Oberworld Please close this PR ASAP

tomaz82 and others added 24 commits November 30, 2020 11:36
gridview: ignore placeholders on metadata updates
Add to help screen the extra parameters from #324 and #348.
Also replace tabs with spaces for more consistent display, normalize capitalization of first letters, and MB is the correct abbreviation for MegaBytes.
Fix description for screensize
Changed the CMP0072[1] `cmake` policy to use `libGL` for OPENGL_LIBRARIES,
instead of `libOpenGL`, provided by `libglvnd` (default from `cmake` 3.11).

This should fix situations where there the OpenGL implementation doesn't have
`glvnd` support and `emulationstation` gets linked to the `glvnd` library.`libSDL2`
dl-loads a different `libGL` and this results in a non-working GL context.

[1] https://cmake.org/cmake/help/git-stage/policy/CMP0072.html
cmake: use the non-glvnd version of GL libraries
…bit (ugo), no sticky bit.

Indicative log message if execution fails probably due to insufficient file permissions.

Refers to: https://retropie.org.uk/forum/topic/29651/emulation-station-game-start-script-not-executable
Update video screensaver settings
Improve Update Gamelist logic and performance
Added a cache for stat checks
Adds option for background resource indexing during screensaver
Fix insignificant message typo in VolumeControl.cpp
Add option to ignore common leading articles in Filename sort
Adds longer delay (5secs) for start of description text autoscroll.
Allow <forceUppercase>0</forceUppercase> in <textlist>
All changes in just one commit, as discussed earlier

Add
NEOGEO_CD
NINTENDO_POKEMON_MINI

Id Fix
NINTENDO_GAME_AND_WATCH
Added two systems in the scrape - NEOGEO_CD, NINTENDO_POKEMON_MINI - and updated the NINTENDO_GAME_AND_WATCH id.
pjft and others added 30 commits February 6, 2024 21:59
Minor suggestions for "Collection use during Screensaver"
1. folder elements are loaded when present in a gamelist and if they match the filesystem representation
2. missing optional folder elements are rendered empty in theme (and not "unknown")
3. As before non-existing folder elements are generated by ES, with mandatory elements <path/> and <name/>, but with this PR, whenever metadata is edited for this folder object (FileData class) it is persisted
4. Editiing metadata on existing <folder/> gets persisted too
5. UI metadata edit: layout fix that renders entered metadata not centered when returning from editing
6. UI metadata edit: format tooltip for date format in release date field
Changes to maintain and persist <folder/> information in a gamelist:
Fix for false "Save Changes" prompt on string compare of game rating.
Mention that the `pugixml` system library can be used if found, but it's optional
Fix initialization of metadata
Prevent game launchers in a directory used as game launcher, as FileData::addChild() is only valid on filesystem folders with no or no valid game extension for that platform.

Example:
```
scummvm/Violet.svm/  # directory acts as game launcher in ES, bc. of the extension.
├── Violet.svm       # file is another valid game launcher.
└── Violet.zblorb
```

May be end up in the gamelist as:
```
...
<game>
  <path>./Violet.svm</game> <!-- <game>-element bc. ES recognize only those as launchable -->
...
</game>
<game>
  <path>./Violet.svm/Violet.svm</game> <!-- <game> can not be added to parent node as it is also a <game> and not a <folder> -->
...
</game>
```
Address warning when exiting screensaver
Starting with 7.85, `CURLOPT_REDIR_PROTOCOLS` is deprecated [1] and `CURL_REDIR_PROTOCOLS_STR` [2] should be used instead.
The changes modify the option used depending on the (compile time) libcurl version.

[1] https://curl.se/libcurl/c/CURLOPT_REDIR_PROTOCOLS.html
[2] https://curl.se/libcurl/c/CURLOPT_REDIR_PROTOCOLS_STR.html
Handle cURL library deprecation for redirect options
Updated the generation script to account for Python 3.12 deprecation of 'datetime.now()'.
Re-generated the MAME resource files from the following DATs:

 * MAME 262 (Jan 2024)
 * FBNeo (22 Feb 2024)
 * Libretro Mame2003-Plus (22 Feb 2024)
resources: update MAME files and resource generator
This updates it to support mixer passthrough, and accommodate cases where the mute function wasn't supported.
… active

and fix cursor placement when changing theme with a smaller/larger gamelist viewport.
…astplayed

Fix cursor overrun in last played collection when LR/LB paging is used
…tion

Fixes segfault after metadata edit in collections and navigating back…
Fix persistence of new collections, either from theme or custom name
help text for option --fullscreen-borderless
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.