Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INF-210 grab VERSION after exiting subshell that bumped version #3636

Merged
merged 1 commit into from
Aug 4, 2022

Conversation

joaquincasares
Copy link
Contributor

Description

VERSION needs to be grabbed again since we now wrap bump-npm() within a subshell for better error detection.

Tests

Manually deploy from master.

Monitoring - How will this change be monitored? Are there sufficient logs / alerts?

Copy link
Contributor

@dylanjeffers dylanjeffers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niceee

@joaquincasares joaquincasares merged commit d2b051d into master Aug 4, 2022
@joaquincasares joaquincasares deleted the jc-inf-210.14 branch August 4, 2022 20:04
audius-infra pushed a commit that referenced this pull request Aug 4, 2022
## Changelog

- 2022-08-04 [2d720a6] Fix bundles (#3639) [Sebastian Klingler]
- 2022-08-04 [d2b051d] INF-210 grab VERSION after exiting subshell that bumped version (#3636) [Joaquin Casares]
- 2022-08-04 [27433f5] Remove extra done() callback and add sync job result (#3634) [Theo Ilie]
- 2022-08-04 [be35ce8] INF-210 fix || exit 1 logic (#3635) [Joaquin Casares]
- 2022-08-04 [ae4bd30] [C-765] Add native libs entrypoint (#3626) [Dylan Jeffers]
- 2022-08-04 [1e04215] [C-739] Patch @openzeppelin/upgrades Initializable.sol fields (#3584) [Dylan Jeffers]
- 2022-08-04 [01f924a] Fix add track to playlist notification timestamp (#3629) [Isaac Solo]
- 2022-08-03 [fcfdc3e] Remove unused labels (#3628) [Theo Ilie]
- 2022-08-03 [2d2fcca] [CON-301] add prometheus to queues (#3595) [Johannes Naylor]
- 2022-08-03 [798b7fa] CON-303 Cache CN 200-status /health_check responses for 1sec in nginx (#3624) [Sid Sethi]
- 2022-08-03 [b33a56c] Throw error in syncImmediateQueue (#3625) [Dheeraj Manjunath]
- 2022-08-03 [1239375] Tests for aggregate table triggers (#3623) [Steve Perkins]
- 2022-08-03 [e164665] INF-210 Finishing changes (#3617) [Joaquin Casares]
- 2022-08-03 [9b5f4c9] New queue for immediate sync (#3619) [Dheeraj Manjunath]
- 2022-08-03 [5cef789] Fix attemptNumber not getting updated + increase queue histories (#3622) [Theo Ilie]
- 2022-08-03 [683d545] Related artists index2 (#3621) [Steve Perkins]
- 2022-08-03 [c3a0149] Change path due to recent libs change (#3620) [Cheran]
- 2022-08-03 [216bf25] Land #21 from docs.audius.org (#3514) [Raymond Jacobson]
- 2022-08-02 [54713a7] [C-736] Refactor AudiusLibs to typescript (#3597) [Dylan Jeffers]
- 2022-08-02 [54b7db8] Fix runtime includes TypeError (#3178) [Dylan Jeffers]
- 2022-08-02 [89e0db2] Bump sdk to v0.0.29 [audius-infra]
audius-infra pushed a commit that referenced this pull request Aug 4, 2022
## Changelog

- 2022-08-04 [a3556c3] include v as VERSION prefix (#3641) [Joaquin Casares]
- 2022-08-04 [7755c57] Update SDK (#3633) [Michael Piazza]
- 2022-08-04 [3f6256f] INF-210 rename GIT_TAG to GIT_COMMIT (#3637) [Joaquin Casares]
- 2022-08-04 [2d720a6] Fix bundles (#3639) [Sebastian Klingler]
- 2022-08-04 [d2b051d] INF-210 grab VERSION after exiting subshell that bumped version (#3636) [Joaquin Casares]
- 2022-08-04 [27433f5] Remove extra done() callback and add sync job result (#3634) [Theo Ilie]
- 2022-08-04 [be35ce8] INF-210 fix || exit 1 logic (#3635) [Joaquin Casares]
- 2022-08-04 [ae4bd30] [C-765] Add native libs entrypoint (#3626) [Dylan Jeffers]
- 2022-08-04 [1e04215] [C-739] Patch @openzeppelin/upgrades Initializable.sol fields (#3584) [Dylan Jeffers]
- 2022-08-04 [01f924a] Fix add track to playlist notification timestamp (#3629) [Isaac Solo]
- 2022-08-03 [fcfdc3e] Remove unused labels (#3628) [Theo Ilie]
- 2022-08-03 [2d2fcca] [CON-301] add prometheus to queues (#3595) [Johannes Naylor]
- 2022-08-03 [798b7fa] CON-303 Cache CN 200-status /health_check responses for 1sec in nginx (#3624) [Sid Sethi]
- 2022-08-03 [b33a56c] Throw error in syncImmediateQueue (#3625) [Dheeraj Manjunath]
- 2022-08-03 [1239375] Tests for aggregate table triggers (#3623) [Steve Perkins]
- 2022-08-03 [e164665] INF-210 Finishing changes (#3617) [Joaquin Casares]
- 2022-08-03 [9b5f4c9] New queue for immediate sync (#3619) [Dheeraj Manjunath]
- 2022-08-03 [5cef789] Fix attemptNumber not getting updated + increase queue histories (#3622) [Theo Ilie]
- 2022-08-03 [683d545] Related artists index2 (#3621) [Steve Perkins]
- 2022-08-03 [c3a0149] Change path due to recent libs change (#3620) [Cheran]
- 2022-08-03 [216bf25] Land #21 from docs.audius.org (#3514) [Raymond Jacobson]
- 2022-08-02 [54713a7] [C-736] Refactor AudiusLibs to typescript (#3597) [Dylan Jeffers]
- 2022-08-02 [54b7db8] Fix runtime includes TypeError (#3178) [Dylan Jeffers]
- 2022-08-02 [89e0db2] Bump sdk to v0.0.29 [audius-infra]
sliptype pushed a commit that referenced this pull request Sep 10, 2023
sliptype pushed a commit that referenced this pull request Sep 10, 2023
[fe5fda4] Fix entity button widths (#3650) Dylan Jeffers
[820e79e] Fix user profile always showing artist tabs (#3648) Dylan Jeffers
[bc34b6f] [C-2697] Fix mobile playlist qa issues (#3638) Dylan Jeffers
[3e8d7e8] Mobile chats recalculate container bottom on keyboard shown (#3644) Reed
[39928cf] Bump app versions for full release (#3643) Reed
[437e971] Update SDK to v3.0.3-beta.56 (#3641) Marcus Pasell
[3e42cb2] [PAY-1526] Mobile chat reaction picker shadow (#3642) Reed
[ab33206] Amplitude tracking for chat report abuse (#3639) Reed
[6f570c6] Put playlist-artwork generation behind flag (#3640) Dylan Jeffers
[2f1f40d] [C-2475] Add desktop favorites playlist tab (#3637) Dylan Jeffers
[394cacb] [PAY-1516] Chat report abuse flow (#3636) Reed
[82204ec] [C-2763] Fix desktop playlist qa issues (#3634) Dylan Jeffers
[3912407] Implement OAuth Write Popup C-2664 (#3628) nicoback2
[7e13b54] [C-2783] Add terms of service link (#3635) Dylan Jeffers
[bda6eeb] Refactor: extract reusable modal field component (#3631) Andrew Mendelsohn
[c2a59dc] [PAY-1319] Fix emoji keyboard overlapping chat text input (#3629) Reed
[14150ec] [C-2784] Refactor track page to use entity button (#3624) Dylan Jeffers
[5a3e74e] [PAY-1457] Add amplitude analytics to chat features (#3627) Marcus Pasell
[d1aee10] [PAY-1412] Reset player state on app load (#3632) Reed
[965330c] [PAY-1191] Finesse keyboard enter/exit animations (#3633) Michael Piazza
[c9c531e] Create grant upon making developer app (#3630) nicoback2
[a33de30] [PAY-1464] DMs: Go to chat after successful tip (#3625) Marcus Pasell
[646a5eb] [PLAT-1015] Remove entity manager feature flag (#3619) Raymond Jacobson
[31450e7] [PAY-1498][PAY-1477] Misc mobile DMs UI Fixes (#3626) Michael Piazza
[a08f3e7] [C-2760, C-2779] Fix header for playlist and artists tabs in explore screen (#3579) Kyle Shanks
[9a98157] [C-2676] Rough release date modal (#3610) Andrew Mendelsohn
[5e9a847] [C-2771, C-2772] Add duplicate add to playlist confirmation drawer and modal (#3601) Kyle Shanks
[49ca553] [PAY-1468] Fix mobile chats copy message button (#3623) Reed
[193ae1c] [PAY-1483] Patch RN to fix textinput multiline onchange not firing (#3622) Reed
@AudiusProject AudiusProject deleted a comment from linear bot Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants