[C-749] Support req pagination and ordering in hist/fav/tracks #3643

raymondjacobson · 2022-08-05T00:43:25Z

Description

Support simple filter on history/faves/tracks for respective table views in client.

The next step is sorters, which is a bit more complex because we don't join with users up front. We should actually change this though -- it should be all in one join RT to the db. This should be possible, but needs a tiny bit of reworking. After this step, we can make the ilike queries here to include artist name, which would be nice. Eventually gql/ES is the way to go here though.
--> EDIT: Part of this was added to this PR b/c we already have the relationship @rickyrombo added :)

And the third step will be to add total count via the X-Total-Count which will be a perf hit b/c that would be a count(*) in addition to the queries. Possibly we don't want that for everything, but it's necessary at least on the artist dashboard side.

Tests

Units + local stack pointed at db snapshot

Monitoring - How will this change be monitored? Are there sufficient logs / alerts?

discovery-provider/src/queries/query_helpers.py

discovery-provider/src/queries/get_user_listening_history.py

jowlee · 2022-08-05T17:26:55Z

discovery-provider/src/queries/get_user_listening_history.py

    for listen in listening_history_results:
        track_ids.append(listen["track_id"])
-        listen_dates.append(listen["timestamp"])
-
-    track_results = (session.query(Track).filter(Track.track_id.in_(track_ids))).all()


there was no "is_current" filter here - I image this causing the query to be slow

## Changelog - 2022-08-11 [8c2deb9] Use correct configuration for full endpoints (#3673) [Sebastian Klingler] - 2022-08-10 [5ab2d47] [CON-222] Fix SequelizeUniqueConstraintError for blockchain track+user IDs (#3660) [Theo Ilie] - 2022-08-10 [1f55962] Bump to version 0.3.64 (#3669) [Cheran] - 2022-08-10 [8e21b0e] Bump random replica select attempt count + filter out existing nodes from healthy replica set (#3661) [vicky :)] - 2022-08-09 [19da757] Fix TypeError for userSecondarySyncMetrics (#3668) [Theo Ilie] - 2022-08-09 [788d482] CON-297 Auth check the requester is the primary of the observed user (#3598) [vicky :)] - 2022-08-09 [7436c17] Add unique constraint to notification (#3657) [Joseph Lee] - 2022-08-09 [4d03415] Add slack-secrets to jobs that use Slack notifications (#3666) [Joaquin Casares] - 2022-08-09 [feed5ab] Revert "Repair missing wallets (#3656)" (#3659) [Raymond Jacobson] - 2022-08-09 [8196748] Change openresty location directive from exact match to regex (#3664) [Dheeraj Manjunath] - 2022-08-08 [1c2f069] Repair missing wallets (#3656) [Raymond Jacobson] - 2022-08-08 [f4d5481] Upgrade service-commands to latest sdk (#3655) [Dheeraj Manjunath] - 2022-08-08 [90a1601] safer kill_running_queries_sql (#3653) [Steve Perkins] - 2022-08-08 [6194260] Rename processImmediateSync to processManualImmediateSync for clarity (#3632) [Dheeraj Manjunath] - 2022-08-05 [f25994c] Fix Prometheus Metric Names for Bull Queue Durations (#3649) [Johannes Naylor] - 2022-08-05 [a2d9937] Add remix cosign (#3650) [Joseph Lee] - 2022-08-05 [bbf5556] [C-749] Support req pagination and ordering in hist/fav/tracks (#3643) [Raymond Jacobson] - 2022-08-05 [d6acc56] INF add alerts for failed gcp bake jobs (#3647) [Joaquin Casares] - 2022-08-05 [a0ee00a] postgres triggers for discovery notifications (#3464) [Joseph Lee] - 2022-08-05 [7a4d9ea] Bump sdk to v0.0.32 [audius-infra]

[fe5fda4] Fix entity button widths (#3650) Dylan Jeffers [820e79e] Fix user profile always showing artist tabs (#3648) Dylan Jeffers [bc34b6f] [C-2697] Fix mobile playlist qa issues (#3638) Dylan Jeffers [3e8d7e8] Mobile chats recalculate container bottom on keyboard shown (#3644) Reed [39928cf] Bump app versions for full release (#3643) Reed [437e971] Update SDK to v3.0.3-beta.56 (#3641) Marcus Pasell [3e42cb2] [PAY-1526] Mobile chat reaction picker shadow (#3642) Reed [ab33206] Amplitude tracking for chat report abuse (#3639) Reed [6f570c6] Put playlist-artwork generation behind flag (#3640) Dylan Jeffers [2f1f40d] [C-2475] Add desktop favorites playlist tab (#3637) Dylan Jeffers [394cacb] [PAY-1516] Chat report abuse flow (#3636) Reed [82204ec] [C-2763] Fix desktop playlist qa issues (#3634) Dylan Jeffers [3912407] Implement OAuth Write Popup C-2664 (#3628) nicoback2 [7e13b54] [C-2783] Add terms of service link (#3635) Dylan Jeffers [bda6eeb] Refactor: extract reusable modal field component (#3631) Andrew Mendelsohn [c2a59dc] [PAY-1319] Fix emoji keyboard overlapping chat text input (#3629) Reed [14150ec] [C-2784] Refactor track page to use entity button (#3624) Dylan Jeffers [5a3e74e] [PAY-1457] Add amplitude analytics to chat features (#3627) Marcus Pasell [d1aee10] [PAY-1412] Reset player state on app load (#3632) Reed [965330c] [PAY-1191] Finesse keyboard enter/exit animations (#3633) Michael Piazza [c9c531e] Create grant upon making developer app (#3630) nicoback2 [a33de30] [PAY-1464] DMs: Go to chat after successful tip (#3625) Marcus Pasell [646a5eb] [PLAT-1015] Remove entity manager feature flag (#3619) Raymond Jacobson [31450e7] [PAY-1498][PAY-1477] Misc mobile DMs UI Fixes (#3626) Michael Piazza [a08f3e7] [C-2760, C-2779] Fix header for playlist and artists tabs in explore screen (#3579) Kyle Shanks [9a98157] [C-2676] Rough release date modal (#3610) Andrew Mendelsohn [5e9a847] [C-2771, C-2772] Add duplicate add to playlist confirmation drawer and modal (#3601) Kyle Shanks [49ca553] [PAY-1468] Fix mobile chats copy message button (#3623) Reed [193ae1c] [PAY-1483] Patch RN to fix textinput multiline onchange not firing (#3622) Reed

[C-749] Support req pagination and ordering in hist/fav/tracks

3acfb64

pull-request-size bot added the size/L label Aug 5, 2022

raymondjacobson requested review from isaacsolo and Kyle-Shanks August 5, 2022 00:43

raymondjacobson added 2 commits August 5, 2022 07:42

Update sdk types

bd43c93

Fix populate users and filter on artist too

7058dbf

raymondjacobson assigned jowlee Aug 5, 2022

Kyle-Shanks reviewed Aug 5, 2022

View reviewed changes

discovery-provider/src/queries/query_helpers.py Show resolved Hide resolved

Kyle-Shanks approved these changes Aug 5, 2022

View reviewed changes

isaacsolo reviewed Aug 5, 2022

View reviewed changes

discovery-provider/src/queries/get_user_listening_history.py Outdated Show resolved Hide resolved

Remove log

be419b4

jowlee approved these changes Aug 5, 2022

View reviewed changes

isaacsolo self-requested a review August 5, 2022 20:04

isaacsolo approved these changes Aug 5, 2022

View reviewed changes

raymondjacobson merged commit bbf5556 into master Aug 5, 2022

raymondjacobson deleted the rj-c-749 branch August 5, 2022 20:55

sliptype pushed a commit that referenced this pull request Sep 10, 2023

Bump app versions for full release (#3643)

a4553ed

AudiusProject deleted a comment from linear bot Sep 11, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[C-749] Support req pagination and ordering in hist/fav/tracks #3643

[C-749] Support req pagination and ordering in hist/fav/tracks #3643

raymondjacobson commented Aug 5, 2022 •

edited

Loading

jowlee Aug 5, 2022

[C-749] Support req pagination and ordering in hist/fav/tracks #3643

[C-749] Support req pagination and ordering in hist/fav/tracks #3643

Conversation

raymondjacobson commented Aug 5, 2022 • edited Loading

Description

Tests

Monitoring - How will this change be monitored? Are there sufficient logs / alerts?

jowlee Aug 5, 2022

Choose a reason for hiding this comment

raymondjacobson commented Aug 5, 2022 •

edited

Loading