Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix legacy and sdk types, monitoringCallbacks, native exports #3644

Merged
merged 2 commits into from
Aug 5, 2022
Merged

Fix legacy and sdk types, monitoringCallbacks, native exports #3644

merged 2 commits into from
Aug 5, 2022

Conversation

dylanjeffers
Copy link
Contributor

Description

  • Fixes legacy and sdk types (legacy was untyped since it was being reffed by src/index.ts)
  • Consolidates monitoringCallback types across libs
  • Exports Utils and SanityChecks in native build, and also adds configure stubs

@dylanjeffers dylanjeffers requested a review from sliptype August 5, 2022 02:17
sliptype
sliptype approved these changes Aug 5, 2022
View reviewed changes
libs/src/index.ts
/**
* @deprecated Please migrate to using `sdk` when possible
*/
export * from './AudiusLibs'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this break consumers that aren't using the legacy import? Like this for example https://github.com/AudiusProject/audius-protocol/blob/master/creator-node/src/routes/files.js#L40

Copy link
Contributor Author

@dylanjeffers dylanjeffers Aug 5, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah you're so right, adding the shim stuff back

@dylanjeffers dylanjeffers merged commit 358012d into master Aug 5, 2022
@dylanjeffers dylanjeffers deleted the dj-fix-legacy-types branch August 5, 2022 05:50
audius-infra pushed a commit that referenced this pull request Aug 5, 2022
Bump sdk to v0.0.32
3b1dd57 
## Changelog

- 2022-08-05 [21fc91b] [PLAT-259] Upgrade EthereumTx version (#3606) [Raymond Jacobson]
- 2022-08-05 [907ffe9] Add delegateOwnerWallet to CN register (#3645) [Cheran]
- 2022-08-04 [358012d] Fix legacy and sdk types, monitoringCallbacks, native exports (#3644) [Dylan Jeffers]
- 2022-08-04 [573093e] Make syncs release locks when short circuiting (#3638) [Theo Ilie]
- 2022-08-04 [829e64b] Bump sdk to v0.0.31 [audius-infra]
audius-infra pushed a commit that referenced this pull request Aug 5, 2022
Bump sdk to v0.0.32
7a4d9ea 
## Changelog

- 2022-08-05 [21fc91b] [PLAT-259] Upgrade EthereumTx version (#3606) [Raymond Jacobson]
- 2022-08-05 [907ffe9] Add delegateOwnerWallet to CN register (#3645) [Cheran]
- 2022-08-04 [358012d] Fix legacy and sdk types, monitoringCallbacks, native exports (#3644) [Dylan Jeffers]
- 2022-08-04 [573093e] Make syncs release locks when short circuiting (#3638) [Theo Ilie]
- 2022-08-04 [829e64b] Bump sdk to v0.0.31 [audius-infra]
sliptype pushed a commit that referenced this pull request Sep 10, 2023
@dharit-tan
Mobile chats recalculate container bottom on keyboard shown (#3644)
d49d706
sliptype pushed a commit that referenced this pull request Sep 10, 2023
v1.5.30
ecc0d94 
[fe5fda4] Fix entity button widths (#3650) Dylan Jeffers
[820e79e] Fix user profile always showing artist tabs (#3648) Dylan Jeffers
[bc34b6f] [C-2697] Fix mobile playlist qa issues (#3638) Dylan Jeffers
[3e8d7e8] Mobile chats recalculate container bottom on keyboard shown (#3644) Reed
[39928cf] Bump app versions for full release (#3643) Reed
[437e971] Update SDK to v3.0.3-beta.56 (#3641) Marcus Pasell
[3e42cb2] [PAY-1526] Mobile chat reaction picker shadow (#3642) Reed
[ab33206] Amplitude tracking for chat report abuse (#3639) Reed
[6f570c6] Put playlist-artwork generation behind flag (#3640) Dylan Jeffers
[2f1f40d] [C-2475] Add desktop favorites playlist tab (#3637) Dylan Jeffers
[394cacb] [PAY-1516] Chat report abuse flow (#3636) Reed
[82204ec] [C-2763] Fix desktop playlist qa issues (#3634) Dylan Jeffers
[3912407] Implement OAuth Write Popup C-2664 (#3628) nicoback2
[7e13b54] [C-2783] Add terms of service link (#3635) Dylan Jeffers
[bda6eeb] Refactor: extract reusable modal field component (#3631) Andrew Mendelsohn
[c2a59dc] [PAY-1319] Fix emoji keyboard overlapping chat text input (#3629) Reed
[14150ec] [C-2784] Refactor track page to use entity button (#3624) Dylan Jeffers
[5a3e74e] [PAY-1457] Add amplitude analytics to chat features (#3627) Marcus Pasell
[d1aee10] [PAY-1412] Reset player state on app load (#3632) Reed
[965330c] [PAY-1191] Finesse keyboard enter/exit animations (#3633) Michael Piazza
[c9c531e] Create grant upon making developer app (#3630) nicoback2
[a33de30] [PAY-1464] DMs: Go to chat after successful tip (#3625) Marcus Pasell
[646a5eb] [PLAT-1015] Remove entity manager feature flag (#3619) Raymond Jacobson
[31450e7] [PAY-1498][PAY-1477] Misc mobile DMs UI Fixes (#3626) Michael Piazza
[a08f3e7] [C-2760, C-2779] Fix header for playlist and artists tabs in explore screen (#3579) Kyle Shanks
[9a98157] [C-2676] Rough release date modal (#3610) Andrew Mendelsohn
[5e9a847] [C-2771, C-2772] Add duplicate add to playlist confirmation drawer and modal (#3601) Kyle Shanks
[49ca553] [PAY-1468] Fix mobile chats copy message button (#3623) Reed
[193ae1c] [PAY-1483] Patch RN to fix textinput multiline onchange not firing (#3622) Reed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sliptype sliptype sliptype approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dylanjeffers @sliptype