Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CON-307 Clear all running DB queries on server start #3640

Merged
merged 2 commits into from
Aug 4, 2022

Conversation

dmanjunath
Copy link
Contributor

@dmanjunath dmanjunath commented Aug 4, 2022

Description

Clear running db queries on content node server init.

Tests

Used psql to print running queries, restarted the server to run the clearRunningQueries() function and confirmed that the previously running queries are no longer running.

Monitoring - How will this change be monitored? Are there sufficient logs / alerts?

Use psql or navicat to check the running queries on a db after init, should be empty

@dmanjunath dmanjunath requested a review from SidSethi August 4, 2022 21:00
@dmanjunath dmanjunath marked this pull request as ready for review August 4, 2022 21:00
Copy link
Contributor

@SidSethi SidSethi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testing description "Tested locally to verify that no migrations are running after server init" does not seem sufficient? i might be misunderstanding

creator-node/src/migrationManager.js Outdated Show resolved Hide resolved
creator-node/src/index.ts Outdated Show resolved Hide resolved
@SidSethi
Copy link
Contributor

SidSethi commented Aug 4, 2022

wdyt about testing description @dmanjunath

Copy link
Contributor

@SidSethi SidSethi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@dmanjunath dmanjunath merged commit 37ad770 into master Aug 4, 2022
@dmanjunath dmanjunath deleted the dm-clear-running-db-queries-content-node branch August 4, 2022 22:24
@SidSethi
Copy link
Contributor

SidSethi commented Aug 4, 2022

nice, new description clears up my confusion thx

audius-infra pushed a commit that referenced this pull request Aug 4, 2022
## Changelog

- 2022-08-04 [d141187] INF-210 include change log in commit and tag (#3642) [Joaquin Casares]
- 2022-08-04 [37ad770] Clear running migrations on server start (#3640) [Dheeraj Manjunath]
- 2022-08-04 [2528cab] Bump sdk to v0.0.30 [audius-infra]
- 2022-08-04 [18954c5] CON-305 fixInconsistentUser() fixes + logging + tests (#3631) [Sid Sethi]
audius-infra pushed a commit that referenced this pull request Aug 4, 2022
## Changelog

- 2022-08-04 [d141187] INF-210 include change log in commit and tag (#3642) [Joaquin Casares]
- 2022-08-04 [37ad770] Clear running migrations on server start (#3640) [Dheeraj Manjunath]
- 2022-08-04 [2528cab] Bump sdk to v0.0.30 [audius-infra]
- 2022-08-04 [18954c5] CON-305 fixInconsistentUser() fixes + logging + tests (#3631) [Sid Sethi]
@SidSethi SidSethi changed the title Clear running migrations on server start Clear all running DB queries on server start Aug 5, 2022
@SidSethi SidSethi changed the title Clear all running DB queries on server start CON-307 Clear all running DB queries on server start Aug 5, 2022
sliptype pushed a commit that referenced this pull request Sep 10, 2023
[fe5fda4] Fix entity button widths (#3650) Dylan Jeffers
[820e79e] Fix user profile always showing artist tabs (#3648) Dylan Jeffers
[bc34b6f] [C-2697] Fix mobile playlist qa issues (#3638) Dylan Jeffers
[3e8d7e8] Mobile chats recalculate container bottom on keyboard shown (#3644) Reed
[39928cf] Bump app versions for full release (#3643) Reed
[437e971] Update SDK to v3.0.3-beta.56 (#3641) Marcus Pasell
[3e42cb2] [PAY-1526] Mobile chat reaction picker shadow (#3642) Reed
[ab33206] Amplitude tracking for chat report abuse (#3639) Reed
[6f570c6] Put playlist-artwork generation behind flag (#3640) Dylan Jeffers
[2f1f40d] [C-2475] Add desktop favorites playlist tab (#3637) Dylan Jeffers
[394cacb] [PAY-1516] Chat report abuse flow (#3636) Reed
[82204ec] [C-2763] Fix desktop playlist qa issues (#3634) Dylan Jeffers
[3912407] Implement OAuth Write Popup C-2664 (#3628) nicoback2
[7e13b54] [C-2783] Add terms of service link (#3635) Dylan Jeffers
[bda6eeb] Refactor: extract reusable modal field component (#3631) Andrew Mendelsohn
[c2a59dc] [PAY-1319] Fix emoji keyboard overlapping chat text input (#3629) Reed
[14150ec] [C-2784] Refactor track page to use entity button (#3624) Dylan Jeffers
[5a3e74e] [PAY-1457] Add amplitude analytics to chat features (#3627) Marcus Pasell
[d1aee10] [PAY-1412] Reset player state on app load (#3632) Reed
[965330c] [PAY-1191] Finesse keyboard enter/exit animations (#3633) Michael Piazza
[c9c531e] Create grant upon making developer app (#3630) nicoback2
[a33de30] [PAY-1464] DMs: Go to chat after successful tip (#3625) Marcus Pasell
[646a5eb] [PLAT-1015] Remove entity manager feature flag (#3619) Raymond Jacobson
[31450e7] [PAY-1498][PAY-1477] Misc mobile DMs UI Fixes (#3626) Michael Piazza
[a08f3e7] [C-2760, C-2779] Fix header for playlist and artists tabs in explore screen (#3579) Kyle Shanks
[9a98157] [C-2676] Rough release date modal (#3610) Andrew Mendelsohn
[5e9a847] [C-2771, C-2772] Add duplicate add to playlist confirmation drawer and modal (#3601) Kyle Shanks
[49ca553] [PAY-1468] Fix mobile chats copy message button (#3623) Reed
[193ae1c] [PAY-1483] Patch RN to fix textinput multiline onchange not firing (#3622) Reed
@AudiusProject AudiusProject deleted a comment from linear bot Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants