Fix album notification entity type

[isaacsolo]

Description

Fixes C-3785

Discovery isn't propagating is_album so client is unable to discern album from playlist notifications. Only album milestone and of_repost notifs are affected.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.

Tested on sandbox.

/v1/full/notifications example

{
    "type": "milestone",
    "group_id": "milestone:PLAYLIST_SAVE_COUNT:id:1481913973:threshold:10",
    "is_seen": true,
    "seen_at": 1707785740,
    "actions": [
        {
            "specifier": "0MMZ6",
            "timestamp": 1707785647,
            "data": {
                "type": "playlist_save_count",
                "threshold": 10,
                "playlist_id": "qy9qx3E",
                "is_album": false
            }
        }
    ]
},

[audius-infra]

Preview this change https://demo.audius.co/is-fix-album-notification

[audius-infra]

Preview this change https://demo.audius.co/is-fix-album-notification

[audius-infra]

Preview this change https://demo.audius.co/is-fix-album-notification

[dylanjeffers]

nice improvement :) we could possibly do the same for track vs podcast/audiobook sometime.

[dylanjeffers]

did we have to break this out because we need extra param for playlist/albums json_build_object, so we couldnt combine track + playlist like we did before?

[isaacsolo]

yup exactly

[amendelsohn]

Looks great! Just need the one suggested change before merge. Thanks again for taking on the fix for this

[amendelsohn]

I think we also need to make this change in this helper function in the same file:

  function getDiscoveryEntityType(type: string) {
    if (type === 'track') {
      return Entity.Track
    }
    return Entity.Playlist
  }

This should cover the other notification types listed on the ticket

[isaacsolo]

yea it's kind of a confusing state because not all notif types have is_album but i'll update for it to be optional. we actually getting the album entity type downstream here:

audius-protocol/packages/mobile/src/screens/notifications-screen/Notifications/RepostNotification.tsx

Lines 49 to 54 in 357b2eb

	const entityTypeText =
	entity && 'is_album' in entity && entity.is_album
	? Entity.Album
	: entityType

[audius-infra]

Preview this change https://demo.audius.co/is-fix-album-notification

[gitguardian]

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
9349019	Triggered	Generic High Entropy Secret	b828e54	packages/ddex/.env.stage	View secret

🛠 Guidelines to remediate hardcoded secrets

1. Understand the implications of revoking this secret by investigating where it is used in your code.
2. Replace and store your secret safely. Learn here the best practices.
3. Revoke and rotate this secret.
4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

• following these best practices for managing and storing secrets including API keys and other credentials
• install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

---

<sup>🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!</sup>