Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discovery] Add year time range for metrics endpoints [C-3753] #7676

Merged
merged 2 commits into from
Feb 22, 2024
Merged

[Discovery] Add year time range for metrics endpoints [C-3753] #7676

merged 2 commits into from
Feb 22, 2024

Conversation

nicoback2
Copy link
Contributor

Description

For some metrics endpoints, we need a "year" time range option. This adds that.

For Protodash Improvements project

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.

@nicoback2 nicoback2 requested review from sddioulde, a team and isaacsolo and removed request for a team February 22, 2024 00:54
@nicoback2 nicoback2 changed the title [Discovery] Add year time range for metrics endpoints [Discovery] Add year time range for metrics endpoints [C-3753] Feb 22, 2024
dylanjeffers
dylanjeffers approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@dylanjeffers dylanjeffers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great on my end

...covery-provider/integration_tests/queries/test_get_aggregate_route_metrics_trailing_month.py
@@ -44,7 +44,7 @@ def test_get_aggregate_route_metrics_trailing_month(app):
]
)

aggregate_metrics = _get_aggregate_route_metrics_trailing_month(session)
aggregate_metrics = _get_aggregate_route_metrics_trailing(session, "month")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice improvement 🚀

packages/discovery-provider/src/api/v1/metrics.py
@@ -68,6 +68,12 @@
"month": ["day", "week"],
"all_time": ["month", "week"],
}
valid_bucket_sizes_with_year = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it worth being dry and referencing the values in the top object to prevent divergence?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah!

packages/discovery-provider/src/api/v1/metrics.py
@@ -158,12 +164,14 @@ def get(self):
return response


@ns.route("/aggregates/routes/trailing/month", doc=False)
@ns.route("/aggregates/routes/trailing/<string:time_range>", doc=False)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible to document the acceptable string types? ie month/year?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will check other files - there probs is

@nicoback2 nicoback2 enabled auto-merge (squash) February 22, 2024 17:52
@nicoback2 nicoback2 disabled auto-merge February 22, 2024 17:52
@nicoback2 nicoback2 merged commit dc41e93 into main Feb 22, 2024
10 of 11 checks passed
@nicoback2 nicoback2 deleted the nkang--metrics-year-2 branch February 22, 2024 17:53
@nicoback2 nicoback2 mentioned this pull request Feb 22, 2024
Merged
audius-infra pushed a commit that referenced this pull request Feb 24, 2024
v1.5.68
5452dcb 
[3ff422f] [PROTO-1513] Setup e2e test stub with LocalStack, wire it up to CI, and automate Mongo init (#7705) Theo Ilie
[e705bcf] Allow empty adc auto-deploy commits (#7709) Michelle Brier
[ebf162f] [PAY-2523] CollectionTrackRelations migration for sellable albums (#7677) Reed
[7fcc5f9] Fix harmony system-appearance (#7706) Dylan Jeffers
[f8df062] Update welcome drawer close functionality to always open the notifications drawer (#7704) Kyle Shanks
[1845dfc] Remove flipper from android and update readme (#7703) Sebastian Klingler
[ced4135] Add documents path to asset url check (#7702) Randy Schott
[c3e46e6] Bump version to 0.6.45 audius-infra
[81383fd] [C-3879] Remove web Text component (#7686) Dylan Jeffers
[138f7c8] Fix half-load of spring animation on all <Page> components (#7692) Raymond Jacobson
[cf8ad1b] Fix album notification entity type (#7580) Isaac Solo
[4f2a415] [Web] Fix red caret on Transactions History page (#7693) nicoback2
[50156e5] [PAY-2435] Remove pointer cursor when dropzone at max capacity (#7695) Saliou Diallo
[ea3365a] [C-3838] Analytics events for mobile sign up (#7655) JD Francis
[40edef7] [C-3877] Remove web icon component (#7674) Dylan Jeffers
[58c7e47] [C-3880] Add bottom padding to the safe area on the sign in screen (#7689) Kyle Shanks
[3e7f71e] Fix app site association (#7694) Sebastian Klingler
[4f92b88] [C-3855] Fix android white screen issue on sign up (#7683) JD Francis
[596f9cc] Add remote redux debugging to mobile app (#7687) Sebastian Klingler
[df30494] Fix amplitude key injection on mobile (#7690) Dylan Jeffers
[f8c4f43] [PAY-2513] Fix file size text wrap on web DownloadRow (#7688) Reed
[7084823] [PAY-2517] Change name of temp download dir on mobile (#7671) Reed
[051d95f] [PROTO-1668] placement for mediorum uploads (#7668) Steve Perkins
[17f9536] [C-3857] Remove the shadow on the verified handle section in new sign up flow (#7681) Kyle Shanks
[0d6556a] [INF-659] Remove flipper and enable experimental debugger (#7685) Sebastian Klingler
[336dc7a] [PROTO-1669] Find Mongo changes when offline and clean up DDEX (#7680) Theo Ilie
[043c3a5] [C-3863] Increase touch target of close button of artist preview banner (#7666) Kyle Shanks
[b2a0609] [C-3881] Add apiKey to the jwt payload (#7684) Raymond Jacobson
[dc41e93] [Discovery] Add year time range for metrics endpoints [C-3753] (#7676) nicoback2
[c104b7e] [C-3854] Update size of social buttons in new sign up flow (#7682) Kyle Shanks
[f772ae8] [C-3859] Fix mobile handle validation quirks (#7664) JD Francis
[21f5d8e] [DVRL-10] Ensure history uses track activity model (#7678) Raymond Jacobson
[3a8b27a] Bump version to 0.6.44 audius-infra
[eb858ee] Upgrade dependencies used in alpine base image (#7675) Reed
[9824ddc] [PROTO-1670] Find userId in DDEX parser and remove artist allowlist (#7662) Theo Ilie
[fc4ead6] ⚠️ [PAY-2421] Upload stems in parallel (#7644) Marcus Pasell
[831ca36] [C-3870] Update AccountHeader handle text to be one line (#7672) Kyle Shanks
[5c87774] [C-3876] Remove stems icons (#7670) Dylan Jeffers
[dded48a] Pin dnspython to version 2.5.0 (#7673) Isaac Solo
[ec07ff1] [C-3861] Remove default padding on text inputs for andoird (#7669) Kyle Shanks
[3c217da] [C-3873] Migrate to harmony IconButton (#7659) Dylan Jeffers
[a8ff559] [PAY-2229] Add lossless UI metrics (#7665) Saliou Diallo
[0c37ede] Revert "PROTO-1574: sepolia config and register all nodes" (#7667) alecsavvy
[51cdfd6] [DVRL-10] Add auth middleware sdk changes for history (#7663) Raymond Jacobson
[4ec621f] Bump version to 0.6.43 audius-infra
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylanjeffers dylanjeffers dylanjeffers approved these changes

@sddioulde sddioulde Awaiting requested review from sddioulde

@isaacsolo isaacsolo Awaiting requested review from isaacsolo isaacsolo was automatically assigned from AudiusProject/platform

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicoback2 @dylanjeffers @nicoback