[C-3879] Remove web Text component #7686

dylanjeffers · 2024-02-22T18:13:59Z

Description

Replaces all instances of web text component and its typography styles with harmony text

gitguardian · 2024-02-22T18:41:20Z

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
2416686	Triggered	Generic High Entropy Secret	`cc4257a`	packages/mobile/src/env/env.stage.ts	View secret
9349019	Triggered	Generic High Entropy Secret	`cc4257a`	packages/ddex/.env.stage	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secrets safely. Learn here the best practices.
Revoke and rotate these secrets.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!}

audius-infra · 2024-02-22T18:53:45Z

Preview this change https://demo.audius.co/dj-remove-text

audius-infra · 2024-02-22T22:52:37Z

Preview this change https://demo.audius.co/dj-remove-text

amendelsohn

Banger PR! Huge in every sense 👏

Do we have a plan to do a sweep of the app for places where the text has changed or looks off? Seems like there's a lot of potential here for quiet regressions. Even if we're getting closer to the unified standard, it might not be displaying as originally intended in each real usage.

amendelsohn · 2024-02-22T21:56:18Z

packages/web/src/components/publish-track-confirmation-modal/PublishTrackConfirmationModal.tsx

-          title={
-            <Text
-              variant='label'
-              size='xLarge'
-              strength='strong'
-              color='neutralLight2'
-            >
-              {messages.title}
-            </Text>
-          }


I assume consolidating the logic makes these more consistent not less, but worth calling out that I've seen lots of styling issues with modal titles in the past. Hoping this is the end of them 🤞

yeah my main goal is to remove all the ways we do it to ensure consistency, and then just getting it right :)

amendelsohn · 2024-02-22T21:57:16Z

packages/web/src/components/track/CardTitle.tsx

+    <Text
+      variant='title'
+      strength='weak'
+      className={cn(styles.headerContainer, className, ...extraStyles)}


feels so much cleaner. Love the design we went with for harmony!

amendelsohn · 2024-02-22T22:04:16Z

packages/web/src/components/track/mobile/BottomButtons.tsx

-          styles.bottomButtons
-        )}
-      >
+      <Text variant='title' size='s' className={styles.bottomButtons}>


not related to this specific section, but I just realized the inheriting behavior on our text component can cause some confusing bugs if you wrap it around rendered children.

Because each text component essentially creates a styling context, wrapping <Text>{props.children}</Text> can lead to child components being rendered with unexpected styles. I think this is mostly fine, but we should be careful about this in general.

yeah 100 agree, my hope is we move to a world where text children are only other text elements/svgs so its clear they inherit styles unless explicitly overriden

amendelsohn · 2024-02-23T00:18:45Z

packages/web/src/components/typography/constants.ts

YES good riddance

amendelsohn · 2024-02-23T00:22:53Z

packages/web/src/pages/upload-page/fields/MultiTrackSidebar.tsx

@@ -185,15 +186,9 @@ const TrackRow = (props: TrackRowProps) => {
          </div>
          <div className={styles.trackTitleContainer}>
            <Text
-              size='small'
-              // @ts-ignore TODO: support for accent-red in other themes


amendelsohn

Banger PR! Huge in every sense 👏

Do we have a plan to do a sweep of the app for places where the text has changed or looks off? Seems like there's a lot of potential here for quiet regressions. Even if we're getting closer to the unified standard, it might not be displaying as originally intended in each real usage.

amendelsohn

Banger PR! Huge in every sense 👏

Do we have a plan to do a sweep of the app for places where the text has changed or looks off? Seems like there's a lot of potential here for quiet regressions. Even if we're getting closer to the unified standard, it might not be displaying as originally intended in each real usage.

dylanjeffers · 2024-02-23T00:31:36Z

Banger PR! Huge in every sense 👏

Do we have a plan to do a sweep of the app for places where the text has changed or looks off? Seems like there's a lot of potential here for quiet regressions. Even if we're getting closer to the unified standard, it might not be displaying as originally intended in each real usage.

Thanks! Yes I'm looking to get all the refactors in for text icons links etc first and then when that's all looking good do a fine sweep of everything before the next release

[3ff422f] [PROTO-1513] Setup e2e test stub with LocalStack, wire it up to CI, and automate Mongo init (#7705) Theo Ilie [e705bcf] Allow empty adc auto-deploy commits (#7709) Michelle Brier [ebf162f] [PAY-2523] CollectionTrackRelations migration for sellable albums (#7677) Reed [7fcc5f9] Fix harmony system-appearance (#7706) Dylan Jeffers [f8df062] Update welcome drawer close functionality to always open the notifications drawer (#7704) Kyle Shanks [1845dfc] Remove flipper from android and update readme (#7703) Sebastian Klingler [ced4135] Add documents path to asset url check (#7702) Randy Schott [c3e46e6] Bump version to 0.6.45 audius-infra [81383fd] [C-3879] Remove web Text component (#7686) Dylan Jeffers [138f7c8] Fix half-load of spring animation on all <Page> components (#7692) Raymond Jacobson [cf8ad1b] Fix album notification entity type (#7580) Isaac Solo [4f2a415] [Web] Fix red caret on Transactions History page (#7693) nicoback2 [50156e5] [PAY-2435] Remove pointer cursor when dropzone at max capacity (#7695) Saliou Diallo [ea3365a] [C-3838] Analytics events for mobile sign up (#7655) JD Francis [40edef7] [C-3877] Remove web icon component (#7674) Dylan Jeffers [58c7e47] [C-3880] Add bottom padding to the safe area on the sign in screen (#7689) Kyle Shanks [3e7f71e] Fix app site association (#7694) Sebastian Klingler [4f92b88] [C-3855] Fix android white screen issue on sign up (#7683) JD Francis [596f9cc] Add remote redux debugging to mobile app (#7687) Sebastian Klingler [df30494] Fix amplitude key injection on mobile (#7690) Dylan Jeffers [f8c4f43] [PAY-2513] Fix file size text wrap on web DownloadRow (#7688) Reed [7084823] [PAY-2517] Change name of temp download dir on mobile (#7671) Reed [051d95f] [PROTO-1668] placement for mediorum uploads (#7668) Steve Perkins [17f9536] [C-3857] Remove the shadow on the verified handle section in new sign up flow (#7681) Kyle Shanks [0d6556a] [INF-659] Remove flipper and enable experimental debugger (#7685) Sebastian Klingler [336dc7a] [PROTO-1669] Find Mongo changes when offline and clean up DDEX (#7680) Theo Ilie [043c3a5] [C-3863] Increase touch target of close button of artist preview banner (#7666) Kyle Shanks [b2a0609] [C-3881] Add apiKey to the jwt payload (#7684) Raymond Jacobson [dc41e93] [Discovery] Add year time range for metrics endpoints [C-3753] (#7676) nicoback2 [c104b7e] [C-3854] Update size of social buttons in new sign up flow (#7682) Kyle Shanks [f772ae8] [C-3859] Fix mobile handle validation quirks (#7664) JD Francis [21f5d8e] [DVRL-10] Ensure history uses track activity model (#7678) Raymond Jacobson [3a8b27a] Bump version to 0.6.44 audius-infra [eb858ee] Upgrade dependencies used in alpine base image (#7675) Reed [9824ddc] [PROTO-1670] Find userId in DDEX parser and remove artist allowlist (#7662) Theo Ilie [fc4ead6] ⚠️ [PAY-2421] Upload stems in parallel (#7644) Marcus Pasell [831ca36] [C-3870] Update AccountHeader handle text to be one line (#7672) Kyle Shanks [5c87774] [C-3876] Remove stems icons (#7670) Dylan Jeffers [dded48a] Pin dnspython to version 2.5.0 (#7673) Isaac Solo [ec07ff1] [C-3861] Remove default padding on text inputs for andoird (#7669) Kyle Shanks [3c217da] [C-3873] Migrate to harmony IconButton (#7659) Dylan Jeffers [a8ff559] [PAY-2229] Add lossless UI metrics (#7665) Saliou Diallo [0c37ede] Revert "PROTO-1574: sepolia config and register all nodes" (#7667) alecsavvy [51cdfd6] [DVRL-10] Add auth middleware sdk changes for history (#7663) Raymond Jacobson [4ec621f] Bump version to 0.6.43 audius-infra

This reverts commit 81383fd.

dylanjeffers added 7 commits February 20, 2024 17:52

Replace text with harmony text

e2ab7a3

Migrate imports

c6c75e3

Size progress

ce56dd4

everything but variant

03cdece

Add body to all the missing ones

2e9ad65

Address final types

fe57904

Address a lot more things!

e0ea752

pull-request-size bot added the size/XXL label Feb 22, 2024

dylanjeffers requested review from a team and amendelsohn and removed request for a team February 22, 2024 18:14

dylanjeffers added 2 commits February 22, 2024 10:21

Merge branch 'main' into dj-remove-text

cc4257a

Fix merge conflicts

ab646e5

dylanjeffers added 2 commits February 22, 2024 14:37

Merge branch 'main' into dj-remove-text

8d68a1e

Fix lint

df2ab2f

amendelsohn approved these changes Feb 23, 2024

View reviewed changes

dylanjeffers merged commit 81383fd into main Feb 23, 2024
22 of 24 checks passed

dylanjeffers deleted the dj-remove-text branch February 23, 2024 04:40

dylanjeffers added a commit that referenced this pull request Feb 29, 2024

Revert "[C-3879] Remove web Text component (#7686)"

37616ae

This reverts commit 81383fd.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[C-3879] Remove web Text component #7686

[C-3879] Remove web Text component #7686

dylanjeffers commented Feb 22, 2024

gitguardian bot commented Feb 22, 2024 •

edited

Loading

audius-infra commented Feb 22, 2024

audius-infra commented Feb 22, 2024

amendelsohn left a comment

amendelsohn Feb 22, 2024

dylanjeffers Feb 23, 2024

amendelsohn Feb 22, 2024

amendelsohn Feb 22, 2024

dylanjeffers Feb 23, 2024

amendelsohn Feb 23, 2024

amendelsohn Feb 23, 2024

amendelsohn left a comment

amendelsohn left a comment

dylanjeffers commented Feb 23, 2024

[C-3879] Remove web Text component #7686

[C-3879] Remove web Text component #7686

Conversation

dylanjeffers commented Feb 22, 2024

Description

gitguardian bot commented Feb 22, 2024 • edited Loading

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

audius-infra commented Feb 22, 2024

audius-infra commented Feb 22, 2024

amendelsohn left a comment

Choose a reason for hiding this comment

amendelsohn Feb 22, 2024

Choose a reason for hiding this comment

dylanjeffers Feb 23, 2024

Choose a reason for hiding this comment

amendelsohn Feb 22, 2024

Choose a reason for hiding this comment

amendelsohn Feb 22, 2024

Choose a reason for hiding this comment

dylanjeffers Feb 23, 2024

Choose a reason for hiding this comment

amendelsohn Feb 23, 2024

Choose a reason for hiding this comment

amendelsohn Feb 23, 2024

Choose a reason for hiding this comment

amendelsohn left a comment

Choose a reason for hiding this comment

amendelsohn left a comment

Choose a reason for hiding this comment

dylanjeffers commented Feb 23, 2024

gitguardian bot commented Feb 22, 2024 •

edited

Loading