[C-3877] Remove web icon component #7674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 9349019 | Triggered | Generic High Entropy Secret | e069d06 | packages/ddex/.env.stage | View secret |
| 9412812 | Triggered | Generic Password | e069d06 | packages/discovery-provider/ddl/local-test.sh | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
dylanjeffers
requested review from
a team and
DejayJD
and removed request for
a team
|
Preview this change https://demo.audius.co/remove-web-icon-component |
DejayJD
reviewed
Feb 22, 2024
| @@ -22,12 +27,15 @@ const messages = { | |||
| title: 'UPLOADED TRACKS', | |||
| complete: 'Complete Upload', | |||
| fixErrors: 'Fix errors to complete your upload.', | |||
| titleRequired: 'Track name required' | |||
| titleRequired: 'Track name required', | |||
| removeTrack: 'Remove track' | |||
There was a problem hiding this comment.
Added but isn't being used from what I can see?
audius-infra
pushed a commit
that referenced
this pull request
Feb 24, 2024
[3ff422f] [PROTO-1513] Setup e2e test stub with LocalStack, wire it up to CI, and automate Mongo init (#7705) Theo Ilie [e705bcf] Allow empty adc auto-deploy commits (#7709) Michelle Brier [ebf162f] [PAY-2523] CollectionTrackRelations migration for sellable albums (#7677) Reed [7fcc5f9] Fix harmony system-appearance (#7706) Dylan Jeffers [f8df062] Update welcome drawer close functionality to always open the notifications drawer (#7704) Kyle Shanks [1845dfc] Remove flipper from android and update readme (#7703) Sebastian Klingler [ced4135] Add documents path to asset url check (#7702) Randy Schott [c3e46e6] Bump version to 0.6.45 audius-infra [81383fd] [C-3879] Remove web Text component (#7686) Dylan Jeffers [138f7c8] Fix half-load of spring animation on all <Page> components (#7692) Raymond Jacobson [cf8ad1b] Fix album notification entity type (#7580) Isaac Solo [4f2a415] [Web] Fix red caret on Transactions History page (#7693) nicoback2 [50156e5] [PAY-2435] Remove pointer cursor when dropzone at max capacity (#7695) Saliou Diallo [ea3365a] [C-3838] Analytics events for mobile sign up (#7655) JD Francis [40edef7] [C-3877] Remove web icon component (#7674) Dylan Jeffers [58c7e47] [C-3880] Add bottom padding to the safe area on the sign in screen (#7689) Kyle Shanks [3e7f71e] Fix app site association (#7694) Sebastian Klingler [4f92b88] [C-3855] Fix android white screen issue on sign up (#7683) JD Francis [596f9cc] Add remote redux debugging to mobile app (#7687) Sebastian Klingler [df30494] Fix amplitude key injection on mobile (#7690) Dylan Jeffers [f8c4f43] [PAY-2513] Fix file size text wrap on web DownloadRow (#7688) Reed [7084823] [PAY-2517] Change name of temp download dir on mobile (#7671) Reed [051d95f] [PROTO-1668] placement for mediorum uploads (#7668) Steve Perkins [17f9536] [C-3857] Remove the shadow on the verified handle section in new sign up flow (#7681) Kyle Shanks [0d6556a] [INF-659] Remove flipper and enable experimental debugger (#7685) Sebastian Klingler [336dc7a] [PROTO-1669] Find Mongo changes when offline and clean up DDEX (#7680) Theo Ilie [043c3a5] [C-3863] Increase touch target of close button of artist preview banner (#7666) Kyle Shanks [b2a0609] [C-3881] Add apiKey to the jwt payload (#7684) Raymond Jacobson [dc41e93] [Discovery] Add year time range for metrics endpoints [C-3753] (#7676) nicoback2 [c104b7e] [C-3854] Update size of social buttons in new sign up flow (#7682) Kyle Shanks [f772ae8] [C-3859] Fix mobile handle validation quirks (#7664) JD Francis [21f5d8e] [DVRL-10] Ensure history uses track activity model (#7678) Raymond Jacobson [3a8b27a] Bump version to 0.6.44 audius-infra [eb858ee] Upgrade dependencies used in alpine base image (#7675) Reed [9824ddc] [PROTO-1670] Find userId in DDEX parser and remove artist allowlist (#7662) Theo Ilie [fc4ead6]⚠️ [PAY-2421] Upload stems in parallel (#7644) Marcus Pasell [831ca36] [C-3870] Update AccountHeader handle text to be one line (#7672) Kyle Shanks [5c87774] [C-3876] Remove stems icons (#7670) Dylan Jeffers [dded48a] Pin dnspython to version 2.5.0 (#7673) Isaac Solo [ec07ff1] [C-3861] Remove default padding on text inputs for andoird (#7669) Kyle Shanks [3c217da] [C-3873] Migrate to harmony IconButton (#7659) Dylan Jeffers [a8ff559] [PAY-2229] Add lossless UI metrics (#7665) Saliou Diallo [0c37ede] Revert "PROTO-1574: sepolia config and register all nodes" (#7667) alecsavvy [51cdfd6] [DVRL-10] Add auth middleware sdk changes for history (#7663) Raymond Jacobson [4ec621f] Bump version to 0.6.43 audius-infra
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces instances of web icon component with harmony icons directly.
This component existed as a placeholder before we figured out how to use svgr to decorate our svgs with special props