Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contact Info Widget: Add '%s' to the confit-hours div #13984

Merged
merged 1 commit into from
Nov 7, 2019
Merged

Contact Info Widget: Add '%s' to the confit-hours div #13984

merged 1 commit into from
Nov 7, 2019

Conversation

kbrown9
Copy link
Member

@kbrown9 kbrown9 commented Nov 7, 2019

This fixes a bug that prevents the hours from being displayed.

Fixes #13982

Changes proposed in this Pull Request:

  • Add '%s' to the confit-hours div.

Is this a new feature or does it add/remove features to an existing part of Jetpack?

  • This fixes a bug in an existing feature.

Testing instructions:

  • Install and activate Jetpack.
  • Enable the Extra SIdebar Widgets module.
  • Add a Contact Info Widget using the Customizer or from Appearance -> Widgets.
  • Ensure that there is some text in the Hours text box.
  • Save the widget.
  • If using the Customizer, make sure that the Contact Info widget in the preview correctly displays the hours text.
  • Navigate to a post on your site and make sure that the Contact Info widget correctly displays the hours text.

Proposed changelog entry for your changes:

  • Fixed a bug that prevented the hours from being displayed in the Contact Info widget.

@kbrown9
Contact Info Widget: Add '%s' to the confit-hours div
015cc02 
This fixes a bug that prevents the hours from being displayed.
@kbrown9 kbrown9 added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Extra Sidebar Widgets [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Pri] High labels Nov 7, 2019
@kbrown9 kbrown9 requested a review from a team November 7, 2019 03:42
@kbrown9 kbrown9 self-assigned this Nov 7, 2019
@jetpackbot
Copy link

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: December 3, 2019.
Scheduled code freeze: November 26, 2019

Generated by 🚫 dangerJS against 015cc02

@jeherve jeherve added this to the 7.9.1 milestone Nov 7, 2019
jeherve
jeherve approved these changes Nov 7, 2019
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. This was introduced in #13664. I had missed that in my review, sorry :(

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Nov 7, 2019
@kraftbj kraftbj merged commit a09e788 into master Nov 7, 2019
@kraftbj kraftbj deleted the fix/contact-info-hours-string branch November 7, 2019 23:19
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Nov 7, 2019
jeherve added a commit that referenced this pull request Nov 8, 2019
@jeherve
Changelog: add #13984
e8df2c1
jeherve pushed a commit that referenced this pull request Nov 8, 2019
@kbrown9 @jeherve
[not verified] Contact Info Widget: Add '%s' to the confit-hours div (#…
4003bc5 
…13984)

This fixes a bug that prevents the hours from being displayed.
@jeherve
Copy link
Member

jeherve commented Nov 8, 2019

Cherry-picked to branch-7.9 in 4003bc5

@desnum desnum mentioned this pull request Nov 9, 2019
Closed
jeherve added a commit that referenced this pull request Nov 15, 2019
@jeherve
Changelog: add #13984
cdbe9d0
jeherve added a commit that referenced this pull request Nov 25, 2019
@jeherve
8.0 Release: running changelog (#13964)
807ab89 
* 8.0 Release: running changelog

* Changelog: add #13921

* Changelog: add #13980

* Changelog: add #13905

* Changelog: add #13971

* Changelog: add #13984

* Changelog: add #14009

* Changelog: add #13620

* Remove things that will ship in 7.9.1

* Changelog: add 7.9.1 release (#14044)

* Changelog: add base for 7.9.1 release

* Update release date and post link

* Changelog: add #14066

* Update changelog for 7.9.1

* Changelog: add #13405

* Changelog: add #13841

* Changelog: add #13924

* Changelog: add #13986

* Changelog: add #14010, #14028, #14053, #14055.

* Changelog: add #14054

* Changelog: add #14031

* Changelog: add #14039

* Changelog: add #14050

* Changelog: add #14070

* Changelog: add #14082

* Changelog: add #14084

* Changelog: add #14111

* Changelog: add #13961

* Changelog: add #14047

* Changelog: add #14091

* Changelog: add #14108

* Changelog: add #14121
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

@kraftbj kraftbj kraftbj approved these changes

Assignees

@kbrown9 kbrown9

Labels
[Feature] Extra Sidebar Widgets [Pri] High Touches WP.com Files [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
7.9.1
Development

Successfully merging this pull request may close these issues.

Contact & Info Widget: Hours field not showing text input
5 participants
@kbrown9 @jetpackbot @jeherve @kraftbj @matticbot