Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blocks: move from editor to block-editor #14047

Merged
merged 1 commit into from
Nov 25, 2019
Merged

Blocks: move from editor to block-editor #14047

merged 1 commit into from
Nov 25, 2019

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Nov 15, 2019

Changes proposed in this Pull Request:

Now that Jetpack will require WordPress 5.2 (see #13620), we can update our blocks to use the @wordpress/block-editor package that was added in WP 5.2.
This will get rid of a few deprecated messages that were present when using the block editor.

Testing instructions:

  • Test all the blocks and their settings in the block sidebar, as well as when addding content to blocks.

Proposed changelog entry for your changes:

  • Blocks: start using the @wordpress/block-editor package introduced in WordPress 5.2.

@jeherve
Blocks: move from editor to block-editor
7b4e07c 
Now that Jetpack will require WordPress 5.2, we can update our blocks to use the @wordpress/block-editor package that was added in WP 5.2.
This will get rid of a few deprecated messages that were present when using the block editor.
@jeherve jeherve added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Type] Janitorial [Pri] Normal [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack labels Nov 15, 2019
@jeherve jeherve added this to the 8.0 milestone Nov 15, 2019
@jeherve jeherve requested review from a team November 15, 2019 15:56
@jeherve jeherve self-assigned this Nov 15, 2019
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello jeherve! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D35538-code before merging this PR. Thank you!

@jetpackbot
Copy link

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: November 18, 2019.
Scheduled code freeze: November 11, 2019

Generated by 🚫 dangerJS against 7b4e07c

pento
pento approved these changes Nov 18, 2019
View reviewed changes
Copy link
Contributor

@pento pento left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've run through these blocks, they all appear to be functioning correctly (except for some unrelated issues I ran into with the Map block: #14057, #14058).

I've also confirmed that remaining uses of @wordpress/editor are correct.

@wordpress/block-editor should probably be added to package.json.

Otherwise, looks good to me!

@simison
Copy link
Member

simison commented Nov 22, 2019

@wordpress/block-editor should probably be added to package.json.

Since @wordpress/* deps are externalized in build and they're not built into our JS bundles, there's no need to add them to package.json. We don't have control over their versions anyway; we just get whatever is in used WordPress. :-)

They need to be added in some special cases though, I think if we depend on them in unit tests for example.

simison
simison approved these changes Nov 22, 2019
View reviewed changes
Copy link
Member

@simison simison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested but overall looks good. 👍

Thanks for taking on it!

dereksmart
dereksmart approved these changes Nov 25, 2019
View reviewed changes
Copy link
Member

@dereksmart dereksmart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran through all the blocks quickly, including paid ones. Adding them at the basic level and viewing on front-end. All seemed to work well with no console errors.

@dereksmart dereksmart added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Nov 25, 2019
@matticbot
Copy link
Contributor

jeherve, Your synced wpcom patch D35538-code has been updated.

@jeherve jeherve merged commit 47bd913 into master Nov 25, 2019
@jeherve jeherve deleted the update/blocks-blockeditor branch November 25, 2019 16:28
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Nov 25, 2019
jeherve added a commit that referenced this pull request Nov 25, 2019
@jeherve
Changelog: add #14047
9aa904a
jeherve added a commit that referenced this pull request Nov 25, 2019
@jeherve
8.0 Release: running changelog (#13964)
807ab89 
* 8.0 Release: running changelog

* Changelog: add #13921

* Changelog: add #13980

* Changelog: add #13905

* Changelog: add #13971

* Changelog: add #13984

* Changelog: add #14009

* Changelog: add #13620

* Remove things that will ship in 7.9.1

* Changelog: add 7.9.1 release (#14044)

* Changelog: add base for 7.9.1 release

* Update release date and post link

* Changelog: add #14066

* Update changelog for 7.9.1

* Changelog: add #13405

* Changelog: add #13841

* Changelog: add #13924

* Changelog: add #13986

* Changelog: add #14010, #14028, #14053, #14055.

* Changelog: add #14054

* Changelog: add #14031

* Changelog: add #14039

* Changelog: add #14050

* Changelog: add #14070

* Changelog: add #14082

* Changelog: add #14084

* Changelog: add #14111

* Changelog: add #13961

* Changelog: add #14047

* Changelog: add #14091

* Changelog: add #14108

* Changelog: add #14121
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dereksmart dereksmart dereksmart approved these changes

@pento pento pento approved these changes

@simison simison simison approved these changes

Assignees

@jeherve jeherve

Labels
[Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Pri] Normal Touches WP.com Files [Type] Janitorial
Projects
None yet
Milestone
8.0
Development

Successfully merging this pull request may close these issues.
6 participants
@jeherve @matticbot @jetpackbot @simison @pento @dereksmart