Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recurring payments: adds isPrimary class to primary action buttons #14031

Merged
merged 1 commit into from
Nov 19, 2019
Merged

Recurring payments: adds isPrimary class to primary action buttons #14031

merged 1 commit into from
Nov 19, 2019

Conversation

keoshi
Copy link
Contributor

@keoshi keoshi commented Nov 14, 2019 •
edited
Loading

Changes proposed in this Pull Request:

  • Adds the correct class isPrimary to primary action buttons in the Recurring Payments block.

Testing instructions:

  • Fire up this PR.
  • Add a new post and include the Recurring Payments block.
  • Set up Stripe if you haven't done so already.
  • When setting up the recurring payment, ensure all primary actions are correctly styled with a primary button.

Before

image

image

After

image

image

Proposed changelog entry for your changes:

  • None

@keoshi keoshi added [Focus] Accessibility Improving usability for all users (a11y) [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Block] Payment Button aka Recurring Payments labels Nov 14, 2019
@keoshi keoshi requested a review from a team November 14, 2019 12:21
@keoshi keoshi self-assigned this Nov 14, 2019
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello keoshi! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D35478-code before merging this PR. Thank you!

@jetpackbot
Copy link

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: December 3, 2019.
Scheduled code freeze: November 26, 2019

Generated by 🚫 dangerJS against 1aff017

@jeherve jeherve added this to the 8.0 milestone Nov 14, 2019
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Nov 14, 2019
jeherve
jeherve approved these changes Nov 14, 2019
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@jeherve jeherve merged commit 0b415a8 into master Nov 19, 2019
@jeherve jeherve deleted the update/recurring-payments-primary-buttons branch November 19, 2019 15:44
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Nov 19, 2019
jeherve added a commit that referenced this pull request Nov 25, 2019
@jeherve
Changelog: add #14031
6e5459f
jeherve added a commit that referenced this pull request Nov 25, 2019
@jeherve
8.0 Release: running changelog (#13964)
807ab89 
* 8.0 Release: running changelog

* Changelog: add #13921

* Changelog: add #13980

* Changelog: add #13905

* Changelog: add #13971

* Changelog: add #13984

* Changelog: add #14009

* Changelog: add #13620

* Remove things that will ship in 7.9.1

* Changelog: add 7.9.1 release (#14044)

* Changelog: add base for 7.9.1 release

* Update release date and post link

* Changelog: add #14066

* Update changelog for 7.9.1

* Changelog: add #13405

* Changelog: add #13841

* Changelog: add #13924

* Changelog: add #13986

* Changelog: add #14010, #14028, #14053, #14055.

* Changelog: add #14054

* Changelog: add #14031

* Changelog: add #14039

* Changelog: add #14050

* Changelog: add #14070

* Changelog: add #14082

* Changelog: add #14084

* Changelog: add #14111

* Changelog: add #13961

* Changelog: add #14047

* Changelog: add #14091

* Changelog: add #14108

* Changelog: add #14121
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

Assignees

@keoshi keoshi

Labels
[Block] Payment Button aka Recurring Payments [Focus] Accessibility Improving usability for all users (a11y) Touches WP.com Files
Projects
None yet
Milestone
8.0
Development

Successfully merging this pull request may close these issues.
4 participants
@keoshi @matticbot @jetpackbot @jeherve