-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for products on My Plan page and update layout to match mocks #14121
Conversation
Thank you for the great PR description! When this PR is ready for review, please apply the Scheduled Jetpack release: December 3, 2019. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work @delawski! I like the code and everything tested well for me so I think this is good to 🚢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, let's ship this 🚢
I tested this as well and it worked as expected |
Just wanted to note that calypso uses a different Free plan icon. I don't think this should hold this PR but we should address this in the future. |
I was confused about the icons in Jetpack. There is a |
* 8.0 Release: running changelog * Changelog: add #13921 * Changelog: add #13980 * Changelog: add #13905 * Changelog: add #13971 * Changelog: add #13984 * Changelog: add #14009 * Changelog: add #13620 * Remove things that will ship in 7.9.1 * Changelog: add 7.9.1 release (#14044) * Changelog: add base for 7.9.1 release * Update release date and post link * Changelog: add #14066 * Update changelog for 7.9.1 * Changelog: add #13405 * Changelog: add #13841 * Changelog: add #13924 * Changelog: add #13986 * Changelog: add #14010, #14028, #14053, #14055. * Changelog: add #14054 * Changelog: add #14031 * Changelog: add #14039 * Changelog: add #14050 * Changelog: add #14070 * Changelog: add #14082 * Changelog: add #14084 * Changelog: add #14111 * Changelog: add #13961 * Changelog: add #14047 * Changelog: add #14091 * Changelog: add #14108 * Changelog: add #14121
This PR adds a support for products to the My Plan page and adjusts the page header area layout to match the new designs.
Please note that this PR doesn't add the action buttons like "Manage Plan" or "Manage Purchase". They need to be added in a follow-up PR.
Before
After
Fixes n/a
Changes proposed in this Pull Request:
MyPlanCard
from CalypsoMyPlanHeader
so that it supports both plans and productsMyPlanHeader
layout to match the latest mock-upsTesting instructions:
Proposed changelog entry for your changes:
MyPlanCard
cardMyPlanHeader
so that it supports both plans and products