Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Complete Open Graph to $open_graph_conflicting_plugins #14467

Merged
merged 1 commit into from
Jan 24, 2020
Merged

Add Complete Open Graph to $open_graph_conflicting_plugins #14467

merged 1 commit into from
Jan 24, 2020

Conversation

aheckler
Copy link
Member

Came up in 2653195-zen.

Changes proposed in this Pull Request:

  • Jetpack will no longer output Open Graph tags when the Complete Open Graph plugin is present.

Is this a new feature or does it add/remove features to an existing part of Jetpack?

  • Simply adds another plugin to our existing list of conflicting Open Graph plugins.

Testing instructions:

Proposed changelog entry for your changes:

  • Don't output Open Graph tags if the Complete Open Graph plugin is present.

@aheckler aheckler added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Publicize Now Jetpack Social, auto-sharing [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Pri] Low labels Jan 24, 2020
@aheckler aheckler requested a review from a team January 24, 2020 16:04
@aheckler aheckler self-assigned this Jan 24, 2020
@matticbot matticbot added the Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" label Jan 24, 2020
@jetpackbot
Copy link

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: February 11, 2020.
Scheduled code freeze: February 4, 2020

Generated by 🚫 dangerJS against f21a585

@jeherve jeherve added this to the 8.2 milestone Jan 24, 2020
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! [Feature] Sharing Post sharing, sharing buttons and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Jan 24, 2020
@kraftbj kraftbj merged commit f2912cc into master Jan 24, 2020
@kraftbj kraftbj deleted the add-complete-open-graph branch January 24, 2020 16:16
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Jan 24, 2020
jeherve added a commit that referenced this pull request Jan 27, 2020
@jeherve
Changelog: add #14467
3852803
jeherve added a commit that referenced this pull request Jan 28, 2020
@jeherve
Changelog: 8.2 release (#14332)
0589a49 
* [not verified] Remove empty readme section

* Initial changelog for 8.2

* Changelog: add #14220

* Changelog: add #14252

* Changelog: add #14291

* Changelog: add #14309

* Changelog: add #14304

* Changelog: add general connection log.

* Changelog: add #14275

* Changelog: add #14313

* Changelog: add #14213

* Changelog: add #14357

* Add sync testing instructions

* Add 8.1.1 changelog back

See eeaafab and 61757eb

* Changelog: add #14371

* Changelog: add #14386

* Changelog: add #14471

* Changelog: add #14325

* Changelog: add #14194

* Changelog: add #14340

* Changelog: add #14418

* Changelog: add #14417

* Changelog: add #14075

* Changelog: add #14467

* Changelog: add #14307

* Changelog: add #14326
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

Assignees

@aheckler aheckler

Labels
Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" [Feature] Publicize Now Jetpack Social, auto-sharing [Feature] Sharing Post sharing, sharing buttons [Pri] Low [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
8.2
Development

Successfully merging this pull request may close these issues.
5 participants
@aheckler @jetpackbot @jeherve @kraftbj @matticbot