Publicize: Add new publicize icon toggle component #20957

allilevine · 2021-09-03T21:26:19Z

Fixes #21064

Changes proposed in this Pull Request:

Add new ConnectionToggle component that includes service profile picture, username, icon, and toggle.
Add new ConnectionIcon component that includes service profile picture, username, and icon.
Update Facebook and Twitter social icons to fulfill brand guidelines. This will also change the icons in the Social Previews panel and modal.
Update Publicize module and endpoint schemas to include profile_picture
Refresh Publicize connections and set a transient to stagger requests

Jetpack product discussion

p6TEKc-5mX-p2

Does this pull request change what data or activity we track or use?

Nope.

Testing instructions:

Enable the Publicize module on a Jetpack site and checkout this branch.
Apply this patch to your sandbox and sandbox the API: D68827-code
Sandbox the Jetpack site with the JETPACK__SANDBOX_DOMAIN constant.
Create/edit a post.
Open the Jetpack menu in the editor (Jetpack logo in the upper right).
Verify that all of the connection profile pictures are displaying correctly (you may need to delete the transient, e.g. jetpack docker wp transient delete jetpack_publicize_connection_refresh_wait).
Toggle on and off the connections and verify that they disable or enable the connection when publishing.
Check that the social icon is grayed out when a connection is toggled off.
Check that social connections without profile pictures display the social icon by itself.
Check that the Social Previews panel and modal load the correct social icons for Twitter and Facebook.
Repeat the steps above for an Atomic site.
Apply the sync patch from this PR to your sandbox: D66383-code
Repeat the testing steps for a sandboxed Simple site.

matticbot · 2021-09-03T21:26:24Z

Caution: This PR has changes that must be merged to WordPress.com
Hello allilevine! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D66383-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

github-actions · 2021-09-03T21:29:34Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
⚠️ All commits were linted before commit.
✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

Jetpack plugin:

Next scheduled release: November 2, 2021.
Scheduled code freeze: October 25, 2021.

retrofox

HI, @allilevine.
Requiring requests because of #20943. Now, there is a ./extensions/plugins/publicize folder, where I think we should locate this code. 🙏 and 😞

retrofox · 2021-09-09T20:07:01Z

I wonder whether it is worth adding an external link to the media account. I usually want to check the publishment is ok.

projects/plugins/jetpack/modules/publicize/publicize.php

…w object ref for connection

Co-authored-by: Jeremy Herve <jeremy@jeremy.hu>

…k plugin updates

jeherve

This looks good to me. Let's give it a try!

…on-component

github-actions · 2021-11-01T14:28:40Z

Great news! One last step: head over to your WordPress.com diff, D66383-code, and commit it.
Once you've done so, come back to this PR and add a comment with your changeset ID.

Thank you!

allilevine · 2021-11-01T15:24:31Z

Changeset id: r234253-wpcom

…ng-formatting * master: docker: Add script to create "fake" translations for testing i18n (#21407) Add webpack-config package (#21482) Update dependency composer/semver to v3.2.6 (#21608) Update dependency eslint-plugin-import to v2.25.2 (#21607) Update JS unit testing packages (#21605) Admin page: Fix pricing/currency displayed on the upgrade page (#21594) Update dependency @rollup/plugin-node-resolve to v13.0.6 (#21599) Publicize: Add new publicize icon toggle component (#20957) Search: hide search menu for atomic sites (#21565) Allow /wp/v2/sites/1234/batch endpoint to process widget updates (#21549) tooling: Add `.mjs` as a JavaScript extension (#21589) Jetpack: PHPCS src/class-tracking (#21583) Publicize: make the default social media message blank (#21477)

* master: docker: Add script to create "fake" translations for testing i18n (#21407) Add webpack-config package (#21482) Update dependency composer/semver to v3.2.6 (#21608) Update dependency eslint-plugin-import to v2.25.2 (#21607) Update JS unit testing packages (#21605) Admin page: Fix pricing/currency displayed on the upgrade page (#21594) Update dependency @rollup/plugin-node-resolve to v13.0.6 (#21599) Publicize: Add new publicize icon toggle component (#20957) Search: hide search menu for atomic sites (#21565) Allow /wp/v2/sites/1234/batch endpoint to process widget updates (#21549) tooling: Add `.mjs` as a JavaScript extension (#21589) Jetpack: PHPCS src/class-tracking (#21583) Publicize: make the default social media message blank (#21477)

* master: (40 commits) docker: Add script to create "fake" translations for testing i18n (#21407) Add webpack-config package (#21482) Update dependency composer/semver to v3.2.6 (#21608) Update dependency eslint-plugin-import to v2.25.2 (#21607) Update JS unit testing packages (#21605) Admin page: Fix pricing/currency displayed on the upgrade page (#21594) Update dependency @rollup/plugin-node-resolve to v13.0.6 (#21599) Publicize: Add new publicize icon toggle component (#20957) Search: hide search menu for atomic sites (#21565) Allow /wp/v2/sites/1234/batch endpoint to process widget updates (#21549) tooling: Add `.mjs` as a JavaScript extension (#21589) Jetpack: PHPCS src/class-tracking (#21583) Publicize: make the default social media message blank (#21477) Photon: do not serve Wikipedia images from CDN. (#21572) Publicize: update endpoint (#21510) [Plugin] Backup: Update initial backup screen (#21559) RNA Connect Screen: Remove unused files (#21570) RNA Connection: Add ConnectScreenRequiredPlan Component (#21521) Update PHPUnit coverage configs (#21557) cli: Fix skeleton phpunit config (#21555) ...

matticbot added the Touches WP.com Files label Sep 3, 2021

allilevine mentioned this pull request Sep 3, 2021

Publicize: Identify new re-publicize components #20939

Closed

4 tasks

allilevine changed the title ~~Publicize: Add new re-publicize component~~ Publicize: Add new re-publicize icon toggle component Sep 3, 2021

github-actions bot added [Block] Publicize [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Sep 3, 2021

github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Sep 3, 2021

allilevine added [Status] In Progress and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Sep 3, 2021

retrofox requested changes Sep 8, 2021

View reviewed changes

allilevine mentioned this pull request Sep 9, 2021

Publicize: move it to plugins folder #21016

Merged

allilevine force-pushed the add/re-publicize-icon-component branch from 0e0f7b3 to c63cef0 Compare September 13, 2021 17:01

allilevine changed the title ~~Publicize: Add new re-publicize icon toggle component~~ Publicize: Add new publicize icon toggle component Sep 13, 2021

allilevine self-assigned this Sep 13, 2021

github-actions bot added the [Extension] Publicize Block editor plugin label Sep 14, 2021

jeherve removed the [Block] Publicize label Sep 15, 2021

retrofox self-requested a review September 21, 2021 17:48

allilevine force-pushed the add/re-publicize-icon-component branch 3 times, most recently from c0df4cb to 02119ee Compare September 27, 2021 19:01

allilevine force-pushed the add/re-publicize-icon-component branch from 02119ee to aa0cbcb Compare October 1, 2021 17:51

github-actions bot added the [Feature] Publicize Now Jetpack Social, auto-sharing label Oct 1, 2021

allilevine marked this pull request as ready for review October 1, 2021 22:15

allilevine force-pushed the add/re-publicize-icon-component branch from ca535b8 to 7094bcf Compare October 4, 2021 14:09

allilevine commented Oct 4, 2021

View reviewed changes

projects/plugins/jetpack/modules/publicize/publicize.php Outdated Show resolved Hide resolved

allilevine force-pushed the add/re-publicize-icon-component branch from abfc99b to 5734db4 Compare October 4, 2021 21:47

allilevine added [Status] Needs Team Review and removed [Status] In Progress labels Oct 4, 2021

allilevine and others added 13 commits October 28, 2021 16:56

[not verified] Add connectionsUpdated to state to signal change

07229b1

[not verified] Fix rebase, back out connections updated state, get ne…

93e1f9d

…w object ref for connection

[not verified] Fix hook rebase

a12b9c9

[not verified] Add is_wpcom check to get_profile_picture method

5b5ecc4

[not verified] Back out endpoint changes in favor of publicize-wpcom.php

1b06dd0

[not verified] Implement something to refresh the connection data.

6ea5c00

[not verified] Fix disabled toggle style

e0b54c4

[not verified] Add profile_picture to the connection object

60ce066

[not verified] Add PHPCS exclusion to prevent linting error

7d89731

Co-authored-by: Jeremy Herve <jeremy@jeremy.hu>

[not verified] Use gutenberg gray

1fa4cca

[not verified] Swap out TS files for JS files

51385f0

[not verified] Initialise the transient to random value as the Jetpac…

47e3787

…k plugin updates

[not verified] Replace placeholders with social icons

de6786e

allilevine force-pushed the add/re-publicize-icon-component branch from 513b5e7 to de6786e Compare October 28, 2021 20:56

allilevine added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Oct 28, 2021

allilevine requested a review from jeherve October 28, 2021 21:33

jeherve added this to the jetpack/10.4 milestone Oct 29, 2021

jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Oct 29, 2021

jeherve approved these changes Oct 29, 2021

View reviewed changes

Merge remote-tracking branch 'origin/master' into add/re-publicize-ic…

69cf8c2

…on-component

allilevine merged commit d560a45 into master Nov 1, 2021

allilevine deleted the add/re-publicize-icon-component branch November 1, 2021 14:27

github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Nov 1, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Publicize: Add new publicize icon toggle component #20957

Publicize: Add new publicize icon toggle component #20957

allilevine commented Sep 3, 2021 •

edited

Loading

matticbot commented Sep 3, 2021

github-actions bot commented Sep 3, 2021 •

edited

Loading

retrofox left a comment

retrofox commented Sep 9, 2021

jeherve left a comment

github-actions bot commented Nov 1, 2021

allilevine commented Nov 1, 2021

Publicize: Add new publicize icon toggle component #20957

Publicize: Add new publicize icon toggle component #20957

Conversation

allilevine commented Sep 3, 2021 • edited Loading

Changes proposed in this Pull Request:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

matticbot commented Sep 3, 2021

github-actions bot commented Sep 3, 2021 • edited Loading

retrofox left a comment

Choose a reason for hiding this comment

retrofox commented Sep 9, 2021

jeherve left a comment

Choose a reason for hiding this comment

github-actions bot commented Nov 1, 2021

allilevine commented Nov 1, 2021

allilevine commented Sep 3, 2021 •

edited

Loading

github-actions bot commented Sep 3, 2021 •

edited

Loading