Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publicize: update endpoint #21510

Merged
merged 2 commits into from
Oct 28, 2021
Merged

Publicize: update endpoint #21510

merged 2 commits into from
Oct 28, 2021

Conversation

retrofox
Copy link
Contributor

This PR ensures checking the feature when hitting the publicize endpoint.
Fixes #

Changes proposed in this Pull Request:

  • Publicize: check feature chen hitting publicize endpoint

Jetpack product discussion

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Try to republicize a post with different site plans. It should work as expected

@retrofox retrofox added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Publicize Now Jetpack Social, auto-sharing [Status] Needs Team Review labels Oct 22, 2021
@retrofox retrofox requested a review from a team October 22, 2021 13:26
@retrofox retrofox self-assigned this Oct 22, 2021
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello retrofox! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D68893-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@github-actions github-actions bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Oct 22, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Oct 22, 2021 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ⚠️ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

Jetpack plugin:

  • Next scheduled release: November 2, 2021.
  • Scheduled code freeze: October 25, 2021.

DustyReagan
DustyReagan previously approved these changes Oct 27, 2021
View reviewed changes
Copy link
Member

@DustyReagan DustyReagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working for me! 👍

I tested with a local jetpack site with a Complete plan. I applied this PR, D68893-code, and D68892-code. I was able to republicize with my complete plan, then I switched to a free plan in a different tab, came back to my open post tab to try and republicize again, but I received the "unable to share the Post" error message as seen below, as expected.

unable-to-share

@DustyReagan DustyReagan added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] Needs Team Review labels Oct 27, 2021
jeherve
jeherve previously approved these changes Oct 27, 2021
View reviewed changes
@jeherve jeherve added this to the jetpack/10.4 milestone Oct 27, 2021
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Oct 27, 2021
@retrofox retrofox dismissed stale reviews from jeherve and DustyReagan via 1428d27 October 28, 2021 18:17
@github-actions github-actions bot added the [Extension] Publicize Block editor plugin label Oct 28, 2021
@retrofox retrofox force-pushed the update/publicize-update-endpoint branch from 1428d27 to a0c686b Compare October 28, 2021 18:27
@retrofox retrofox merged commit 4a1dab9 into master Oct 28, 2021
@retrofox retrofox deleted the update/publicize-update-endpoint branch October 28, 2021 19:14
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Oct 28, 2021
@github-actions
Copy link
Contributor

Great news! One last step: head over to your WordPress.com diff, D68893-code, and commit it.
Once you've done so, come back to this PR and add a comment with your changeset ID.

Thank you!

@retrofox
Copy link
Contributor Author

Great news! One last step: head over to your WordPress.com diff, D68893-code, and commit it. Once you've done so, come back to this PR and add a comment with your changeset ID.

r234153-wpcom

davidlonjon added a commit that referenced this pull request Oct 29, 2021
@davidlonjon
Merge branch 'master' into fix/boost-and-general-linting-formatting
b475647 
* master:
  Photon: do not serve Wikipedia images from CDN. (#21572)
  Publicize: update endpoint (#21510)
  [Plugin] Backup: Update initial backup screen (#21559)
  RNA Connect Screen: Remove unused files (#21570)
  RNA Connection: Add ConnectScreenRequiredPlan Component (#21521)
davidlonjon added a commit that referenced this pull request Oct 29, 2021
@davidlonjon
Merge branch 'master' into add/boost-e2e-ci-integration
d1c5452 
* master:
  Photon: do not serve Wikipedia images from CDN. (#21572)
  Publicize: update endpoint (#21510)
  [Plugin] Backup: Update initial backup screen (#21559)
  RNA Connect Screen: Remove unused files (#21570)
  RNA Connection: Add ConnectScreenRequiredPlan Component (#21521)
davidlonjon added a commit that referenced this pull request Nov 2, 2021
@davidlonjon
Merge branch 'master' into fix/explicitly-hide-admin-bar
8c032d9 
* master: (40 commits)
  docker: Add script to create "fake" translations for testing i18n (#21407)
  Add webpack-config package (#21482)
  Update dependency composer/semver to v3.2.6 (#21608)
  Update dependency eslint-plugin-import to v2.25.2 (#21607)
  Update JS unit testing packages (#21605)
  Admin page: Fix pricing/currency displayed on the upgrade page (#21594)
  Update dependency @rollup/plugin-node-resolve to v13.0.6 (#21599)
  Publicize: Add new publicize icon toggle component (#20957)
  Search: hide search menu for atomic sites (#21565)
  Allow /wp/v2/sites/1234/batch endpoint to process widget updates (#21549)
  tooling: Add `.mjs` as a JavaScript extension (#21589)
  Jetpack: PHPCS src/class-tracking (#21583)
  Publicize: make the default social media message blank (#21477)
  Photon: do not serve Wikipedia images from CDN. (#21572)
  Publicize: update endpoint (#21510)
  [Plugin] Backup: Update initial backup screen (#21559)
  RNA Connect Screen: Remove unused files (#21570)
  RNA Connection: Add ConnectScreenRequiredPlan Component (#21521)
  Update PHPUnit coverage configs (#21557)
  cli: Fix skeleton phpunit config (#21555)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kraftbj kraftbj kraftbj approved these changes

@jeherve jeherve jeherve left review comments

@DustyReagan DustyReagan DustyReagan left review comments

Assignees

@retrofox retrofox

Labels
[Extension] Publicize Block editor plugin [Feature] Publicize Now Jetpack Social, auto-sharing [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ Touches WP.com Files [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
jetpack/10.4
Development

Successfully merging this pull request may close these issues.
5 participants
@retrofox @matticbot @kraftbj @DustyReagan @jeherve