[Plugin] Backup: Update initial backup screen #21559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whenever the initial backup is about to start, show a backup running with 0% progress instead of a welcome message.
nunyvega
added
the
[Plugin] Backup
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Backup plugin:
|
github-actions
bot
added
the
[Status] Needs Author Reply
nunyvega
changed the title
nunyvega
added
[Status] Needs Team Review
and removed
[Status] Needs Author Reply
jeherve
added
[Status] Ready to Merge
jeherve
approved these changes
Oct 28, 2021
github-actions
bot
removed
the
[Status] Ready to Merge
davidlonjon
added a commit
that referenced
this pull request
Nov 2, 2021
* master: (40 commits) docker: Add script to create "fake" translations for testing i18n (#21407) Add webpack-config package (#21482) Update dependency composer/semver to v3.2.6 (#21608) Update dependency eslint-plugin-import to v2.25.2 (#21607) Update JS unit testing packages (#21605) Admin page: Fix pricing/currency displayed on the upgrade page (#21594) Update dependency @rollup/plugin-node-resolve to v13.0.6 (#21599) Publicize: Add new publicize icon toggle component (#20957) Search: hide search menu for atomic sites (#21565) Allow /wp/v2/sites/1234/batch endpoint to process widget updates (#21549) tooling: Add `.mjs` as a JavaScript extension (#21589) Jetpack: PHPCS src/class-tracking (#21583) Publicize: make the default social media message blank (#21477) Photon: do not serve Wikipedia images from CDN. (#21572) Publicize: update endpoint (#21510) [Plugin] Backup: Update initial backup screen (#21559) RNA Connect Screen: Remove unused files (#21570) RNA Connection: Add ConnectScreenRequiredPlan Component (#21521) Update PHPUnit coverage configs (#21557) cli: Fix skeleton phpunit config (#21555) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever the initial backup is about to start after the initial purchase and plugin connection, show the backup running screen with 0% progress instead of a welcome message.
Does this pull request change what data or activity we track or use?
No
Testing instructions:
1- On a new site, add Jetpack Backup
2- Purchase a plan for it. (no need to use the Jetpack plugin)
2- Setup the connection from the Backup plugin
3- Confirm that the Backup in progress page is shown instead of the
Welcome to Jetpack Backup!page.