Publicize: make the default social media message blank #21477

alshakero · 2021-10-20T19:16:17Z

Currently, the Publicize message field has the following placeholder

Write a message for your audience here. If you leave this blank, we’ll use an excerpt of the post content as the message.“.

While in reality we use the post title.

I realize this solution is hard to make perfect in every language, but I think it's good enough. If you think it's not, changing the placeholder or leaving the default message empty might be more fool-proof solutions.

Fixes Automattic/wp-calypso#57144 and #21530

Changes proposed in this Pull Request:

This PR proposes making it blank.

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

Using the Jetpack link below, create a new long-ish post.
Click publish, the default message contents should be blank.
You should be able to modify the message.
Twitter threads should still use the post title.

matticbot · 2021-10-20T19:16:23Z

Caution: This PR has changes that must be merged to WordPress.com
Hello alshakero! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D68773-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

github-actions · 2021-10-20T19:17:34Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
⚠️ All commits were linted before commit.
✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

Jetpack plugin:

Next scheduled release: November 2, 2021.
Scheduled code freeze: October 25, 2021.

jeherve · 2021-10-21T07:36:25Z

This is a bit tricky, as the end result depends on the platform.

On Facebook for example (one of our most popular Publicize options), if you leave that field empty we will use the excerpt.

I'll cc @pablinos, who's been working on quite a few improvements to this interface in the past few weeks.

pablinos · 2021-10-23T08:54:04Z

Yes, we've been considering this a little. I've been starting to think that we should leave the textbox blank because, as @jeherve mentions, the default message changes based on the network being shared to. It would also simplify things as we have code in place to work out if the message has been edited or not.

I'd prefer that we shorten the message to something like, "Write a message for your audience here" and rely on some other help to let people know the message that we'll use. We can also rely on on the social previews feature, although that might need updating to make sure that it's a true preview.

alshakero · 2021-10-26T12:54:24Z

This is ready for review!

retrofox · 2021-10-26T14:24:33Z

This is ready for review!

it seems the testing instructions are not updated according to the latest changes. Is it right?

retrofox

before	after

Confirmed that when the post doesn't have a publicized message, the text is taken from the post title for Twitter accounts
It's possible to edit the publicized message via the text control
✅

alshakero · 2021-10-27T10:44:09Z

Hi! This just needs another approval after rebase.

retrofox · 2021-10-27T11:11:03Z

Hi! This just needs another approval after rebase.

Accepted. :-)
you might like to merge with master instead of rebasing in order to do not lose the ✅ , just FYI

pablinos · 2021-10-27T14:08:16Z

projects/plugins/jetpack/extensions/plugins/publicize/store/selectors.js

+	if ( isTweetStorm() ) {
+		if ( postTitle ) {
+			return postTitle.substr( 0, getShareMessageMaxLength() ) + DEFAULT_TWEETSTORM_MESSAGE;
+		}


Do we still need this if we're relying on the back end to create the default message? Without the hasEditedShareMessage logic, this text will look like it has been added by the user, and will be used when sharing the message. That might not be an issue as long as it's in sync with whatever would be produced server side.

That's interesting! I didn't know the server side generated the message. I'm not too familiar with this, do you think I should remove this check? Looking at this code, it does seem like this JS code is redundant.

Yes, that's what I'm thinking, although I notice the default there doesn't include the post title. We probably need to run some tests, but it would make sense to have all this logic in one place.

If we need to, we could add the title of the post to the default custom message.

We could merge this and deal with the tweetstorm logic as a separate change.

github-actions · 2021-10-29T09:54:22Z

Great news! One last step: head over to your WordPress.com diff, D68773-code, and commit it.
Once you've done so, come back to this PR and add a comment with your changeset ID.

Thank you!

alshakero · 2021-10-29T23:32:11Z

r234186-wpcom

…ng-formatting * master: docker: Add script to create "fake" translations for testing i18n (#21407) Add webpack-config package (#21482) Update dependency composer/semver to v3.2.6 (#21608) Update dependency eslint-plugin-import to v2.25.2 (#21607) Update JS unit testing packages (#21605) Admin page: Fix pricing/currency displayed on the upgrade page (#21594) Update dependency @rollup/plugin-node-resolve to v13.0.6 (#21599) Publicize: Add new publicize icon toggle component (#20957) Search: hide search menu for atomic sites (#21565) Allow /wp/v2/sites/1234/batch endpoint to process widget updates (#21549) tooling: Add `.mjs` as a JavaScript extension (#21589) Jetpack: PHPCS src/class-tracking (#21583) Publicize: make the default social media message blank (#21477)

* master: docker: Add script to create "fake" translations for testing i18n (#21407) Add webpack-config package (#21482) Update dependency composer/semver to v3.2.6 (#21608) Update dependency eslint-plugin-import to v2.25.2 (#21607) Update JS unit testing packages (#21605) Admin page: Fix pricing/currency displayed on the upgrade page (#21594) Update dependency @rollup/plugin-node-resolve to v13.0.6 (#21599) Publicize: Add new publicize icon toggle component (#20957) Search: hide search menu for atomic sites (#21565) Allow /wp/v2/sites/1234/batch endpoint to process widget updates (#21549) tooling: Add `.mjs` as a JavaScript extension (#21589) Jetpack: PHPCS src/class-tracking (#21583) Publicize: make the default social media message blank (#21477)

* master: (40 commits) docker: Add script to create "fake" translations for testing i18n (#21407) Add webpack-config package (#21482) Update dependency composer/semver to v3.2.6 (#21608) Update dependency eslint-plugin-import to v2.25.2 (#21607) Update JS unit testing packages (#21605) Admin page: Fix pricing/currency displayed on the upgrade page (#21594) Update dependency @rollup/plugin-node-resolve to v13.0.6 (#21599) Publicize: Add new publicize icon toggle component (#20957) Search: hide search menu for atomic sites (#21565) Allow /wp/v2/sites/1234/batch endpoint to process widget updates (#21549) tooling: Add `.mjs` as a JavaScript extension (#21589) Jetpack: PHPCS src/class-tracking (#21583) Publicize: make the default social media message blank (#21477) Photon: do not serve Wikipedia images from CDN. (#21572) Publicize: update endpoint (#21510) [Plugin] Backup: Update initial backup screen (#21559) RNA Connect Screen: Remove unused files (#21570) RNA Connection: Add ConnectScreenRequiredPlan Component (#21521) Update PHPUnit coverage configs (#21557) cli: Fix skeleton phpunit config (#21555) ...

matticbot added the Touches WP.com Files label Oct 20, 2021

alshakero changed the title ~~Use truncated post content as default Publicize message~~ Publicize: use truncated post content as default Publicize message Oct 20, 2021

github-actions bot added [Extension] Publicize Block editor plugin [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Oct 20, 2021

github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Oct 20, 2021

alshakero mentioned this pull request Oct 20, 2021

[Bug]: Publicize isn't posting the custom exceprt to LinkedIn and instead posting truncated post content Automattic/wp-calypso#57144

Closed

alshakero force-pushed the fix/default-post-message branch from 57ea2f6 to 537c7ec Compare October 20, 2021 19:20

alshakero removed the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Oct 20, 2021

github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Oct 20, 2021

alshakero added the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Oct 20, 2021

jeherve assigned alshakero Oct 21, 2021

jeherve removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Oct 25, 2021

allilevine mentioned this pull request Oct 25, 2021

Enhancement: Leave the Publicize message textbox blank #21530

Closed

alshakero changed the title ~~Publicize: use truncated post content as default Publicize message~~ Publicize: make the default Publicize message blank Oct 26, 2021

alshakero force-pushed the fix/default-post-message branch from d7c9c7f to 5d9d1ef Compare October 26, 2021 12:14

alshakero changed the title ~~Publicize: make the default Publicize message blank~~ Publicize: make the default social media message blank Oct 26, 2021

jeherve requested a review from retrofox October 26, 2021 16:10

jeherve added this to the jetpack/10.4 milestone Oct 26, 2021

jeherve requested a review from pablinos October 26, 2021 16:10

retrofox previously approved these changes Oct 26, 2021

View reviewed changes

retrofox added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Oct 26, 2021

alshakero added 6 commits October 27, 2021 11:09

[not verified] Use truncated post content as default message

0764da9

[not verified] Add changelog entry

854d2a9

[not verified] Make the default publicize message blank

186ea4a

[not verified] Update placeholder accordingly

f928d2d

[not verified] Remove leftover import

ce90124

[not verified] Change changelog entry to match the new change

6bca5cd

alshakero dismissed retrofox’s stale review via 6bca5cd October 27, 2021 09:09

alshakero force-pushed the fix/default-post-message branch from 3d6ae05 to 6bca5cd Compare October 27, 2021 09:09

alshakero added the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Oct 27, 2021

retrofox approved these changes Oct 27, 2021

View reviewed changes

jeherve removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Oct 27, 2021

pablinos reviewed Oct 27, 2021

View reviewed changes

alshakero merged commit 351cd5b into master Oct 29, 2021

alshakero deleted the fix/default-post-message branch October 29, 2021 09:53

github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Oct 29, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Publicize: make the default social media message blank #21477

Publicize: make the default social media message blank #21477

alshakero commented Oct 20, 2021 •

edited

Loading

matticbot commented Oct 20, 2021

github-actions bot commented Oct 20, 2021 •

edited

Loading

jeherve commented Oct 21, 2021

pablinos commented Oct 23, 2021

alshakero commented Oct 26, 2021

retrofox commented Oct 26, 2021

retrofox left a comment

alshakero commented Oct 27, 2021

retrofox commented Oct 27, 2021

pablinos Oct 27, 2021

alshakero Oct 28, 2021

pablinos Oct 28, 2021

github-actions bot commented Oct 29, 2021

alshakero commented Oct 29, 2021

Publicize: make the default social media message blank #21477

Publicize: make the default social media message blank #21477

Conversation

alshakero commented Oct 20, 2021 • edited Loading

Changes proposed in this Pull Request:

Does this pull request change what data or activity we track or use?

Testing instructions:

matticbot commented Oct 20, 2021

github-actions bot commented Oct 20, 2021 • edited Loading

jeherve commented Oct 21, 2021

pablinos commented Oct 23, 2021

alshakero commented Oct 26, 2021

retrofox commented Oct 26, 2021

retrofox left a comment

Choose a reason for hiding this comment

alshakero commented Oct 27, 2021

retrofox commented Oct 27, 2021

pablinos Oct 27, 2021

Choose a reason for hiding this comment

alshakero Oct 28, 2021

Choose a reason for hiding this comment

pablinos Oct 28, 2021

Choose a reason for hiding this comment

github-actions bot commented Oct 29, 2021

alshakero commented Oct 29, 2021

alshakero commented Oct 20, 2021 •

edited

Loading

github-actions bot commented Oct 20, 2021 •

edited

Loading