ThreatsDataViews: History fields preset #40580

dkmyta · 2024-12-11T23:22:39Z

Description

Adds custom fields when viewing Active threats and History (only in table view).

Proposed changes

Display relevant fields dependant on dataFields and statusFilters
- When current filter is included in statusFilters show auto-fix
- When fixed, ignored, or historic (fixed and ignored) show first-detected, fixed-on, and hide auto-fix
- Always show Status so you can distinguish between active/historic threats when viewing all only for the paid view
  - This could be further conditional to be hidden when only viewing current threats?
  - We may also want to include this field in list view for better clarity
Show a more descriptive Auto-fix item in actions drop down only in list view, removing it from table view in favour of the Auto-fix field

Potential issues:

If a user has no active threats and views all (either by removing all or adding all status filters), the auto-fix column will display even though they are technically viewing only historical threats.
If a user is in a filter state where fields are not included (eg. no filters applied), they cannot apply such fields (eg. first-detected) manually from the settings.

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

https://github.com/Automattic/jetpack-scan-team/issues/1592

Does this pull request change what data or activity we track or use?

No

Testing instructions:

Review ThreatsDataViews storybooks
Checkout this Protect branch on Jurassic Tube/Ninja
Ensure that the toggle between Active threats and History applies the correct fields preset
Ensure modifying filters also applies the correct field presets

Screenshots

Active threats:

History:

Action drop-down auto-fix in list view (now removed in table view):

#40057) Co-authored-by: Nate Weller <hello@nateweller.com>

* Update Scan and History section header structure/content * changelog * Update projects/plugins/protect/src/js/routes/scan/scan-admin-section-hero.tsx Co-authored-by: Nate Weller <nate.weller@automattic.com> --------- Co-authored-by: Nate Weller <nate.weller@automattic.com>

Protect: add HMR support Revert "Protect: add HMR support" This reverts commit 06497a0.

* Init project branch * Protect: Add Go to Cloud and Scan now button to Protect primary header (#40057) Co-authored-by: Nate Weller <hello@nateweller.com> * Protect: Update Scan and History headers (#40058) * Update Scan and History section header structure/content * changelog * Update projects/plugins/protect/src/js/routes/scan/scan-admin-section-hero.tsx Co-authored-by: Nate Weller <nate.weller@automattic.com> --------- Co-authored-by: Nate Weller <nate.weller@automattic.com> * Protect: de-emphasize cloud link by using link variant (#40211) * Protect: add ShieldIcon component * Protect: Add ShieldIcon Component (#40402) * Protect: Integrate ThreatsDataViews Component (#40076) * Components: Add ScanReport (#40419) * Fix type errors * Protect: add home page --------- Co-authored-by: Nate Weller <hello@nateweller.com> Co-authored-by: Nate Weller <nate.weller@automattic.com> Co-authored-by: Dean Kmyta <dkmyta@automattic.com>

github-actions · 2024-12-11T23:23:36Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the add/components/threats-data-views-history-fields-preset branch.
- For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.

To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack add/components/threats-data-views-history-fields-preset

bin/jetpack-downloader test jetpack-mu-wpcom-plugin add/components/threats-data-views-history-fields-preset

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions · 2024-12-11T23:23:37Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
🔴 Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
🔴 Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

🔴 Action required: Please add missing changelog entries for the following projects: projects/js-packages/components, projects/plugins/protect

Use the Jetpack CLI tool to generate changelog entries by running the following command: jetpack changelog add.
Guidelines: /docs/writing-a-good-changelog-entry.md

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Choose a review path based on your changes:
- A. Team Review: add the "[Status] Needs Team Review" label
  - For most changes, including minor cross-team impacts.
  - Example: Updating a team-specific component or a small change to a shared library.
- B. Crew Review: add the "[Status] Needs Review" label
  - For significant changes to core functionality.
  - Example: Major updates to a shared library or complex features.
- C. Both: Start with Team, then request Crew
  - For complex changes or when you need extra confidence.
  - Example: Refactor affecting multiple systems.
Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

Protect plugin:

Next scheduled release: none scheduled.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

#40057) Co-authored-by: Nate Weller <hello@nateweller.com>

* Update Scan and History section header structure/content * changelog * Update projects/plugins/protect/src/js/routes/scan/scan-admin-section-hero.tsx Co-authored-by: Nate Weller <nate.weller@automattic.com> --------- Co-authored-by: Nate Weller <nate.weller@automattic.com>

Protect: add HMR support Revert "Protect: add HMR support" This reverts commit 06497a0.

* Init project branch * Protect: Add Go to Cloud and Scan now button to Protect primary header (#40057) Co-authored-by: Nate Weller <hello@nateweller.com> * Protect: Update Scan and History headers (#40058) * Update Scan and History section header structure/content * changelog * Update projects/plugins/protect/src/js/routes/scan/scan-admin-section-hero.tsx Co-authored-by: Nate Weller <nate.weller@automattic.com> --------- Co-authored-by: Nate Weller <nate.weller@automattic.com> * Protect: de-emphasize cloud link by using link variant (#40211) * Protect: add ShieldIcon component * Protect: Add ShieldIcon Component (#40402) * Protect: Integrate ThreatsDataViews Component (#40076) * Components: Add ScanReport (#40419) * Fix type errors * Protect: add home page --------- Co-authored-by: Nate Weller <hello@nateweller.com> Co-authored-by: Nate Weller <nate.weller@automattic.com> Co-authored-by: Dean Kmyta <dkmyta@automattic.com>

nateweller · 2024-12-18T23:22:49Z

projects/js-packages/components/components/threats-data-views/index.tsx

+			...( dataFields.includes( 'firstDetected' ) &&
+			( statusFilters.includes( 'fixed' ) || statusFilters.includes( 'ignored' ) )


I am curious if there's a possible alternative configuration that would allow us to still include the "first detected" field regardless of the current filters, but hide/show the particular field in the table view based on the current filters, instead of omitting the definition of the fields entirely. I'll follow up on this!

I had a similar hope, and did come across isVisible which I thought might be an option but seemed to not function as I expected it to.

Could we use isVisible? Edit: ah, that might be a per-item method.

I am working on a potential approach using the onChangeView callback, will share shortly!

Just a heads up that I did start with the onChangeView approach and it seemed to have its own limitations - IIRC there were challenges related to not being able to check the current view state against the changed view state because it was always outdated. Regardless, interested to see what you think might work reintroducing that take.

nateweller and others added 14 commits December 11, 2024 11:17

Init project branch

3c24030

Protect: Add Go to Cloud and Scan now button to Protect primary header (

be99f50

#40057) Co-authored-by: Nate Weller <hello@nateweller.com>

Protect: de-emphasize cloud link by using link variant (#40211)

90d6898

Protect: add ShieldIcon component

dd21913

Protect: Add ShieldIcon Component (#40402)

19c083e

Protect: Integrate ThreatsDataViews Component (#40076)

08cdcb2

Components: Add ScanReport (#40419)

0a9047e

Fix type errors

aa9b8a3

Protect: add HMR support Revert "Protect: add HMR support" This reverts commit 06497a0.

Protect: Refactor AdminSectionHero (#40516)

08d8de3

Protect: Update Scan History extension types (#40548)

b33c95a

Protect: Integrate ScanReport (#40420)

322819d

Add custom field set when viewing historic threats

b397656

github-actions bot added [JS Package] Components [JS Package] Scan [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Status] In Progress RNA labels Dec 11, 2024

dkmyta changed the base branch from trunk to add/protect/core December 11, 2024 23:33

nateweller and others added 8 commits December 14, 2024 20:28

Init project branch

8e1c8ae

Protect: Add Go to Cloud and Scan now button to Protect primary header (

8a3dc9b

#40057) Co-authored-by: Nate Weller <hello@nateweller.com>

Protect: de-emphasize cloud link by using link variant (#40211)

ef21cc4

Protect: add ShieldIcon component

2f37bfc

Protect: Add ShieldIcon Component (#40402)

ffdc98c

Protect: Integrate ThreatsDataViews Component (#40076)

71384f1

Components: Add ScanReport (#40419)

4fccd4c

nateweller and others added 5 commits December 14, 2024 20:28

Fix type errors

f172be7

Protect: add HMR support Revert "Protect: add HMR support" This reverts commit 06497a0.

Protect: Refactor AdminSectionHero (#40516)

d25db57

Protect: Update Scan History extension types (#40548)

e86cfe1

Protect: Integrate ScanReport (#40420)

48fba20

nateweller force-pushed the add/protect/core branch from 322819d to 48fba20 Compare December 15, 2024 03:29

nateweller and others added 6 commits December 14, 2024 20:36

Fix duplicate imports

ef6e5d0

ScanReport: Fix defaultLayout (#40603)

62838d3

Update onboarding popover placement (#40550)

a877b8c

Adjust approach

7a47485

Rebase

87f5b71

Fix JSDocs

130eaf4

dkmyta marked this pull request as ready for review December 17, 2024 21:04

nateweller force-pushed the add/protect/core branch 2 times, most recently from 2a3f2fe to aac1879 Compare December 18, 2024 20:21

Rebase

a1018bf

nateweller requested a review from a team December 18, 2024 23:06

nateweller assigned dkmyta Dec 18, 2024

nateweller added [Status] Needs Team Review and removed [Status] In Progress labels Dec 18, 2024

github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Dec 18, 2024

nateweller reviewed Dec 18, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ThreatsDataViews: History fields preset #40580

ThreatsDataViews: History fields preset #40580

dkmyta commented Dec 11, 2024 •

edited

Loading

github-actions bot commented Dec 11, 2024 •

edited

Loading

github-actions bot commented Dec 11, 2024 •

edited

Loading

nateweller Dec 18, 2024

dkmyta Dec 18, 2024 •

edited

Loading

nateweller Dec 18, 2024 •

edited

Loading

nateweller Dec 19, 2024

dkmyta Dec 19, 2024

		...( dataFields.includes( 'firstDetected' ) &&
		( statusFilters.includes( 'fixed' ) \|\| statusFilters.includes( 'ignored' ) )

ThreatsDataViews: History fields preset #40580

Are you sure you want to change the base?

ThreatsDataViews: History fields preset #40580

Conversation

dkmyta commented Dec 11, 2024 • edited Loading

Description

Proposed changes

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Screenshots

github-actions bot commented Dec 11, 2024 • edited Loading

github-actions bot commented Dec 11, 2024 • edited Loading

nateweller Dec 18, 2024

Choose a reason for hiding this comment

dkmyta Dec 18, 2024 • edited Loading

Choose a reason for hiding this comment

nateweller Dec 18, 2024 • edited Loading

Choose a reason for hiding this comment

nateweller Dec 19, 2024

Choose a reason for hiding this comment

dkmyta Dec 19, 2024

Choose a reason for hiding this comment

dkmyta commented Dec 11, 2024 •

edited

Loading

github-actions bot commented Dec 11, 2024 •

edited

Loading

github-actions bot commented Dec 11, 2024 •

edited

Loading

dkmyta Dec 18, 2024 •

edited

Loading

nateweller Dec 18, 2024 •

edited

Loading