Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync: Sync the network update event everytime #8469

Merged
merged 1 commit into from
Jan 9, 2018

Conversation

enejb
Copy link
Member

@enejb enejb commented Jan 5, 2018

Use the pre_update_site option filter to hook into the event. This way we would always get the evernt not just when the is really neccessery.

Fixes issue reported that said that the event wasn't showing up as expected.

Changes proposed in this Pull Request:

  • Listen for when the filter gets fired. Since that filter always gets fired before the update to the option.

Testing instructions:

  • Do the tests pass?
  • Go to the network admin click update.

Proposed changelog entry for your changes:

Use the pre_update_site option filter to hook into the event. This way we would always get the evernt not just when the is really neccessery.
@enejb enejb requested a review from a team as a code owner January 5, 2018 18:41
@enejb enejb added the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Jan 5, 2018
@lezama
Copy link
Contributor

lezama commented Jan 5, 2018

LGTM :)

@enejb enejb added [Package] Sync [Type] Bug When a feature is broken and / or not performing as intended [Feature] Activity Log labels Jan 5, 2018
@lezama
Copy link
Contributor

lezama commented Jan 9, 2018

🚢

@enejb enejb merged commit d247331 into master Jan 9, 2018
@enejb enejb deleted the fix/sync-network-update-activity branch January 9, 2018 18:00
@oskosk oskosk added this to the 5.8 milestone Jan 12, 2018
@jeherve jeherve added [Status] Has Changelog and removed [Status] Needs Changelog [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Jan 29, 2018
jeherve added a commit that referenced this pull request Jan 29, 2018
zinigor pushed a commit that referenced this pull request Jan 30, 2018
* Changelog 5.8: create base for changelog.

* Update 5.8 release post link

* fix 5.8 release date

* Updates to plugin description

* Changelog: add #8499

* Changelog: add #8506

* Changelog: add #8509

* Changelog: add #8516

* Changelog: add #8517

* Changelog: add #8523

* Changelog: add #8547

* Changelog: add #8496

* Changelog: add #8584

* Changelog: add #8595

* Changelog: add #8445

* Changelog: add #8431

* Changelog: add #8284

* Changelog: add #8270

* Changelog: add #8124

* Changelog: add #8581

* Changelog: add #8463

* Changelog: add #8568 (#8646)

* Updates to testing list and changelog

* Changelog: add #8443

* Changelog: add #8459

* Changelog: add #8469

* Changelog: add #8464

* Changelog: add #8478 and #8479

* Changelog: add #8483

* Changelog: add #8488

* Changelog: add #8513

* Changelog: add #8555

* Changelog: add #8565

* Changelog: add #8601

* Changelog: add #8612

* Changelog: add first pass at Search items.

* Changelog: add more info to help test Search.

* Changelog: add #8144

* Changelog: add #8313

* Changelog: add #8419

* Changelog: add #8465

* Changelog: add #8515

* Changelog: add #8587

* Changelog: add #8591

* Changelog: add #8659

* Changelog: add #8661

* Changelog: add #8671

* Changelog: add 5.7.1 to archived changelog too.

* Reverted changes to readme, removed entry about backups.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Activity Log [Package] Sync [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants