Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XHTML Compliance For Stats Script #8419

Merged
merged 1 commit into from
Jan 30, 2018
Merged

Conversation

Volnus
Copy link
Contributor

@Volnus Volnus commented Dec 26, 2017

XHTML compliance requires that attributes not be minimized and this fix was in an earlier version but appears to have been removed or edited for some reason this pull request simply adds back the necessary tags.

Fixes #8415

XHTML compliance requires that attributes not be minimized and this fix was in an earlier version but appears to have been removed or edited for some reason.
@Volnus Volnus requested a review from a team as a code owner December 26, 2017 00:21
@oskosk oskosk added the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Dec 27, 2017
@jeherve jeherve changed the title XHTML Compliance For JetPack Stats Script XHTML Compliance For Stats Script Dec 29, 2017
@jeherve jeherve added [Feature] Stats Data Feature that enables users to track their site's traffic and gain insights on popular content. [Pri] Low [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it labels Dec 29, 2017
Copy link

@eligrey eligrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eligrey
Copy link

eligrey commented Jan 12, 2018

Could an Automattic employee please review this?

@jeherve
Copy link
Member

jeherve commented Jan 12, 2018

@eligrey Yes, that will happen. The issue is marked as "Needs Review", so one of us will review this PR soon.

Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Brings back the changes we had made in #3489, and that got accidentally removed in #3563

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Jan 12, 2018
@zinigor zinigor added this to the 5.8 milestone Jan 30, 2018
@zinigor zinigor merged commit 089230f into Automattic:master Jan 30, 2018
@zinigor zinigor removed the [Status] Ready to Merge Go ahead, you can push that green button! label Jan 30, 2018
jeherve added a commit that referenced this pull request Jan 30, 2018
zinigor pushed a commit that referenced this pull request Jan 30, 2018
* Changelog 5.8: create base for changelog.

* Update 5.8 release post link

* fix 5.8 release date

* Updates to plugin description

* Changelog: add #8499

* Changelog: add #8506

* Changelog: add #8509

* Changelog: add #8516

* Changelog: add #8517

* Changelog: add #8523

* Changelog: add #8547

* Changelog: add #8496

* Changelog: add #8584

* Changelog: add #8595

* Changelog: add #8445

* Changelog: add #8431

* Changelog: add #8284

* Changelog: add #8270

* Changelog: add #8124

* Changelog: add #8581

* Changelog: add #8463

* Changelog: add #8568 (#8646)

* Updates to testing list and changelog

* Changelog: add #8443

* Changelog: add #8459

* Changelog: add #8469

* Changelog: add #8464

* Changelog: add #8478 and #8479

* Changelog: add #8483

* Changelog: add #8488

* Changelog: add #8513

* Changelog: add #8555

* Changelog: add #8565

* Changelog: add #8601

* Changelog: add #8612

* Changelog: add first pass at Search items.

* Changelog: add more info to help test Search.

* Changelog: add #8144

* Changelog: add #8313

* Changelog: add #8419

* Changelog: add #8465

* Changelog: add #8515

* Changelog: add #8587

* Changelog: add #8591

* Changelog: add #8659

* Changelog: add #8661

* Changelog: add #8671

* Changelog: add 5.7.1 to archived changelog too.

* Reverted changes to readme, removed entry about backups.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Stats Data Feature that enables users to track their site's traffic and gain insights on popular content. [Pri] Low [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

#3489 XHTML compliance regression
6 participants