Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update links to point to correct "manage plugin" path #8671

Merged
merged 1 commit into from
Jan 30, 2018
Merged

Update links to point to correct "manage plugin" path #8671

merged 1 commit into from
Jan 30, 2018

Conversation

dereksmart
Copy link
Member

@dereksmart dereksmart commented Jan 30, 2018 •
edited
Loading

Fixes #8669

This updates the relevant links to manage your plugins to the correct path.

To Test:

  • Trigger some plugin update notices by updating the plugin's version manually
  • See the notices in the dashboard card as shown in the linked issue
  • Clicking them should take you to the correct path described in the linked issue

@dereksmart dereksmart added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. Admin Page React-powered dashboard under the Jetpack menu labels Jan 30, 2018
@dereksmart dereksmart requested a review from a team as a code owner January 30, 2018 17:59
@dereksmart dereksmart added this to the 5.8 milestone Jan 30, 2018
zinigor
zinigor approved these changes Jan 30, 2018
View reviewed changes
Copy link
Member

@zinigor zinigor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zinigor zinigor added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Jan 30, 2018
jeherve
jeherve approved these changes Jan 30, 2018
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Merging.

@jeherve jeherve merged commit 2d43e24 into master Jan 30, 2018
@jeherve jeherve deleted the update/links-to-manage-plugins branch January 30, 2018 21:09
@jeherve jeherve removed the [Status] Ready to Merge Go ahead, you can push that green button! label Jan 30, 2018
jeherve added a commit that referenced this pull request Jan 30, 2018
@jeherve
Changelog: add #8671
10ed5c6
zinigor pushed a commit that referenced this pull request Jan 30, 2018
@oskosk @zinigor
Changelog 5.8: running changelog (#8442)
1ee2c03 
* Changelog 5.8: create base for changelog.

* Update 5.8 release post link

* fix 5.8 release date

* Updates to plugin description

* Changelog: add #8499

* Changelog: add #8506

* Changelog: add #8509

* Changelog: add #8516

* Changelog: add #8517

* Changelog: add #8523

* Changelog: add #8547

* Changelog: add #8496

* Changelog: add #8584

* Changelog: add #8595

* Changelog: add #8445

* Changelog: add #8431

* Changelog: add #8284

* Changelog: add #8270

* Changelog: add #8124

* Changelog: add #8581

* Changelog: add #8463

* Changelog: add #8568 (#8646)

* Updates to testing list and changelog

* Changelog: add #8443

* Changelog: add #8459

* Changelog: add #8469

* Changelog: add #8464

* Changelog: add #8478 and #8479

* Changelog: add #8483

* Changelog: add #8488

* Changelog: add #8513

* Changelog: add #8555

* Changelog: add #8565

* Changelog: add #8601

* Changelog: add #8612

* Changelog: add first pass at Search items.

* Changelog: add more info to help test Search.

* Changelog: add #8144

* Changelog: add #8313

* Changelog: add #8419

* Changelog: add #8465

* Changelog: add #8515

* Changelog: add #8587

* Changelog: add #8591

* Changelog: add #8659

* Changelog: add #8661

* Changelog: add #8671

* Changelog: add 5.7.1 to archived changelog too.

* Reverted changes to readme, removed entry about backups.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

@zinigor zinigor zinigor approved these changes

@beaulebens beaulebens Awaiting requested review from beaulebens

Assignees
No one assigned
Labels
Admin Page React-powered dashboard under the Jetpack menu [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
5.8
Development

Successfully merging this pull request may close these issues.
4 participants
@dereksmart @zinigor @jeherve @matticbot