Sync: Update User Sync Module #8506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enejb
reviewed
Jan 11, 2018
|
|
||
| return; | ||
| } | ||
| do_action( 'jetpack_sync_register_user', $user_id ); |
There was a problem hiding this comment.
Do we need to add the Documentation comment here?
enejb
reviewed
Jan 11, 2018
| /** | ||
| * Fires when the client needs to sync an updated user | ||
| * | ||
| * @since 4.2.0 | ||
| * | ||
| * @param object The Sanitized WP_User object | ||
| * @param array state Since 5.8 | ||
| * @param array state Since 5.8 |
roccotripaldi
approved these changes
Jan 12, 2018
jeherve
reviewed
Jan 12, 2018
| /** | ||
| * Fires when a new user is registered on a site | ||
| * | ||
| * @since 4.9.0 |
There was a problem hiding this comment.
Thank you for adding documentation! Could you also add the @module sync text to you Sync hooks, so it gets categorized by the parser?
https://developer.jetpack.com/module/sync/
Thank you!
There was a problem hiding this comment.
noted, do you have time for a quick PR to add the missing ones? 😊
There was a problem hiding this comment.
Not right now, no, unfortunately, but I'll keep it in mind :)
zinigor
pushed a commit
that referenced
this pull request
Jan 30, 2018
* Changelog 5.8: create base for changelog. * Update 5.8 release post link * fix 5.8 release date * Updates to plugin description * Changelog: add #8499 * Changelog: add #8506 * Changelog: add #8509 * Changelog: add #8516 * Changelog: add #8517 * Changelog: add #8523 * Changelog: add #8547 * Changelog: add #8496 * Changelog: add #8584 * Changelog: add #8595 * Changelog: add #8445 * Changelog: add #8431 * Changelog: add #8284 * Changelog: add #8270 * Changelog: add #8124 * Changelog: add #8581 * Changelog: add #8463 * Changelog: add #8568 (#8646) * Updates to testing list and changelog * Changelog: add #8443 * Changelog: add #8459 * Changelog: add #8469 * Changelog: add #8464 * Changelog: add #8478 and #8479 * Changelog: add #8483 * Changelog: add #8488 * Changelog: add #8513 * Changelog: add #8555 * Changelog: add #8565 * Changelog: add #8601 * Changelog: add #8612 * Changelog: add first pass at Search items. * Changelog: add more info to help test Search. * Changelog: add #8144 * Changelog: add #8313 * Changelog: add #8419 * Changelog: add #8465 * Changelog: add #8515 * Changelog: add #8587 * Changelog: add #8591 * Changelog: add #8659 * Changelog: add #8661 * Changelog: add #8671 * Changelog: add 5.7.1 to archived changelog too. * Reverted changes to readme, removed entry about backups.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes duplicate synced actions.
To test:
With this diff applied try
adding a new user
editing a user
adding / editing via API
editing your profile
add existing user to multi-site
invite user -> user accepts invite
user registers via registration form
delete user
Ensure stuff is syncing properly upstream.