Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Site Picker: All Sites: Improve Icon Composite #2

Closed
alisterscott opened this issue Nov 16, 2015 · 7 comments
Closed

Site Picker: All Sites: Improve Icon Composite #2

alisterscott opened this issue Nov 16, 2015 · 7 comments
Labels
Site Picker Sites [Type] Enhancement

Comments

@alisterscott
Copy link
Contributor

The current icon-composite used to represent all-sites could be improved.

Current:

original

Proposed by @mtias

proposed
@alisterscott alisterscott added [Type] Enhancement Site Picker Sites [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR labels Nov 16, 2015
@jasmussen
Copy link
Member

I like all the proposals here far more than the current one..

But it also shows some of the challenges we have. Sites have square avatars, people have circle avatars. That means if the squares are right next to each other, they might as well be one big blavatar. On the other hand at the small size here, we need all the pixels we can get.

To be clear: I think all of these are good. The following are just mockups to explore further.

v1

v2

v3

v4

v5

v6

v7

v8

Like I mentioned, the circles while cool looking probably won't work as sites are square.

@mtias
Copy link
Member

mtias commented Feb 1, 2016

@jasmussen we have the count on the right of the component these days. Maybe we can explore just using the icon grid on the left?

image

@jasmussen
Copy link
Member

Maybe we can explore just using the icon grid on the left?

That certainly makes things easier. In that case I think either 4 circles, 4 squares, or 3 stacked diagonal blavatars would work just fine. I have a slight 4 squares preference simply because blavatars are square.

@mtias
Copy link
Member

mtias commented Feb 2, 2016

I have a slight 4 squares preference simply because blavatars are square.

Yes, I think we should stick to this.

@mtias
Copy link
Member

mtias commented Feb 2, 2016

@jasmussen 4 icons no gaps sounds good?

@jasmussen
Copy link
Member

@jasmussen 4 icons no gaps sounds good?

Yep, I think that's the pragmatic choice for the foreseeable future! 👍

@artpi artpi mentioned this issue Feb 15, 2016
Merged
artpi added a commit that referenced this issue Feb 17, 2016
@artpi
Merge pull request #3202 from Automattic/update/editor-duplicating-ac…
d32c307 
…tions

Skyjumping Beavers && Post-editor add redux actions #2
@jeremeylduvall jeremeylduvall mentioned this issue Feb 24, 2016
Merged
@breezyskies breezyskies mentioned this issue Mar 10, 2016
Closed
@klimeryk klimeryk mentioned this issue Mar 30, 2016
Merged
lsinger pushed a commit that referenced this issue May 20, 2016
@mcsf @lsinger
EXPERIMENTAL: Wait for sidebar ready before Preview step
49ed876 
Feel free to revert the changes in the selector, but:
- /stats/day/mysite.wordpress.com/?tour=main works
- /?tour=main works
- /stats/day/?tour=main DOESN'T work

The reason #2 works is that it loads the Reader first, and tapping My
Sites after that will try to take the user to a specific site (to me at
least), whereas in #3 we explicitly go to My Sites with no site
selected, thus the sidebar has no site icon.

Also:

- wait.js: my testing shows that the switch to the Preview step is only
  'delayed' once or twice, but even so I decided to implement a rapidly
  growing `delay` as a defensive practice (e.g., in the #3 above, `wait`
  will keep trying indefinitely, but thanks to the growing `delay` that
  doesn't become a perf concern).

- That said, we could also set some break condition, like a hardcoded
  maximum `delay` (or even a function if we feel that need) after which
  `wait` stops trying.
lsinger pushed a commit that referenced this issue May 23, 2016
@mcsf @lsinger
EXPERIMENTAL: Wait for sidebar ready before Preview step
1fb0ef4 
Feel free to revert the changes in the selector, but:
- /stats/day/mysite.wordpress.com/?tour=main works
- /?tour=main works
- /stats/day/?tour=main DOESN'T work

The reason #2 works is that it loads the Reader first, and tapping My
Sites after that will try to take the user to a specific site (to me at
least), whereas in #3 we explicitly go to My Sites with no site
selected, thus the sidebar has no site icon.

Also:

- wait.js: my testing shows that the switch to the Preview step is only
  'delayed' once or twice, but even so I decided to implement a rapidly
  growing `delay` as a defensive practice (e.g., in the #3 above, `wait`
  will keep trying indefinitely, but thanks to the growing `delay` that
  doesn't become a perf concern).

- That said, we could also set some break condition, like a hardcoded
  maximum `delay` (or even a function if we feel that need) after which
  `wait` stops trying.
@ehg ehg mentioned this issue May 24, 2016
Merged
10 tasks
@alisterscott
Copy link
Contributor Author

I'm doing a bug scrub, currently All Sites looks like this:

screen shot 2016-06-03 at 8 43 33 am

Are we okay with it for now? Can I close this issue?

@mtias mtias closed this as completed Jun 3, 2016
@blowery blowery mentioned this issue Nov 30, 2016
Merged
blowery pushed a commit that referenced this issue Dec 15, 2016
@bluefuton @blowery
Move FollowButton to blocks (attempt #2) (#9836)
254577c 
* Revert "Revert "Move FollowButton to blocks""

* Update follow button stylesheet location
@sararosso sararosso mentioned this issue Jan 10, 2017
Merged
@lancewillett lancewillett removed the [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR label Jan 18, 2017
@ashleighaxios ashleighaxios mentioned this issue Jan 27, 2017
Merged
@klimeryk klimeryk mentioned this issue Apr 11, 2017
Merged
This was referenced Oct 19, 2022
Closed
Closed
claudiucelfilip added a commit that referenced this issue Oct 20, 2022
@claudiucelfilip @noahtallen
Add server-friendly content sanitizer for Plugins SSR #2 (#69280)
980886a 
* Add server sanitization dependencies

* Add server parser code and test

* Use server sanitizer for plugins content

* Wrap server DOM parser in try catch and add comment

* Use wp_kses style allowed tags configuration

* Add extra sanitizer tests

* Add more malformed HTML test cases

* Replace server-dom implementaiton with jsdom

* Update yarn.lock with jsdom dependency

* Dedupe packages

* Use package.json resolutions instead of yarn dedupe

* Add missing jsdom deps needed for production build

* Make sure correct root is used for content sanitizer tests

* Avoid including optional dependencies in production build

* Reuse DOMParser instance for sanitization

* Sanitize plugin data before caching to react-query

* Check for optional property when filtering out optional dependencies

* Replace any types with unknown

* Remove unnecessary changes and IE 11 support

* Add missing type

* Replace deprecaated and incorrect type

* Restore plugins query any types

* Remove potentially unnecessary package resolutions

* Add duplicate packages to version resolutions

* Restrict jest text econding fix for jsdom to affected test suite

* Move jsdom test global fix outside of test folder

* Remove unneeded dependency definitions

* Restore lzma-native version resolution

* Updated cache keys for normalized queries

Co-authored-by: Noah Allen <noahtallen@gmail.com>
@taipeicoder taipeicoder mentioned this issue Nov 10, 2022
Closed
kangzj added a commit that referenced this issue Dec 8, 2022
@kangzj
Stats: add Odyssey Stats to TeamCity build config - Take #2 (#70915)
726c0c8 
* slug need to match directory name in apps

* change build name to "Calypso Stats"

* rename Calypso Stats to Odyssey Stats

* rename stats to odyssey-stats
@a8ck3n a8ck3n mentioned this issue Jan 16, 2023
Merged
7 tasks
tyxla added a commit that referenced this issue Mar 13, 2023
@tyxla @noahtallen
Try #2: Upgrade @WordPress packages to pre-React 18 (#73890)
9651d4a 
* Update packages to pre- react 18 versions

* Noop some type packages with stale @wordpress/data module declarations

* Fix some TS errors

* Fix some unit tests

* Fix TS errors in wpcom-checkout

* Fix more TS errors

* Fix TS errors in wpcom-plans-ui data store

* Fix a bunch of other TS errors

* Fix a bunch of other TS errors

* Fix a bunch more TS errors

* Fix type confusion

* Add core/data temp placeholder types

* deduplicate packages

* Ignore some logs

* Fix another failing test

* Fix a couple more tests

* Fix a bad import

* Force @wordpress/element resolution

* Fix more code style errors

* Fix some code style errors

* Declare TS modules of the nooped types

* Pin @wordpress/data-controls version

* Fix a ton of ETK TS errors

* Remove some undesired obsolete type packages

* Restore @wordpress/data-controls types

* Add necessary @wordpress/blocks types inline

* Remove a duplicate __i18n_text_domain__

* Dedupe again

* Revert "Remove a duplicate __i18n_text_domain__"

This reverts commit 6fda7b7c54affc8044d4732b5790ac0aa92b972e.

* Workaround a __i18n_text_domain__ duplication

* Fix a bunch of store and checkout TS errors

* Fix more package TS errors

* Start fixing some more TS errors

* More TS fixes

* Fix a bunch more TS errors

* More TS error fixes

* Fix some imports

* More TS errors

* Fix bad import

* A few more TS fixes

* More TS errors fixed

* Add @automattic/global-styles to tsconfig references

* Fix a few more type errors

* Fix a few more TS errors

* Ignore another log entry

* Fix more TS errors

* Pin @wordpress/base-styles

* Revert @wordpress/env upgrade

* Add missing select dependency

* Add missing data dependencies to useSelect calls

* Remove some now uneeded ts-ignore lines

* Polish some useSelect dependencies

* Polish another useSelect data dependency

* Account for possibly undefined stores

* Add more data dependencies to useSelect calls

* Fix render loop caused by obj reference changing each render

---------

Co-authored-by: Noah Allen <noahtallen@gmail.com>
@ttcath ttcath mentioned this issue Mar 14, 2023
Closed
@jkguidaven jkguidaven mentioned this issue Apr 13, 2023
Merged
7 tasks
@Addison-Stavlo Addison-Stavlo mentioned this issue May 12, 2023
Merged
7 tasks
@jeyip jeyip mentioned this issue Jul 28, 2023
Merged
7 tasks
@moon0326 moon0326 mentioned this issue Sep 19, 2023
Merged
7 tasks
claudiucelfilip added a commit that referenced this issue Oct 5, 2023
@claudiucelfilip
Add anon_id to user Signup and Login #2 (#82648)
1f2a1e3 
* Add anon_id to signup and login requests

* Add anonId to social login
@a8ck3n a8ck3n mentioned this issue Oct 19, 2023
Closed
@agrullon95 agrullon95 mentioned this issue Oct 26, 2023
Merged
taipeicoder added a commit that referenced this issue Dec 13, 2023
@taipeicoder
Remove Assembler Survey #2
ad1b021
@taipeicoder taipeicoder mentioned this issue Dec 13, 2023
Merged
7 tasks
taipeicoder added a commit that referenced this issue Dec 13, 2023
@taipeicoder
Remove Assembler Survey #2 (#85185)
7513d37
chriskmnds pushed a commit that referenced this issue Dec 13, 2023
@taipeicoder @chriskmnds
Remove Assembler Survey #2 (#85185)
17c3ad5
@miksansegundo miksansegundo mentioned this issue Dec 29, 2023
Closed
7 tasks
@gabrielcaires gabrielcaires mentioned this issue Mar 22, 2024
Merged
@jjchrisdiehl jjchrisdiehl mentioned this issue Apr 3, 2024
Merged
@jkguidaven jkguidaven mentioned this issue Jul 8, 2024
Merged
7 tasks
@valterlorran valterlorran mentioned this issue Aug 7, 2024
Merged
7 tasks
@katiebethbrown katiebethbrown mentioned this issue Aug 12, 2024
Closed
@hacchism hacchism mentioned this issue Oct 31, 2024
Closed
@jeyip jeyip mentioned this issue Nov 8, 2024
Merged
7 tasks
@fditrapani fditrapani mentioned this issue Dec 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Site Picker Sites [Type] Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@lancewillett @alisterscott @mtias @jasmussen