fix: retry request spot

[charlielye]

I've seen some jobs failing silently around starting spot instances.
I've seen some network errors around manifest stuff.

This may not fix the first issue. But it does introduce a little extra logging that might give an idea of whats failing. It will retry the spinning up of the instance if it fails, but im not convinced that was what was failing.

This adds retries to the manifest stuff.

[AztecBot]

Benchmark results

Metrics with a significant change:

• note_trial_decrypting_time_in_ms (8): 8.00 (-92%)
• note_trial_decrypting_time_in_ms (32): 94.0 (+38%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 6c20b459 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	128 txs
l1_rollup_calldata_size_in_bytes	45,444	179,588	716,132
l1_rollup_calldata_gas	222,804	868,208	3,447,992
l1_rollup_execution_gas	841,891	3,595,316	22,203,361
l2_block_processing_time_in_ms	2,011 (-1%)	7,681 (+3%)	30,056 (+2%)
note_successful_decrypting_time_in_ms	304 (+2%)	886 (+3%)	3,308 (+5%)
note_trial_decrypting_time_in_ms	⚠️ 8.00 (-92%)	⚠️ 94.0 (+38%)	135 (+1%)
l2_block_building_time_in_ms	13,291 (+1%)	53,022 (+2%)	210,968 (+1%)
l2_block_rollup_simulation_time_in_ms	11,954 (+1%)	47,690 (+2%)	189,318 (+1%)
l2_block_public_tx_process_time_in_ms	1,295 (+2%)	5,197 (+2%)	21,151 (+3%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	21,573	42,373
note_history_successful_decrypting_time_in_ms	2,033 (+1%)	3,971 (+2%)
note_history_trial_decrypting_time_in_ms	122	143 (-1%)
node_database_size_in_bytes	1,629,334	1,097,876
pxe_database_size_in_bytes	27,188	54,187

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	72.5 (+1%)	61,697	18,841
private-kernel-ordering	43.6	24,233	8,089
base-rollup	1,774	656,309	811
root-rollup	76.1 (-2%)	4,072	1,097
private-kernel-inner	53.4 (+1%)	81,504	18,841
public-kernel-private-input	42.0 (+1%)	41,455	18,841
public-kernel-non-first-iteration	26.8 (+2%)	41,497	18,841
merge-rollup	0.920 (+4%)	2,592	873

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric	0 deployed contracts	1 deployed contracts
tx_size_in_bytes	8,723	27,240

[ludamad]

&2 at end of line seems to read better to me but ymmv

[charlielye]

Having it at the start of the line makes it very clear I think. Ones brain can't fail to see it.