feat: adding structure to Transcript #2937

lucasxia01 · 2023-10-19T21:22:29Z

Adding structuring feature to transcript based on the flavor and resolves AztecProtocol/barretenberg#656.

The main two functions added are deserialize_full_transcript() and serialize_full_transcript(), which are defined for each flavored transcript derived class. These classes are defined in the flavor classes, and primarily declare all of the transcript objects as member variables.

deserialize_full_transcript() will take a full proof generated by the flavored prover, and put all those bytes into the member variables. Then, one can now view and modify the objects by just using the member variables. In order to actually push the modification, one has to call serialize_full_transcript() in order to regenerate the proof from the (modified) member variables. The tests in (flavor)_transcript.test.cpp illustrate how to use these functions in more depth. I also modified the tests in stdlib/recursion/honk/verifier/goblin_verifier.test.cpp and in stdlib/recursion/honk/verifier/verifier.test.cpp.

Got rid of the ProverTranscript and VerifierTranscript and merging them into the BaseTranscript. This was done to avoid having to create these for every flavor derived class and because they did not provide much on top of the BaseTranscript.

Created transcript tests for flavors besides Ultra.

Transcript breakdown for all flavors: https://docs.google.com/spreadsheets/d/1TpkkPj9o5ZXr_kWT7WsquXSEZY10C1Lt3BWeCA7Qe9U/edit#gid=0.

Some design considerations: https://hackmd.io/o8HbTiujTGa4sLccAHQaxw?both.

AztecBot · 2023-10-19T21:54:54Z

Benchmark results

No metrics with a significant change found.

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 3e071046 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	128 txs
l1_rollup_calldata_size_in_bytes	45,444	179,588	716,132
l1_rollup_calldata_gas	222,924	867,764	3,444,896
l1_rollup_execution_gas	842,011	3,594,872	22,200,265
l2_block_processing_time_in_ms	1,985 (-2%)	7,531 (-1%)	29,630 (-1%)
note_successful_decrypting_time_in_ms	293	854 (-1%)	3,136 (-1%)
note_trial_decrypting_time_in_ms	94.0 (-1%)	62.0 (-16%)	134
l2_block_building_time_in_ms	13,171 (-1%)	52,017 (-1%)	208,139 (-1%)
l2_block_rollup_simulation_time_in_ms	11,845 (-1%)	46,787 (-1%)	187,066 (-1%)
l2_block_public_tx_process_time_in_ms	1,284	5,096 (-1%)	20,583 (-1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	21,651	42,444
note_history_successful_decrypting_time_in_ms	2,054 (-1%)	3,949 (-2%)
note_history_trial_decrypting_time_in_ms	122	144 (+1%)
node_database_size_in_bytes	1,631,093	1,099,544
pxe_database_size_in_bytes	29,748	59,307

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	72.4	61,697	18,841
private-kernel-ordering	43.6	24,233	8,089
base-rollup	1,769	656,309	811
root-rollup	75.4	4,072	1,097
private-kernel-inner	53.7 (+1%)	81,504	18,841
public-kernel-private-input	41.8	41,455	18,841
public-kernel-non-first-iteration	26.8	41,497	18,841
merge-rollup	0.920 (+5%)	2,592	873

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric	0 deployed contracts	1 deployed contracts
tx_size_in_bytes	8,723	27,240

created transcript in goblin_ultra

lucasxia01 · 2023-10-24T20:25:32Z

barretenberg/cpp/src/barretenberg/honk/transcript/transcript.hpp

-    void print() { manifest.print(); }
-};
-
-template <typename FF> class ProverTranscript : public BaseTranscript<FF> {


deleting ProverTranscript and VerifierTranscript and merging it with BaseTranscript so that I do not have to define Prover/Verifier Transcripts that inherit from each flavor Transcript class.

lucasxia01 · 2023-10-24T20:29:24Z

barretenberg/cpp/src/barretenberg/honk/transcript/transcript.hpp

+     * @param label Human readable name for the challenge.
+     * @return deserialized element of type T
+     */
+    template <class T> T receive_from_prover(const std::string& label)


code is not new; just moved and num_bytes_read_ was renamed to num_bytes_read

made goblin ultra transcript tests

small update to transcript test to be random

lucasxia01 · 2023-10-26T21:20:59Z

barretenberg/cpp/src/barretenberg/honk/transcript/ultra_transcript.test.cpp

+        builder.add_public_variable(a);
+    }
+
+    void generate_random_test_circuit(auto& builder)


probably should just use this function instead of the other function in all places

lucasxia01 · 2023-10-26T21:22:14Z

barretenberg/cpp/src/barretenberg/honk/transcript/goblin_ultra_transcript.test.cpp

+        return manifest_expected;
+    }
+
+    void generate_test_circuit(auto& builder)


mostly copied from generate_test_circuit in goblin_ultra_composer.test.cpp, but with only 1 big add gate.

lucasxia01 · 2023-10-26T21:23:17Z

barretenberg/cpp/src/barretenberg/honk/transcript/eccvm_transcript.test.cpp

+
+        return manifest_expected;
+    }
+    proof_system::ECCVMCircuitBuilder<Flavor> generate_trace(numeric::random::Engine* engine = nullptr)


copied from eccvm_composer.test.cpp

barretenberg/cpp/src/barretenberg/honk/flavor/goblin_translator.hpp

lucasxia01 · 2023-10-26T21:27:30Z

barretenberg/cpp/src/barretenberg/honk/flavor/ultra_recursive.hpp

@@ -396,6 +396,127 @@ template <typename BuilderType> class UltraRecursive_ {
            this->lagrange_last = verification_key->lagrange_last;
        }
    };
+


should be identical to Ultra Transcript

except with all the qualifiers that come from templating

lucasxia01 · 2023-10-26T21:29:27Z

barretenberg/cpp/src/barretenberg/honk/proof_system/eccvm_verifier.cpp

@@ -168,7 +169,7 @@ template <typename Flavor> bool ECCVMVerifier_<Flavor>::verify_proof(const plonk
        transcript.template receive_from_prover<Commitment>(commitment_labels.lookup_read_counts_1);

    // Get challenge for sorted list batching and wire four memory records
-    auto [beta, gamma] = transcript.get_challenges("bbeta", "gamma");


Zac's typo I think; was confused how the manifest test was failing for a bit.

barretenberg/cpp/src/barretenberg/honk/proof_system/protogalaxy_prover.hpp

codygunton

Nice work! Please make the small changes I request and then merge when ready (please merge master one more time, and remove the checklist from the merge commit message).

codygunton · 2023-10-27T18:46:23Z

barretenberg/cpp/src/barretenberg/honk/transcript/transcript.hpp

+     * @param element
+     * @param proof_data
+     */
+    template <typename T> void serialize_object(const T& element, std::vector<uint8_t>& proof_data)


Could you rename these to serialize_to/from_buffer to align more with existing names? The word "object" isn't doing much here.

barretenberg/cpp/src/barretenberg/stdlib/recursion/honk/transcript/transcript.test.cpp

barretenberg/cpp/src/barretenberg/honk/proof_system/protogalaxy_prover.hpp

barretenberg/cpp/src/barretenberg/honk/flavor/goblin_translator.hpp

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-packages: 0.13.0</summary> ## [0.13.0](aztec-packages-v0.12.0...aztec-packages-v0.13.0) (2023-10-31) ### ⚠ BREAKING CHANGES * PXE.getNotes(...) + refactor of note types ([#3051](#3051)) ### Features * `FieldNote` ([#3037](#3037)) ([3d1ffd0](3d1ffd0)) * Add Aztec Boxes page to docs ([#2569](#2569)) ([997c15c](997c15c)) * Adding structure to Transcript ([#2937](#2937)) ([db67aa1](db67aa1)) * Compile noir contracts with noir_wasm ([#2737](#2737)) ([524cecf](524cecf)) * Dockerize aztec-cli ([#3031](#3031)) ([ec2e3c2](ec2e3c2)) * Efficient ZM quotient computation ([#3016](#3016)) ([ebda5fc](ebda5fc)) * **feature_branch:** Private Kernel Circuit ([#2740](#2740)) ([f800a36](f800a36)) * Measure plonk rounds ([#3065](#3065)) ([c8e1d8b](c8e1d8b)) * Migrate the init kernel CPP tests to noir ([#3091](#3091)) ([906429f](906429f)) * New script to output table of benchmarks for README pasting. ([#2780](#2780)) ([6c20b45](6c20b45)) * Pedersen in typescript. ([#3111](#3111)) ([933f1b2](933f1b2)) * Protogalaxy folding of challenges ([#2935](#2935)) ([7ed30e8](7ed30e8)) * PXE.getNotes(...) + refactor of note types ([#3051](#3051)) ([16abb5a](16abb5a)) * Zeromorph with concatenation (Goblin Translator part 10) ([#3006](#3006)) ([70b0f17](70b0f17)) ### Bug Fixes * Bad contract txs publishing contract data ([#2673](#2673)) ([ccd4611](ccd4611)) * Better error message for compute_note_hash_and_nullifier. ([#3097](#3097)) ([57bec53](57bec53)) * Broken `FieldNote` test ([#3135](#3135)) ([fe78ecf](fe78ecf)) * Docker-compose up, rather than run. ([#3081](#3081)) ([242f780](242f780)) * Formatting ([#3070](#3070)) ([e1633d3](e1633d3)) * Minor stale naming fix ([#3117](#3117)) ([a6786ae](a6786ae)) * Push cli docker image to docker hub ([#3120](#3120)) ([ccad50f](ccad50f)) * Remove duplicate terraform resource definition ([#3066](#3066)) ([d5abadb](d5abadb)) * Retry request spot ([#3116](#3116)) ([82de5f1](82de5f1)) ### Miscellaneous * Add stdlib tests for pedersen commitment ([#3075](#3075)) ([87fa621](87fa621)) * Automatic c_binds for commit should return a point instead of an Fr element ([#3072](#3072)) ([2e289a5](2e289a5)) * Cleanup remaining mentions of `compress` with pedersen in cpp and ts ([#3074](#3074)) ([52cf383](52cf383)) * E2e on spots [ci rebuild] ([#3068](#3068)) ([15db6bf](15db6bf)) * Fix dapp_testing e2e race condition ([#3094](#3094)) ([89e7c21](89e7c21)) * Remove docs mirror ([#3122](#3122)) ([3fa51e2](3fa51e2)) * Remove endomorphism coefficient from ecc_add_gate ([#3115](#3115)) ([d294987](d294987)) * Remove unecessary calls to `pedersen__init` ([#3079](#3079)) ([84f8db2](84f8db2)) * Remove unused pedersen c_binds ([#3058](#3058)) ([e71e5f9](e71e5f9)) * Removes pedersen commit native pairs method ([#3073](#3073)) ([69a34c7](69a34c7)) * Rename private-kernel subpackage to protocol-circuits ([#3134](#3134)) ([3e07104](3e07104)) ### Documentation * Initial keys spec ([#3035](#3035)) ([4b24c58](4b24c58)) </details> <details><summary>barretenberg.js: 0.13.0</summary> ## [0.13.0](barretenberg.js-v0.12.0...barretenberg.js-v0.13.0) (2023-10-31) ### Features * New script to output table of benchmarks for README pasting. ([#2780](#2780)) ([6c20b45](6c20b45)) ### Miscellaneous * Automatic c_binds for commit should return a point instead of an Fr element ([#3072](#3072)) ([2e289a5](2e289a5)) * Remove unecessary calls to `pedersen__init` ([#3079](#3079)) ([84f8db2](84f8db2)) * Remove unused pedersen c_binds ([#3058](#3058)) ([e71e5f9](e71e5f9)) </details> <details><summary>barretenberg: 0.13.0</summary> ## [0.13.0](barretenberg-v0.12.0...barretenberg-v0.13.0) (2023-10-31) ### Features * Adding structure to Transcript ([#2937](#2937)) ([db67aa1](db67aa1)) * Efficient ZM quotient computation ([#3016](#3016)) ([ebda5fc](ebda5fc)) * Measure plonk rounds ([#3065](#3065)) ([c8e1d8b](c8e1d8b)) * New script to output table of benchmarks for README pasting. ([#2780](#2780)) ([6c20b45](6c20b45)) * Pedersen in typescript. ([#3111](#3111)) ([933f1b2](933f1b2)) * Protogalaxy folding of challenges ([#2935](#2935)) ([7ed30e8](7ed30e8)) * Zeromorph with concatenation (Goblin Translator part 10) ([#3006](#3006)) ([70b0f17](70b0f17)) ### Miscellaneous * Add stdlib tests for pedersen commitment ([#3075](#3075)) ([87fa621](87fa621)) * Automatic c_binds for commit should return a point instead of an Fr element ([#3072](#3072)) ([2e289a5](2e289a5)) * Cleanup remaining mentions of `compress` with pedersen in cpp and ts ([#3074](#3074)) ([52cf383](52cf383)) * Remove endomorphism coefficient from ecc_add_gate ([#3115](#3115)) ([d294987](d294987)) * Remove unecessary calls to `pedersen__init` ([#3079](#3079)) ([84f8db2](84f8db2)) * Remove unused pedersen c_binds ([#3058](#3058)) ([e71e5f9](e71e5f9)) * Removes pedersen commit native pairs method ([#3073](#3073)) ([69a34c7](69a34c7)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-packages: 0.13.0</summary> ## [0.13.0](AztecProtocol/aztec-packages@aztec-packages-v0.12.0...aztec-packages-v0.13.0) (2023-10-31) ### ⚠ BREAKING CHANGES * PXE.getNotes(...) + refactor of note types ([#3051](AztecProtocol/aztec-packages#3051)) ### Features * `FieldNote` ([#3037](AztecProtocol/aztec-packages#3037)) ([3d1ffd0](AztecProtocol/aztec-packages@3d1ffd0)) * Add Aztec Boxes page to docs ([#2569](AztecProtocol/aztec-packages#2569)) ([997c15c](AztecProtocol/aztec-packages@997c15c)) * Adding structure to Transcript ([#2937](AztecProtocol/aztec-packages#2937)) ([db67aa1](AztecProtocol/aztec-packages@db67aa1)) * Compile noir contracts with noir_wasm ([#2737](AztecProtocol/aztec-packages#2737)) ([524cecf](AztecProtocol/aztec-packages@524cecf)) * Dockerize aztec-cli ([#3031](AztecProtocol/aztec-packages#3031)) ([ec2e3c2](AztecProtocol/aztec-packages@ec2e3c2)) * Efficient ZM quotient computation ([#3016](AztecProtocol/aztec-packages#3016)) ([ebda5fc](AztecProtocol/aztec-packages@ebda5fc)) * **feature_branch:** Private Kernel Circuit ([#2740](AztecProtocol/aztec-packages#2740)) ([f800a36](AztecProtocol/aztec-packages@f800a36)) * Measure plonk rounds ([#3065](AztecProtocol/aztec-packages#3065)) ([c8e1d8b](AztecProtocol/aztec-packages@c8e1d8b)) * Migrate the init kernel CPP tests to noir ([#3091](AztecProtocol/aztec-packages#3091)) ([906429f](AztecProtocol/aztec-packages@906429f)) * New script to output table of benchmarks for README pasting. ([#2780](AztecProtocol/aztec-packages#2780)) ([6c20b45](AztecProtocol/aztec-packages@6c20b45)) * Pedersen in typescript. ([#3111](AztecProtocol/aztec-packages#3111)) ([933f1b2](AztecProtocol/aztec-packages@933f1b2)) * Protogalaxy folding of challenges ([#2935](AztecProtocol/aztec-packages#2935)) ([7ed30e8](AztecProtocol/aztec-packages@7ed30e8)) * PXE.getNotes(...) + refactor of note types ([#3051](AztecProtocol/aztec-packages#3051)) ([16abb5a](AztecProtocol/aztec-packages@16abb5a)) * Zeromorph with concatenation (Goblin Translator part 10) ([#3006](AztecProtocol/aztec-packages#3006)) ([70b0f17](AztecProtocol/aztec-packages@70b0f17)) ### Bug Fixes * Bad contract txs publishing contract data ([#2673](AztecProtocol/aztec-packages#2673)) ([ccd4611](AztecProtocol/aztec-packages@ccd4611)) * Better error message for compute_note_hash_and_nullifier. ([#3097](AztecProtocol/aztec-packages#3097)) ([57bec53](AztecProtocol/aztec-packages@57bec53)) * Broken `FieldNote` test ([#3135](AztecProtocol/aztec-packages#3135)) ([fe78ecf](AztecProtocol/aztec-packages@fe78ecf)) * Docker-compose up, rather than run. ([#3081](AztecProtocol/aztec-packages#3081)) ([242f780](AztecProtocol/aztec-packages@242f780)) * Formatting ([#3070](AztecProtocol/aztec-packages#3070)) ([e1633d3](AztecProtocol/aztec-packages@e1633d3)) * Minor stale naming fix ([#3117](AztecProtocol/aztec-packages#3117)) ([a6786ae](AztecProtocol/aztec-packages@a6786ae)) * Push cli docker image to docker hub ([#3120](AztecProtocol/aztec-packages#3120)) ([ccad50f](AztecProtocol/aztec-packages@ccad50f)) * Remove duplicate terraform resource definition ([#3066](AztecProtocol/aztec-packages#3066)) ([d5abadb](AztecProtocol/aztec-packages@d5abadb)) * Retry request spot ([#3116](AztecProtocol/aztec-packages#3116)) ([82de5f1](AztecProtocol/aztec-packages@82de5f1)) ### Miscellaneous * Add stdlib tests for pedersen commitment ([#3075](AztecProtocol/aztec-packages#3075)) ([87fa621](AztecProtocol/aztec-packages@87fa621)) * Automatic c_binds for commit should return a point instead of an Fr element ([#3072](AztecProtocol/aztec-packages#3072)) ([2e289a5](AztecProtocol/aztec-packages@2e289a5)) * Cleanup remaining mentions of `compress` with pedersen in cpp and ts ([#3074](AztecProtocol/aztec-packages#3074)) ([52cf383](AztecProtocol/aztec-packages@52cf383)) * E2e on spots [ci rebuild] ([#3068](AztecProtocol/aztec-packages#3068)) ([15db6bf](AztecProtocol/aztec-packages@15db6bf)) * Fix dapp_testing e2e race condition ([#3094](AztecProtocol/aztec-packages#3094)) ([89e7c21](AztecProtocol/aztec-packages@89e7c21)) * Remove docs mirror ([#3122](AztecProtocol/aztec-packages#3122)) ([3fa51e2](AztecProtocol/aztec-packages@3fa51e2)) * Remove endomorphism coefficient from ecc_add_gate ([#3115](AztecProtocol/aztec-packages#3115)) ([d294987](AztecProtocol/aztec-packages@d294987)) * Remove unecessary calls to `pedersen__init` ([#3079](AztecProtocol/aztec-packages#3079)) ([84f8db2](AztecProtocol/aztec-packages@84f8db2)) * Remove unused pedersen c_binds ([#3058](AztecProtocol/aztec-packages#3058)) ([e71e5f9](AztecProtocol/aztec-packages@e71e5f9)) * Removes pedersen commit native pairs method ([#3073](AztecProtocol/aztec-packages#3073)) ([69a34c7](AztecProtocol/aztec-packages@69a34c7)) * Rename private-kernel subpackage to protocol-circuits ([#3134](AztecProtocol/aztec-packages#3134)) ([3e07104](AztecProtocol/aztec-packages@3e07104)) ### Documentation * Initial keys spec ([#3035](AztecProtocol/aztec-packages#3035)) ([4b24c58](AztecProtocol/aztec-packages@4b24c58)) </details> <details><summary>barretenberg.js: 0.13.0</summary> ## [0.13.0](AztecProtocol/aztec-packages@barretenberg.js-v0.12.0...barretenberg.js-v0.13.0) (2023-10-31) ### Features * New script to output table of benchmarks for README pasting. ([#2780](AztecProtocol/aztec-packages#2780)) ([6c20b45](AztecProtocol/aztec-packages@6c20b45)) ### Miscellaneous * Automatic c_binds for commit should return a point instead of an Fr element ([#3072](AztecProtocol/aztec-packages#3072)) ([2e289a5](AztecProtocol/aztec-packages@2e289a5)) * Remove unecessary calls to `pedersen__init` ([#3079](AztecProtocol/aztec-packages#3079)) ([84f8db2](AztecProtocol/aztec-packages@84f8db2)) * Remove unused pedersen c_binds ([#3058](AztecProtocol/aztec-packages#3058)) ([e71e5f9](AztecProtocol/aztec-packages@e71e5f9)) </details> <details><summary>barretenberg: 0.13.0</summary> ## [0.13.0](AztecProtocol/aztec-packages@barretenberg-v0.12.0...barretenberg-v0.13.0) (2023-10-31) ### Features * Adding structure to Transcript ([#2937](AztecProtocol/aztec-packages#2937)) ([db67aa1](AztecProtocol/aztec-packages@db67aa1)) * Efficient ZM quotient computation ([#3016](AztecProtocol/aztec-packages#3016)) ([ebda5fc](AztecProtocol/aztec-packages@ebda5fc)) * Measure plonk rounds ([#3065](AztecProtocol/aztec-packages#3065)) ([c8e1d8b](AztecProtocol/aztec-packages@c8e1d8b)) * New script to output table of benchmarks for README pasting. ([#2780](AztecProtocol/aztec-packages#2780)) ([6c20b45](AztecProtocol/aztec-packages@6c20b45)) * Pedersen in typescript. ([#3111](AztecProtocol/aztec-packages#3111)) ([933f1b2](AztecProtocol/aztec-packages@933f1b2)) * Protogalaxy folding of challenges ([#2935](AztecProtocol/aztec-packages#2935)) ([7ed30e8](AztecProtocol/aztec-packages@7ed30e8)) * Zeromorph with concatenation (Goblin Translator part 10) ([#3006](AztecProtocol/aztec-packages#3006)) ([70b0f17](AztecProtocol/aztec-packages@70b0f17)) ### Miscellaneous * Add stdlib tests for pedersen commitment ([#3075](AztecProtocol/aztec-packages#3075)) ([87fa621](AztecProtocol/aztec-packages@87fa621)) * Automatic c_binds for commit should return a point instead of an Fr element ([#3072](AztecProtocol/aztec-packages#3072)) ([2e289a5](AztecProtocol/aztec-packages@2e289a5)) * Cleanup remaining mentions of `compress` with pedersen in cpp and ts ([#3074](AztecProtocol/aztec-packages#3074)) ([52cf383](AztecProtocol/aztec-packages@52cf383)) * Remove endomorphism coefficient from ecc_add_gate ([#3115](AztecProtocol/aztec-packages#3115)) ([d294987](AztecProtocol/aztec-packages@d294987)) * Remove unecessary calls to `pedersen__init` ([#3079](AztecProtocol/aztec-packages#3079)) ([84f8db2](AztecProtocol/aztec-packages@84f8db2)) * Remove unused pedersen c_binds ([#3058](AztecProtocol/aztec-packages#3058)) ([e71e5f9](AztecProtocol/aztec-packages@e71e5f9)) * Removes pedersen commit native pairs method ([#3073](AztecProtocol/aztec-packages#3073)) ([69a34c7](AztecProtocol/aztec-packages@69a34c7)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

combined transcripts to be all in base transcript

cea5c1b

lucasxia01 changed the title ~~combined transcripts to be all in base transcript~~ feat: adding structure to Transcript Oct 19, 2023

lucasxia01 marked this pull request as draft October 19, 2023 21:23

minor update

b7fc57e

lucasxia01 added 7 commits October 19, 2023 22:31

initialize serialization function

4bd910a

added serialization,

f37e650

created transcript in goblin_ultra

small fix

15526d5

initial integration of flavored transcripts, might be incomplete

029ae02

initial test of using structure

296724f

updated test, fixed bug

8cca406

updated eccvm flavors transcript, minor changes

750239a

codygunton assigned lucasxia01 Oct 24, 2023

This was referenced Oct 24, 2023

feat: Transcript redesign #2668

Closed

Native verification via simulator AztecProtocol/barretenberg#721

Closed

added function header comments

33bb44c

lucasxia01 commented Oct 24, 2023

View reviewed changes

lucasxia01 added 6 commits October 24, 2023 21:38

added transcript class to recursive flavors, added more comments

9563963

Merge branch 'master' into lx/transcript-add-structure

6130155

small fix

8ade65d

small edits to ultra transcript tests

27be1f6

updated ultra transcrip tests,

a3fd40d

made goblin ultra transcript tests

made eccvm tests, fixed bugs and typos in eccvm flavor

35f67e2

lucasxia01 marked this pull request as ready for review October 26, 2023 21:13

lucasxia01 added 2 commits October 26, 2023 21:17

renamed transcript tests to be ultra,

b41dec5

small update to transcript test to be random

updated Luke's proof tampering recursive tests

bdcf377

lucasxia01 requested a review from codygunton October 26, 2023 21:18

lucasxia01 commented Oct 26, 2023

View reviewed changes

barretenberg/cpp/src/barretenberg/honk/flavor/goblin_translator.hpp Outdated Show resolved Hide resolved

lucasxia01 commented Oct 26, 2023

View reviewed changes

barretenberg/cpp/src/barretenberg/honk/proof_system/protogalaxy_prover.hpp Show resolved Hide resolved

codygunton approved these changes Oct 27, 2023

View reviewed changes

lucasxia01 added 5 commits October 30, 2023 22:33

small changes, renamed functions

e1f4b74

Merge branch 'master' into lx/transcript-add-structure

8142b97

merge conflict fix

0e4e07c

Merge branch 'master' into lx/transcript-add-structure

1bb7cbf

update to relation_length variable names

22e78b2

lucasxia01 merged commit db67aa1 into master Oct 31, 2023
2 checks passed

lucasxia01 deleted the lx/transcript-add-structure branch October 31, 2023 03:43

AztecBot mentioned this pull request Oct 31, 2023

chore(master): Release 0.13.0 #3067

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: adding structure to Transcript #2937

feat: adding structure to Transcript #2937

lucasxia01 commented Oct 19, 2023 •

edited

Loading

AztecBot commented Oct 19, 2023 •

edited

Loading

L2 block published to L1

L2 chain processing

Circuits stats

Miscellaneous

lucasxia01 Oct 24, 2023

lucasxia01 Oct 24, 2023

lucasxia01 Oct 26, 2023

lucasxia01 Oct 26, 2023

lucasxia01 Oct 26, 2023

lucasxia01 Oct 26, 2023

lucasxia01 Oct 26, 2023

lucasxia01 Oct 26, 2023

codygunton left a comment •

edited

Loading

codygunton Oct 27, 2023

feat: adding structure to Transcript #2937

feat: adding structure to Transcript #2937

Conversation

lucasxia01 commented Oct 19, 2023 • edited Loading

AztecBot commented Oct 19, 2023 • edited Loading

Benchmark results

L2 block published to L1

L2 chain processing

Circuits stats

Miscellaneous

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codygunton left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lucasxia01 commented Oct 19, 2023 •

edited

Loading

AztecBot commented Oct 19, 2023 •

edited

Loading

codygunton left a comment •

edited

Loading