feat: Zeromorph with concatenation (Goblin Translator part 10)

[Rumata888]

Extends ZeroMorph to be able to handle concatenation (use commitments of several polynomials to represent a commitment to a polynomial constructed from their concatenation).

Checklist:

Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

• If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
• I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
• Every change is related to the PR description.
• I have linked this pull request to relevant issues (if any exist).

[AztecBot]

Benchmark results

Metrics with a significant change:

• l2_block_building_time_in_ms (8): 14,478 (-20%)
• l2_block_building_time_in_ms (32): 57,548 (-19%)
• l2_block_building_time_in_ms (128): 230,206 (-19%)
• l2_block_rollup_simulation_time_in_ms (8): 13,180 (-20%)
• l2_block_rollup_simulation_time_in_ms (32): 52,378 (-19%)
• l2_block_rollup_simulation_time_in_ms (128): 209,351 (-19%)
• l2_block_public_tx_process_time_in_ms (8): 1,261 (-19%)
• l2_block_public_tx_process_time_in_ms (32): 5,049 (-18%)
• l2_block_public_tx_process_time_in_ms (128): 20,408 (-18%)
• l2_block_processing_time_in_ms (8): 2,288 (-18%)
• l2_block_processing_time_in_ms (32): 8,706 (-17%)
• l2_block_processing_time_in_ms (128): 34,206 (-17%)
• note_successful_decrypting_time_in_ms (8): 282 (-18%)
• note_successful_decrypting_time_in_ms (32): 799 (-25%)
• note_successful_decrypting_time_in_ms (128): 2,930 (-26%)
• note_trial_decrypting_time_in_ms (8): 82.0 (+67%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 9b6be227 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	128 txs
l1_rollup_calldata_size_in_bytes	45,444	179,588	716,132
l1_rollup_calldata_gas	222,984	868,148	3,449,468
l1_rollup_execution_gas	842,071	3,595,256	22,204,837
l2_block_processing_time_in_ms	⚠️ 2,288 (-18%)	⚠️ 8,706 (-17%)	⚠️ 34,206 (-17%)
note_successful_decrypting_time_in_ms	⚠️ 282 (-18%)	⚠️ 799 (-25%)	⚠️ 2,930 (-26%)
note_trial_decrypting_time_in_ms	⚠️ 82.0 (+67%)	121 (+10%)	137 (-7%)
l2_block_building_time_in_ms	⚠️ 14,478 (-20%)	⚠️ 57,548 (-19%)	⚠️ 230,206 (-19%)
l2_block_rollup_simulation_time_in_ms	⚠️ 13,180 (-20%)	⚠️ 52,378 (-19%)	⚠️ 209,351 (-19%)
l2_block_public_tx_process_time_in_ms	⚠️ 1,261 (-19%)	⚠️ 5,049 (-18%)	⚠️ 20,408 (-18%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	24,862 (-1%)	48,677 (-1%)
note_history_successful_decrypting_time_in_ms	1,906 (-2%)	3,737 (-1%)
note_history_trial_decrypting_time_in_ms	122	146 (-1%)
node_database_size_in_bytes	1,631,047	1,098,424
pxe_database_size_in_bytes	27,188	54,187

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	82.0 (-9%)	61,697	18,841
private-kernel-ordering	50.6 (-9%)	24,233	8,089
base-rollup	2,083 (-9%)	656,309	811
root-rollup	89.2 (-7%)	4,072	1,097
private-kernel-inner	58.8 (-10%)	81,504	18,841
public-kernel-private-input	46.3 (-10%)	41,455	18,841
public-kernel-non-first-iteration	28.5 (-11%)	41,497	18,841
merge-rollup	0.841 (-23%)	2,592	873

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric	0 deployed contracts	1 deployed contracts
tx_size_in_bytes	8,723	27,240

[ledwards2225]

I made some updates to remove duplication from the ZeroMorph class. The concatenation component of the relevant methods is simply done in the standard methods as needed, as opposed to being done in separate but largely identical methods. I added notes throughout that identify these new components as being related to Goblin Translator implementation details. I'm not exactly familiar with how this quirk arises but hopefully there is good documentation of it somewhere. (ZM wouldn't be the right place for it anyway most likely). There is still a lot of duplication in the new test but I think at this point avoiding that duplication will not be worth the added complexity.

[codygunton]

I defer to @ledwards2225

[ledwards2225]

This is good to go. May need to make some minor adjustments when we go to fit this into the Translator. (As Kesha mentioned, this work only tests the new functionality in isolated tests).