refactor: leveraging Bufferable in pedersenHash(...) and sha256ToField(...)

[benesjan]

We had a ton of manual conversions to buffer when computing hashes. A few PRs ago I sneaked in a modification and pedersenHash(...) now accepts Bufferable[] instead of Buffer[]. In this PR I leverage this and remove the unnecessary conversions and do the same for sha256ToField(...).

[benesjan]

• refactor: renaming rand() as unsafe_rand() #5457
• refactor: timestamp as u64 instead of a Field #5453
• refactor: leveraging Bufferable in pedersenHash(...) and sha256ToField(...) #5444 👈
• fix: addressing flakiness of uniswap_trade_on_l1_from_l2.test.ts #5443
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @benesjan and the rest of your teammates on Graphite

[AztecBot]

Benchmark results

Metrics with a significant change:

• tx_sequencer_processing_time_ms (3): 1,691 (+16%)
• note_successful_decrypting_time_in_ms (8): 201 (-16%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 543f8a23 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	676	676	676
l1_rollup_calldata_gas	6,424	6,406	6,418
l1_rollup_execution_gas	585,757	585,739	585,751
l2_block_processing_time_in_ms	1,306 (-1%)	4,600 (-4%)	9,240 (+4%)
note_successful_decrypting_time_in_ms	⚠️ 201 (-16%)	558 (+11%)	978 (-3%)
note_trial_decrypting_time_in_ms	57.1 (+33%)	77.4 (-36%)	108 (-19%)
l2_block_building_time_in_ms	14,022 (+1%)	51,595	102,067
l2_block_rollup_simulation_time_in_ms	8,008	28,030	55,065 (-1%)
l2_block_public_tx_process_time_in_ms	5,992 (+1%)	23,512 (+1%)	46,907

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	14,198 (+3%)	27,304 (+1%)
note_history_successful_decrypting_time_in_ms	1,217 (-2%)	2,456 (-2%)
note_history_trial_decrypting_time_in_ms	62.4 (-30%)	148 (-27%)
node_database_size_in_bytes	18,653,264	35,045,456
pxe_database_size_in_bytes	29,859	59,414

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	237 (-1%)	44,379	28,214
private-kernel-ordering	209	52,880	14,296
base-parity	4,041 (+15%)	128	311
root-parity	1,382 (+5%)	1,244	311
base-rollup	17,296 (+3%)	165,760	861
root-rollup	49.8 (+1%)	4,359	725
private-kernel-inner	308 (-1%)	73,795	28,214
public-kernel-app-logic	126 (-1%)	35,252	28,217
public-kernel-tail	172	40,928	28,217
merge-rollup	8.49 (-5%)	2,568	861
public-kernel-teardown	133 (+12%)	35,252	28,217
public-kernel-setup	128 (+8%)	35,252	28,217

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves	32 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.0	15.9	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.6	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.583	0.493	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	46.6	72.0	232	444 (-1%)	868	1,718	N/A
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	96.0	159	543	1,055	2,079	4,127	N/A
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.478	0.445	0.422	0.416 (-1%)	0.414	0.412	N/A
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	54.5	107	341 (+2%)	664	1,307	2,600 (-1%)	N/A
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	104 (-1%)	207	691	1,363	2,707	5,395	N/A
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.482 (+1%)	0.481	0.462 (+1%)	0.458	0.454	0.453 (-1%)	N/A
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	61.6
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	109
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	0.539 (+1%)

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	14,968	495,185

Transaction size based on fee payment method

Metric	none fee payment method	native fee payment method	fpc_public fee payment method	fpc_private fee payment method
tx_with_fee_size_in_bytes	773	905	1,161	1,377

Transaction processing duration by data writes.

Metric	0 new note hashes	1 new note hashes	2 new note hashes
tx_pxe_processing_time_ms	2,221 (+7%)	1,400	4,807 (+4%)

Metric	0 public data writes	1 public data writes	2 public data writes	3 public data writes	4 public data writes	5 public data writes	8 public data writes
tx_sequencer_processing_time_ms	13.7 (+16%)	730	555 (+4%)	⚠️ 1,691 (+16%)	609 (+5%)	2,677 (+6%)	702 (+5%)

[benesjan]

The value here was incorrect. 0xffffffffffffffffffffffffffffffff is max value of 16 bytes, not 32.

[sklppy88]

lgtm

[benesjan]

Merge activity

• Mar 26, 1:28 PM EDT: @benesjan started a stack merge that includes this pull request via Graphite.