refactor: pedersen hash related cleanup in aztec.nr

[benesjan]

This PR is a hodgepodge of minor improvements which I did when I attempted at replacing all the use of pedersen with poseidon2 in my other PR.

In this PR I have:

1. Cleaned up some imports,
2. fixed some comments,
3. used separators correctly in shared mutable.

[benesjan]

• refactor: pedersen hash related cleanup in aztec.nr #8009 👈
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @benesjan and the rest of your teammates on Graphite

[AztecBot]

Benchmark results

Metrics with a significant change:

• avm_simulation_time_ms (Token:transfer_public): 20.6 (-49%)
• protocol_circuit_proving_time_in_ms (undefined): 82,969 (+23%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,769	1,557 (-1%)	707	772 (+4%)	772 (+1%)
proof_construction_time_sha256_30_ms	11,844	3,188	1,411	1,444 (-1%)	1,478
proof_construction_time_sha256_100_ms	45,438	11,990 (+1%)	5,466	5,435	5,393
proof_construction_time_poseidon_hash_ms	78.0	34.0	34.0	59.0	88.0 (+1%)
proof_construction_time_poseidon_hash_30_ms	1,529	423	203	223 (-2%)	266 (-1%)
proof_construction_time_poseidon_hash_100_ms	5,643	1,519	676	730 (-1%)	744

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	4,324	7,844	14,852
l1_rollup_calldata_gas	49,660	92,478	177,632
l1_rollup_execution_gas	1,294,323	2,042,109	3,869,302
l2_block_processing_time_in_ms	244 (-7%)	446 (+1%)	823
l2_block_building_time_in_ms	9,331	18,209	36,313
l2_block_rollup_simulation_time_in_ms	9,331	18,209	36,312
l2_block_public_tx_process_time_in_ms	7,901 (+1%)	16,657	34,714

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	3,077 (+4%)	3,895 (+2%)
node_database_size_in_bytes	12,652,624	16,773,200
pxe_database_size_in_bytes	16,254	26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	input_size_in_bytes	output_size_in_bytes	proving_time_in_ms
private-kernel-init	96.2 (-5%)	392	21,846	44,858	N/A
private-kernel-inner	171 (+2%)	694 (-4%)	72,545	45,005	N/A
private-kernel-reset-tiny	500 (-1%)	1,197	69,614	44,844	N/A
private-kernel-tail	270	195	50,760	52,256	N/A
base-parity	5.52	N/A	160	96.0	N/A
root-parity	33.1	N/A	69,084	96.0	N/A
base-rollup	2,850 (-1%)	N/A	187,817	664	N/A
root-rollup	38.4 (-1%)	N/A	54,525	716	N/A
public-kernel-setup	99.9	N/A	103,760	71,222	N/A
public-kernel-app-logic	106	N/A	103,599	71,222	N/A
public-kernel-tail	570	N/A	409,190	16,414	N/A
private-kernel-reset-small	481 (-5%)	N/A	66,533	45,629	N/A
private-kernel-tail-to-public	1,319 (-11%)	708	507,554	1,697	N/A
public-kernel-teardown	94.9 (-2%)	N/A	104,005	71,222	N/A
merge-rollup	19.1	N/A	35,742	664	N/A
undefined	N/A	N/A	N/A	N/A	⚠️ 82,969 (+23%)

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms
ContractClassRegisterer:register	1,344	11,731	345 (+1%)
ContractInstanceDeployer:deploy	1,408	11,731	18.1
MultiCallEntrypoint:entrypoint	1,920	11,731	424 (+1%)
FeeJuice:deploy	1,376	11,731	390
SchnorrAccount:constructor	1,312	11,731	104
SchnorrAccount:entrypoint	2,304	11,731	435 (+1%)
Token:privately_mint_private_note	1,280	11,731	144 (+4%)
FPC:fee_entrypoint_public	1,344	11,731	27.8 (+6%)
Token:transfer	1,312	11,731	281 (-2%)
Benchmarking:create_note	1,344	11,731	104
SchnorrAccount:verify_private_authwit	1,280	11,731	27.7 (-16%)
Token:unshield	1,376	11,731	552 (-2%)
FPC:fee_entrypoint_private	1,376	11,731	757 (+1%)

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
FeeJuice:_increase_public_balance	52.6 (-3%)	8,139
FeeJuice:set_portal	10.1 (+3%)	2,362
Token:constructor	80.3 (-4%)	31,107
FPC:constructor	52.9 (-3%)	22,380
FeeJuice:mint_public	37.5 (-19%)	6,150
Token:mint_public	71.3	11,720
Token:assert_minter_and_mint	40.4	8,028
AuthRegistry:set_authorized	35.4 (-22%)	4,537
FPC:prepare_fee	237	8,812
Token:transfer_public	⚠️ 20.6 (-49%)	47,374
FPC:pay_refund	54.9 (-19%)	12,114
Benchmarking:increment_balance	972	7,450
Token:_increase_public_balance	41.5 (+5%)	8,960
FPC:pay_refund_with_shielded_rebate	68.8 (+5%)	12,663

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.168 (+2%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	2.19 (+1%)	3.89 (+2%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.7	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.114 (+1%)	0.110 (+2%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	11.5 (-1%)	18.2 (-2%)	31.5 (-1%)	60.7 (+4%)	114 (-2%)
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.110 (-1%)	0.106 (-2%)	0.103	0.105 (+4%)	0.103
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	14.5 (+1%)	25.8	44.7 (+1%)	82.8 (+1%)	163 (+2%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	207	355	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.110 (+1%)	0.104 (-1%)	0.108	0.102	0.103 (+2%)
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	16.5	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	132	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.106 (+1%)	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	64,779	668,997

Transaction size based on fee payment method

| Metric | |
| - | |

[sklppy88]

Looks good !