refactor: public kernel

[LeilaWang]

Rearranging code for readability. No new features or bug fixes were added.
The gate count of public_kernel_app_logic increases a lot because of previous_kernel.verify, which was commented out before.

[github-actions]

Changes to circuit sizes

Generated at commit: 1a4dbdd6333e81f90893afb0b69b6e6b6cec6ab3, compared to commit: cee4ebaa9e53247d94882689d065c16a4c8e5bac

🧾 Summary (100% most significant diffs)

Program	ACIR opcodes (+/-)	%	Circuit size (+/-)	%
public_kernel_app_logic	-77,656 ✅	-26.41%	+1,199,429 ❌	+201.30%
public_kernel_tail	-426 ✅	-0.04%	-2,298 ✅	-0.02%
public_kernel_setup	-1,285 ✅	-0.60%	-38,756 ✅	-2.11%
public_kernel_teardown	-77,175 ✅	-26.20%	-118,498 ✅	-6.19%

---

Full diff report 👇

Program	ACIR opcodes (+/-)	%	Circuit size (+/-)	%
public_kernel_app_logic	216,339 (-77,656)	-26.41%	1,795,259 (+1,199,429)	+201.30%
public_kernel_tail	995,023 (-426)	-0.04%	9,373,298 (-2,298)	-0.02%
public_kernel_setup	214,252 (-1,285)	-0.60%	1,794,998 (-38,756)	-2.11%
public_kernel_teardown	217,364 (-77,175)	-26.20%	1,795,982 (-118,498)	-6.19%

[AztecBot]

Benchmark results

Metrics with a significant change:

• avm_simulation_time_ms (FeeJuice:set_portal): 11.4 (-43%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,783	1,565	704	762	773
proof_construction_time_sha256_30_ms	11,880	3,187	1,412	1,450 (-1%)	1,472
proof_construction_time_sha256_100_ms	45,483	12,090 (-1%)	5,430	5,379 (-2%)	5,381
proof_construction_time_poseidon_hash_ms	79.0	34.0	34.0	61.0 (+5%)	89.0 (+2%)
proof_construction_time_poseidon_hash_30_ms	1,537	424	203	226 (-2%)	277 (+3%)
proof_construction_time_poseidon_hash_100_ms	5,667	1,516	678 (+1%)	731	754

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	4,324	7,844	14,852
l1_rollup_calldata_gas	49,756	92,394	177,572
l1_rollup_execution_gas	1,383,250	2,130,856	3,958,073
l2_block_processing_time_in_ms	258 (+2%)	445 (-1%)	822
l2_block_building_time_in_ms	9,148 (-1%)	17,879 (-1%)	35,686 (-1%)
l2_block_rollup_simulation_time_in_ms	9,148 (-1%)	17,879 (-1%)	35,686 (-1%)
l2_block_public_tx_process_time_in_ms	7,739 (-1%)	16,331 (-2%)	34,132 (-1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	2,921 (-3%)	3,802 (-2%)
node_database_size_in_bytes	12,664,912	16,781,392
pxe_database_size_in_bytes	16,254	26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	input_size_in_bytes	output_size_in_bytes	proving_time_in_ms
private-kernel-init	95.1 (-2%)	401 (+4%)	21,673	44,858	N/A
private-kernel-inner	163 (-1%)	719 (+1%)	72,309	45,005	N/A
private-kernel-reset-tiny	502	919 (+5%)	65,974	44,844	N/A
private-kernel-tail	208	171 (+7%)	50,728	52,256	N/A
base-parity	5.56 (+1%)	N/A	160	96.0	N/A
root-parity	33.5 (+1%)	N/A	69,084	96.0	N/A
base-rollup	2,820 (-1%)	N/A	187,817	664	N/A
root-rollup	38.9 (+1%)	N/A	54,525	716	N/A
public-kernel-setup	88.4 (-9%)	N/A	103,760	71,222	N/A
public-kernel-app-logic	98.7 (-5%)	N/A	103,599	71,222	N/A
public-kernel-tail	574	N/A	409,190	16,414	N/A
private-kernel-reset-small	493	N/A	66,085	45,629	N/A
private-kernel-tail-to-public	1,063 (-10%)	668 (+5%)	492,960	1,697	N/A
public-kernel-teardown	86.4 (-6%)	N/A	104,005	71,222	N/A
merge-rollup	19.2 (-1%)	N/A	35,742	664	N/A
undefined	N/A	N/A	N/A	N/A	65,419 (-2%)

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms
ContractClassRegisterer:register	1,344	11,731	341
ContractInstanceDeployer:deploy	1,408	11,731	18.3
MultiCallEntrypoint:entrypoint	1,920	11,731	420
FeeJuice:deploy	1,376	11,731	396 (+2%)
SchnorrAccount:constructor	1,312	11,731	105 (+2%)
SchnorrAccount:entrypoint	2,304	11,731	431
Token:privately_mint_private_note	1,280	11,731	138 (-3%)
FPC:fee_entrypoint_public	1,344	11,731	29.5 (+3%)
Token:transfer	1,312	11,731	283 (+1%)
Benchmarking:create_note	1,344	11,731	100
SchnorrAccount:verify_private_authwit	1,280	11,731	27.7
Token:unshield	1,376	11,731	561 (+1%)
FPC:fee_entrypoint_private	1,376	11,731	757

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
FeeJuice:_increase_public_balance	55.0 (+20%)	8,139
FeeJuice:set_portal	⚠️ 11.4 (-43%)	2,362
Token:constructor	86.1 (+3%)	31,107
FPC:constructor	54.0	22,380
FeeJuice:mint_public	39.1 (+2%)	6,150
Token:mint_public	43.0 (+2%)	11,720
Token:assert_minter_and_mint	66.4 (-1%)	8,028
AuthRegistry:set_authorized	45.5 (+29%)	4,537
FPC:prepare_fee	257 (+5%)	8,812
Token:transfer_public	27.8 (+14%)	47,358
FPC:pay_refund	59.8 (+8%)	12,082
Benchmarking:increment_balance	958 (-1%)	7,450
Token:_increase_public_balance	39.8 (-9%)	8,960
FPC:pay_refund_with_shielded_rebate	67.7 (-4%)	12,631

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.157 (-3%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	2.19 (+1%)	3.93 (+1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.7	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.114 (+1%)	0.112 (+2%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	11.6 (+1%)	18.0 (+1%)	31.1 (-1%)	59.9	113 (-2%)
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.112 (+1%)	0.104 (+1%)	0.101 (-1%)	0.103 (-1%)	0.101 (-1%)
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	14.6 (+2%)	25.8 (-1%)	44.1 (+1%)	83.5 (-1%)	161 (-1%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	207	355	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.111 (+2%)	0.104	0.107 (+1%)	0.103 (-1%)	0.101 (-1%)
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	16.5 (+1%)	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	132	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.106 (+1%)	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	64,779	668,997

Transaction size based on fee payment method

| Metric | |
| - | |

[sirasistant]

🙈