Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev/markonikolic/aliasswagger #18006

Conversation

markonikolicmicrosoft
Copy link
Contributor

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

Alancere and others added 30 commits January 14, 2022 16:21
)

* [Go] Add track2 config:elastic,resourcemover

* Add policyinsights

* policyinsights add modelerfour.lenient-model-deduplication
Azure#17270)

* Add Immutable property for Release Policy, remove Export operation for 7.3-preview

* Fix grammar in description

Co-authored-by: Heath Stewart <heaths@outlook.com>
* make client name guids and rest name guid

* fix list docstring

* update example for list by guids

* link examples

* revert changes to package lock

* fix json in example

* switch to rest name for guid param in examples
…ma named 'ErrorResponse' (Azure#17362)

* [Go] resources/armsubscriptiions add directive fox fix Duplicate Schema named 'ErrorResponse'

* appservice stuttering
* add x-ms-enum for peering

* remove the redundant default tags in readme.md
Co-authored-by: Bogdan Ostojic <bostojic@microsoft.com>
* adding new api version

* updating version and adding new apis

* adding apis

* swagger fixes

* prettier fix

* adding api version for operations api

* adding api versions param for operatiosn for previous and stable version

Co-authored-by: Gaurav Bang <gauravbang@microsoft.com>
* Updated SubscriptionRP v2020-09-01 for s360

* Model validation errors are fixed

Co-authored-by: Ochi <ochisamand@microsoft.com>
Azure#17401)

Co-authored-by: swagger-automation <swagger@microsoft.com>
* compute folder with pre-population

* fix examples folder

* fix an example file

* update compute to match last version

* run prettier fix examples

* change capitalization

* Compute Swagger changes to include cross-region Restore Points scenarios (Azure#16570)

* RRP changes in swagger

* Fix conflicts

* fix validations

* Fix instance view

* Revert "Compute Swagger changes to include cross-region Restore Points scenarios (Azure#16570)" (Azure#16663)

This reverts commit 70a8729.

* sync with last version

* add missing examples

* suppress bodyTopLevelProperties

* Add VMSS filter to List VMs (Azure#16813)

* change1 for change file

* change description

* change description

* add suppression for required properties

* Revert "Add VMSS filter to List VMs (Azure#16813)" (Azure#16956)

This reverts commit 231fd22.

* Remove impossible state from example (Azure#16544)

* Downmerging change from Azure:main (Azure#16654)

Co-authored-by: Avinash Akka <avakka@microsoft.com>

* Added CVM settings for version 2021-11-01 (Azure#16622)

* Added CVM settings

* added examples

* Add CMK examples

* fixed typo

* fixed file name

* prettier check

* removed a br

* changed to VMDiskSecurityProfile

* type as object

* Added vm size properties for vm scale set (Azure#16723)

* Added vm size properties

* Added get examples

* Added example for vm size properties

* Added example for vm size properties

Co-authored-by: Theodore Chang <thchan@microsoft.com>

* Spec for ProtectedSettingsFromKeyVault and AllowExtensionOperations (Azure#16590)

* KV changes

* adding allowExtensionOperation

* fixing examples

* Add repairAction to auto repairs feature and update grace period to PT10M (Azure#16535)

* Add timeCreated to properties for VM, VMSS, CR, DH resources (Azure#16539)

* add creationTime to properties for VM, VMSS, CR, DH resources + remove
required location for Resources

* rename creationTime to timeCreated

* examples for timeCreated

* add minimum api-version to descriptions for timeCreated

* add GetVirtualMachineScaleSet example

* reformat example

Co-authored-by: Chase Van Buskirk <cvanbuskirk@microsoft.com>

* DedicatedHost Reboot Feature (Azure#16737)

* added new feature to compute.json

* added example for my feature

* prettier check on the reboot example

* fixed names of parameters in example file:

* changed name to DedicatedHosts_reboot and moved change to where the other DH APIs are

* added cloud error to the reboot

* fixed default error, it was in the wrong spot

* moved reboot to end of specs

* moved older swagger files to 2021-11-01

* reverted previous commit

* renamed reboot to restart as per sameers comment

* updated description as per sameers comment

* updated api version to 2021-11-01 per sameers comment

* Adding the new paramaters zone/placementGroupId to forceRecoveryServiceFabricPlatformUpdateDomainWalk VMSS API (Azure#17041)

* save (Azure#17091)

Co-authored-by: Theodore Chang <thchan@microsoft.com>

* Update compute.json (Azure#16482)

When a customer tries to scale VMSS using Terraform, since the current definitions do not have publicIpPrefix property, the new VM will be assigned a random IP address which is outside the range of public Ip prefix. Customer has to resolve the issue by deleting the Vmss and recreating it. This PR tries to resolve the issue by adding the publicIpPrefix property in the JSON definition which is used to generate a request for VMSS update.

More details about the issue can be found here - Azure#10190

* add vmss filter to list  (Azure#16957)

* change1 for change file

* change description

* change description

Co-authored-by: LexieXie <lexiexie@microsoft.com>

* move Kashif's change to 2021-11-01

* Revert "Spec for ProtectedSettingsFromKeyVault and AllowExtensionOperations (Azure#16590)" (Azure#17121)

This reverts commit 220cfd0.

* fix CI failures, and run prettier on added examples

* for credscan. change password example

* Update readme.python.md

* Compute Swagger changes to include cross-region Restore Points scenarios (Azure#16682)

* RRP changes in swagger

* Fix conflicts

* fix validations

* Fix instance view

* change instance view

* Fix example

* Fix prettier

* Fix and modify description

* Review comments

* make new api call long-running-operation

* compute folder with pre-population

* fix examples folder

* fix an example file

* update compute to match last version

* run prettier fix examples

* change capitalization

* Compute Swagger changes to include cross-region Restore Points scenarios (Azure#16570)

* RRP changes in swagger

* Fix conflicts

* fix validations

* Fix instance view

* Revert "Compute Swagger changes to include cross-region Restore Points scenarios (Azure#16570)" (Azure#16663)

This reverts commit 70a8729.

* sync with last version

* add missing examples

* Add VMSS filter to List VMs (Azure#16813)

* change1 for change file

* change description

* change description

* Revert "Add VMSS filter to List VMs (Azure#16813)" (Azure#16956)

This reverts commit 231fd22.

* Remove impossible state from example (Azure#16544)

* Added CVM settings for version 2021-11-01 (Azure#16622)

* Added CVM settings

* added examples

* Add CMK examples

* fixed typo

* fixed file name

* prettier check

* removed a br

* changed to VMDiskSecurityProfile

* type as object

* Added vm size properties for vm scale set (Azure#16723)

* Added vm size properties

* Added get examples

* Added example for vm size properties

* Added example for vm size properties

Co-authored-by: Theodore Chang <thchan@microsoft.com>

* Spec for ProtectedSettingsFromKeyVault and AllowExtensionOperations (Azure#16590)

* KV changes

* adding allowExtensionOperation

* fixing examples

* Add repairAction to auto repairs feature and update grace period to PT10M (Azure#16535)

* Add timeCreated to properties for VM, VMSS, CR, DH resources (Azure#16539)

* add creationTime to properties for VM, VMSS, CR, DH resources + remove
required location for Resources

* rename creationTime to timeCreated

* examples for timeCreated

* add minimum api-version to descriptions for timeCreated

* add GetVirtualMachineScaleSet example

* reformat example

Co-authored-by: Chase Van Buskirk <cvanbuskirk@microsoft.com>

* DedicatedHost Reboot Feature (Azure#16737)

* added new feature to compute.json

* added example for my feature

* prettier check on the reboot example

* fixed names of parameters in example file:

* changed name to DedicatedHosts_reboot and moved change to where the other DH APIs are

* added cloud error to the reboot

* fixed default error, it was in the wrong spot

* moved reboot to end of specs

* moved older swagger files to 2021-11-01

* reverted previous commit

* renamed reboot to restart as per sameers comment

* updated description as per sameers comment

* updated api version to 2021-11-01 per sameers comment

* Adding the new paramaters zone/placementGroupId to forceRecoveryServiceFabricPlatformUpdateDomainWalk VMSS API (Azure#17041)

* save (Azure#17091)

Co-authored-by: Theodore Chang <thchan@microsoft.com>

* Update compute.json (Azure#16482)

When a customer tries to scale VMSS using Terraform, since the current definitions do not have publicIpPrefix property, the new VM will be assigned a random IP address which is outside the range of public Ip prefix. Customer has to resolve the issue by deleting the Vmss and recreating it. This PR tries to resolve the issue by adding the publicIpPrefix property in the JSON definition which is used to generate a request for VMSS update.

More details about the issue can be found here - Azure#10190

* add vmss filter to list  (Azure#16957)

* change1 for change file

* change description

* change description

Co-authored-by: LexieXie <lexiexie@microsoft.com>

* move Kashif's change to 2021-11-01

* fix CI failures, and run prettier on added examples

* Revert "Spec for ProtectedSettingsFromKeyVault and AllowExtensionOperations (Azure#16590)" (Azure#17121)

This reverts commit 220cfd0.

* for credscan. change password example

* make new api call long-running-operation

* Update readme.python.md

* Compute Swagger changes to include cross-region Restore Points scenarios (Azure#16682)

* RRP changes in swagger

* Fix conflicts

* fix validations

* Fix instance view

* change instance view

* Fix example

* Fix prettier

* Fix and modify description

* Review comments

* update Repair action to enum and update readme

* rebase to main since 2021-08-01 merged. update readme

* update x-ms-enum name for RepairType

* add default response to operations

* update

* put back 'required' tag for Resource.Location property
and use a new object for VM_LIST return object

* fix json format

* update examples

* run prettier on updated examples

* update example for credScan

* add VirtualMachineResource for toplevel property suppression.

* lint diff errors

* lint diff fix update

* remove change for VMextensions.location bug

* return readme file and examples before vm.vmextension.location change

Co-authored-by: sukodava <78733210+sukodava@users.noreply.github.com>
Co-authored-by: Dapeng Zhang <dapzhang@microsoft.com>
Co-authored-by: xielexie <94083876+xielexie@users.noreply.github.com>
Co-authored-by: Mike Richmond <mirichmo@microsoft.com>
Co-authored-by: Avinash <akka@usc.edu>
Co-authored-by: Avinash Akka <avakka@microsoft.com>
Co-authored-by: ms-saypaul <67093296+ms-saypaul@users.noreply.github.com>
Co-authored-by: Raktima Das <raktdas@microsoft.com>
Co-authored-by: kamusta-msft <56413142+kamusta-msft@users.noreply.github.com>
Co-authored-by: frank-pang-msft <92764154+frank-pang-msft@users.noreply.github.com>
Co-authored-by: Chase VanBuskirk <chasevanb@gmail.com>
Co-authored-by: Chase Van Buskirk <cvanbuskirk@microsoft.com>
Co-authored-by: vbhasker-msft <93355049+vbhasker-msft@users.noreply.github.com>
Co-authored-by: avjai <34567499+avjai@users.noreply.github.com>
Co-authored-by: kangsun-ctrl <69279251+kangsun-ctrl@users.noreply.github.com>
Co-authored-by: karthikka4820 <88366202+karthikka4820@users.noreply.github.com>
Co-authored-by: LexieXie <lexiexie@microsoft.com>
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
* Add blockchain to latest profile

* Add additional types

* Add ResourceType enum value

* Update ResourceType modelAsString

Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
Co-authored-by: Chenglong Liu <chengll@microsoft.com>
* 2021/08/05 Add Tropical api

* 2021/11/18 Add air quality api

* 2021/11/18 Add Historical api

* 2021/11/22 Update enum and add x-ms-client-name

* 2021/11/23 Update examples

* 2021/11/23 Update naming

* 2021/11/23 Create parameter for Position

* 2021/11/23 Update active storm

* 2021/11/30 Change reponse to result

* 2021/11/30 Add x-ms-client-name

* 2021/11/30 Update timestamp, coordinate, and radius naming in SDK

* 2021/11/30 Use WeatherUnit for Concentration

* 2021/11/30 Update Daily Air quality dominantPollutant

* 2021/11/30 Unify response format

* 2021/11/30 Unify CurrentAirQuality and HourlyAirQualityForecast

* 2021/12/01 Update window and weatherValue SDK name

* 2021/12/02 Update coordinate and left, right SDK name

* 2021/12/03 Add SDK name for results

* 2021/12/03 Improve Object name

* 2021/12/03 Update ActiveStorm

* 2021/12/03 Remove needless object and update name

* 2021/12/06 Add weather 2.0 directory

* 2021/12/06 Recover Weather 1.0 Swagger file

* 2021/12/07 Remove v2 from operationId

* 2021/12/08 Update readme.md

* Set default API version as 2.0

* 2022/01/07 Remove default value for api-version

* 2022/01/07 Remove needless custom-words

* 2022/01/11 Update api-version and add nextLink

* 2022/01/11 Update api-version in readme.md

Co-authored-by: John Lai <tingchiehlai@microsoft.com>
Co-authored-by: evaou <speeder528@gmail.com>
…ional data model fields as nullable (Azure#17388)

* Update data-plane configurations

* Update Job Cost Estimate field description

* Add basic-setup-py: true

* Add generate-metadata: true

* Fix Python readme.md settings

* Update Typescript config

* Remove payload flatenning

* Disable client-side validation

* Allow job metadata to be null

* Allow metadata to be null

* Rollback

* Mark fields as nullable

* Remove C# client-validation parameter

Co-authored-by: XField <victor.xfield@microsoft.com>
* Updating tag

* Update readme.go.md

* Update readme.go.md

* Update readme.java.md

* Update readme.go.md

* Update readme.python.md

* Update readme.python.md

adjusting version
…sion preview/2021-11-16-preview (Azure#17200)

* Adds base for updating Microsoft.Authorization from version preview/2021-07-01-preview to version 2021-11-16-preview

* Updates readme

* Updates API version in new specs and examples

* Adding access review history definition models and methods

* Semantic validation fixes

* Fix linting issues

* Uneeded pagable

* More linter fixes

* More linter issue fixes

* Ran prettier

* Ran prettier

* Lint and model validation fixes

* Adding nextlink

* Fix broken SDK

* Revert "Fix broken SDK"

This reverts commit 040d220.

* Make generating a downloadable uri a post instead of patch

* Making generateDownloadUri it's own api

* Adding delete history definition by Id

* Added post per instance and added body to Put

* Fixing validation errors

* downloadUri readonly and only returned by POST
Azure#17333)

* Initial commit with 2021-11-01 api version

* New api-version 2021-12-01 in ASR

* Add readme.md changes
* Update readme.python.md

* Update readme.python.md

* Update readme.python.md

* Update readme.md

* Update readme.java.md

* Update readme.go.md

* Update readme.md

* Remove multiapi

* Update readme.md

* Update readme.python.md

Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
…sion for servicebus (Azure#17389)

* Fix the defaultaction and publicnetworkaccess property in 2021-11 version for servicebus

* Add publicnetworkaccess to create response
* add base api to new version folder for reviewer reference

* add chenges for new api versiongit add .

* adding changes for new api version

* removing extra files left over from PR fix

* fixing xmsIdentifierValidation errors

* checks not running, changing text to retrigger

* checks not running, changing text to retrigger

* adding force delete and recursive delete parameters

* add missing x-mx-paramter-location attributes, and fix warnings

* adding force delete and recursive delete parameters

* adding force delete and recursive delete parameters

Co-authored-by: Jared Gorthy <jaredgorthy@microsoft.com>
…version stable/2021-12-01 (Azure#17271)

* Adds base for updating Microsoft.RecoveryServices from version stable/2021-10-01 to version 2021-12-01

* Updates readme

* Updates API version in new specs and examples

* - Adding support for creation of new 'Enhanced' policy for IaaSVM backup
- This policy type will additionally support hourly backups along with daily and weekly supported by current policy
- Added respective examples for create/update, Get and List policy api

* - prettier fixes

* updating readme.md to new api

* - correcting the path of new example files

* - fixing examples

* - more fixes in examples

* fixing spell check error

* fixing semantic errors

* - semantic errors fix
This was referenced Feb 25, 2022
This was referenced Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-FixRequiredOnFailure customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
None yet
Development

Successfully merging this pull request may close these issues.