-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add connectionResourceUri To Circuit Authorization #29235
Merged
jianzhao1992
merged 2 commits into
Azure:release-network-Microsoft.Network-2024-01-01
from
nimaller:connectionUriAuth
Jun 18, 2024
Merged
Add connectionResourceUri To Circuit Authorization #29235
jianzhao1992
merged 2 commits into
Azure:release-network-Microsoft.Network-2024-01-01
from
nimaller:connectionUriAuth
Jun 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge. |
Swagger Validation Report
|
Compared specs (v0.10.9) | new version | base version |
---|---|---|
expressRouteCircuit.json | 2024-01-01(05c9a1d) | 2023-11-01(main) |
️⚠️
LintDiff: 0 Warnings warning [Detail]
Compared specs (v2.2.2) | new version | base version |
---|---|---|
package-2024-01 | package-2024-01(05c9a1d) | package-2024-01(release-network-Microsoft.Network-2024-01-01) |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
Rule | Message |
---|---|
ResourceNameRestriction |
The resource name parameter 'circuitName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2024-01-01/expressRouteCircuit.json#L37 |
ResourceNameRestriction |
The resource name parameter 'authorizationName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2024-01-01/expressRouteCircuit.json#L37 |
DeleteResponseCodes |
Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.Network/stable/2024-01-01/expressRouteCircuit.json#L38 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.Network/stable/2024-01-01/expressRouteCircuit.json#L74 |
ResourceNameRestriction |
The resource name parameter 'circuitName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2024-01-01/expressRouteCircuit.json#L230 |
ResourceNameRestriction |
The resource name parameter 'circuitName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2024-01-01/expressRouteCircuit.json#L283 |
ResourceNameRestriction |
The resource name parameter 'peeringName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2024-01-01/expressRouteCircuit.json#L283 |
DeleteResponseCodes |
Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.Network/stable/2024-01-01/expressRouteCircuit.json#L284 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.Network/stable/2024-01-01/expressRouteCircuit.json#L323 |
ResourceNameRestriction |
The resource name parameter 'circuitName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2024-01-01/expressRouteCircuit.json#L476 |
ResourceNameRestriction |
The resource name parameter 'circuitName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2024-01-01/expressRouteCircuit.json#L529 |
ResourceNameRestriction |
The resource name parameter 'peeringName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2024-01-01/expressRouteCircuit.json#L529 |
ResourceNameRestriction |
The resource name parameter 'connectionName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2024-01-01/expressRouteCircuit.json#L529 |
DeleteResponseCodes |
Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.Network/stable/2024-01-01/expressRouteCircuit.json#L530 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.Network/stable/2024-01-01/expressRouteCircuit.json#L576 |
ResourceNameRestriction |
The resource name parameter 'circuitName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2024-01-01/expressRouteCircuit.json#L743 |
ResourceNameRestriction |
The resource name parameter 'peeringName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2024-01-01/expressRouteCircuit.json#L743 |
ResourceNameRestriction |
The resource name parameter 'circuitName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2024-01-01/expressRouteCircuit.json#L803 |
ResourceNameRestriction |
The resource name parameter 'peeringName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2024-01-01/expressRouteCircuit.json#L803 |
ResourceNameRestriction |
The resource name parameter 'connectionName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2024-01-01/expressRouteCircuit.json#L803 |
ResourceNameRestriction |
The resource name parameter 'circuitName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2024-01-01/expressRouteCircuit.json#L867 |
ResourceNameRestriction |
The resource name parameter 'peeringName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2024-01-01/expressRouteCircuit.json#L867 |
ResourceNameRestriction |
The resource name parameter 'circuitName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2024-01-01/expressRouteCircuit.json#L927 |
DeleteResponseCodes |
Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.Network/stable/2024-01-01/expressRouteCircuit.json#L928 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.Network/stable/2024-01-01/expressRouteCircuit.json#L960 |
PathForResourceAction |
Path for 'post' method on a resource type MUST follow valid resource naming. Location: Microsoft.Network/stable/2024-01-01/expressRouteCircuit.json#L1159 |
ResourceNameRestriction |
The resource name parameter 'circuitName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2024-01-01/expressRouteCircuit.json#L1159 |
ResourceNameRestriction |
The resource name parameter 'peeringName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2024-01-01/expressRouteCircuit.json#L1159 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.Network/stable/2024-01-01/expressRouteCircuit.json#L1209 |
PathForResourceAction |
Path for 'post' method on a resource type MUST follow valid resource naming. Location: Microsoft.Network/stable/2024-01-01/expressRouteCircuit.json#L1230 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
SwaggerAPIView succeeded [Detail] [Expand]
️️✔️
TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️⌛
PR Summary pending [Detail]
️️✔️
Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
This was referenced May 24, 2024
AzureRestAPISpecReview
added
ARMReview
resource-manager
WaitForARMFeedback
<valid label in PR review process> add this label when ARM review is required
labels
May 24, 2024
GuptaVertika
force-pushed
the
connectionUriAuth
branch
from
May 30, 2024 03:54
d41a683
to
fb7428b
Compare
rkmanda
added
the
ARMSignedOff
<valid label in PR review process>add this label when ARM approve updates after review
label
Jun 8, 2024
openapi-pipeline-app
bot
removed
the
WaitForARMFeedback
<valid label in PR review process> add this label when ARM review is required
label
Jun 8, 2024
/pr RequestMerge |
mentat9
approved these changes
Jun 18, 2024
@nimaller - You should be able to merge this PR yourself. ARM reviewers don't have control over your release branch: we only merge PRs to main and RPSaaSMaster. You may need to update your branch from base first. |
jianzhao1992
merged commit Jun 18, 2024
73d9086
into
Azure:release-network-Microsoft.Network-2024-01-01
23 of 29 checks passed
jianzhao1992
pushed a commit
that referenced
this pull request
Jun 18, 2024
rkmanda
pushed a commit
that referenced
this pull request
Jun 19, 2024
…29302) * Adds base for updating Microsoft.Network from version stable/2023-11-01 to version 2024-01-01 * Updates readme * Updates API version in new specs and examples * Add examples for Subnet peering and v6 Subnet peering. (#28827) Add examples for Subnet peering and v6 Subnet peering. --------- Co-authored-by: saurabh83 <saugu@microsoft.com> * Init (#29127) Co-authored-by: Abhishek Shah <shabhis@microsoft.com> * Adding the new response code to the 2024-01-01 version release of swagger to match the bugfix in 2023-11-01 (#29048) Co-authored-by: Arsheen Khatib (from Dev Box) <akhatib@microsoft.com> * Added NoHealthyBackendsBehavior (#28868) Added the property "NoHealthyBackendsBehavior" to the Probe properties. * VirtualNetworkGatewayConnection using key vault for authentication. (#28760) * Add parameters for cert based auth connection * retrigger checks * retrigger checks * lintDiff * Trigger Build * revert PATCH changes * fix * change managed identity to v5 * add format and description * rresolving conflict * resolving readme file * Revert "VirtualNetworkGatewayConnection using key vault for authentication. (#28760)" This reverts commit c37ec24. * Lint diff error suppress * Guptavertika/release network microsoft.network official 2024 01 01 (#29367) * added networkidentifier under vnet->subet->serviceendpoint * added format :armid and updated description * corrected the type * fixed response * response type fixed example --------- Co-authored-by: Bhupesh Bhatt <bhupeshbhatt@microsoft.com> * Adding GET operaton for Network Virtual Appliance Inbound Secuirty Rule (#29339) (#29375) * Fix for PR VirtualNetworkGatewayConnection using key vault for authentication. (#29357) (#29376) * Fix * Fix2 --------- Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com> * Add CrossConnection Name as an optional query parameter in List ExpressRoute CrossConnection (#29251) * Add CrossConnection name as an optional query parameter for List CrossConnection * update example * Addressing comments * Change to OData filtering * Fix the parameter reference * Update --------- Co-authored-by: Jianqi Zhao <jianzhao@microsoft.com> * initial changes (#29235) * Changed type of networkIdentifier from PublicIPAddress to SubResource (#29469) * added networkidentifier under vnet->subet->serviceendpoint * added format :armid and updated description * corrected the type * fixed response * response type fixed example * Changed type of networkIdentifier from ./publicIpAddress.json#/definitions/PublicIPAddress to ./network.json#/definitions/SubResource --------- Co-authored-by: Bhupesh Bhatt <bhupeshbhatt@microsoft.com> --------- Co-authored-by: saurabh83 <splitt@gmail.com> Co-authored-by: saurabh83 <saugu@microsoft.com> Co-authored-by: Abhishek Shah <16267081+abhi7860@users.noreply.github.com> Co-authored-by: Abhishek Shah <shabhis@microsoft.com> Co-authored-by: AFK1194 <arsheen.khatib@gmail.com> Co-authored-by: Arsheen Khatib (from Dev Box) <akhatib@microsoft.com> Co-authored-by: Eugenio Peña García <70240915+EugenioPena@users.noreply.github.com> Co-authored-by: daweiwang-microsoft <165709729+daweiwang-microsoft@users.noreply.github.com> Co-authored-by: Bhupesh Kumar Bhatt <52891188+bhupeshbhatt1985@users.noreply.github.com> Co-authored-by: Bhupesh Bhatt <bhupeshbhatt@microsoft.com> Co-authored-by: Ashutosh Mishra <163998769+ashutmi@users.noreply.github.com> Co-authored-by: Khushboo Baheti <37917868+Khushboo-Baheti@users.noreply.github.com> Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com> Co-authored-by: jianzhao1992 <125631957+jianzhao1992@users.noreply.github.com> Co-authored-by: Jianqi Zhao <jianzhao@microsoft.com> Co-authored-by: nimaller <71352534+nimaller@users.noreply.github.com>
mentat9
pushed a commit
that referenced
this pull request
Jun 21, 2024
#29473) * Adds base for updating Microsoft.Network from version stable/2023-11-01 to version 2024-01-01 * Updates readme * Updates API version in new specs and examples * Add examples for Subnet peering and v6 Subnet peering. (#28827) Add examples for Subnet peering and v6 Subnet peering. --------- Co-authored-by: saurabh83 <saugu@microsoft.com> * Init (#29127) Co-authored-by: Abhishek Shah <shabhis@microsoft.com> * Adding the new response code to the 2024-01-01 version release of swagger to match the bugfix in 2023-11-01 (#29048) Co-authored-by: Arsheen Khatib (from Dev Box) <akhatib@microsoft.com> * Added NoHealthyBackendsBehavior (#28868) Added the property "NoHealthyBackendsBehavior" to the Probe properties. * VirtualNetworkGatewayConnection using key vault for authentication. (#28760) * Add parameters for cert based auth connection * retrigger checks * retrigger checks * lintDiff * Trigger Build * revert PATCH changes * fix * change managed identity to v5 * add format and description * added networkidentifier under vnet->subet->serviceendpoint (#29292) * added networkidentifier under vnet->subet->serviceendpoint * resolving conflict (#29343) * Fix for PR VirtualNetworkGatewayConnection using key vault for authentication. (#29357) * Fix * Fix2 --------- Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com> * Adding GET operaton for Network Virtual Appliance Inbound Secuirty Rule (#29339) * Moving missed changes from 2023-11-01 packet capture swagger fix to latest api version * Add CrossConnection Name as an optional query parameter in List ExpressRoute CrossConnection (#29251) * Add CrossConnection name as an optional query parameter for List CrossConnection * update example * Addressing comments * Change to OData filtering * Fix the parameter reference * Update --------- Co-authored-by: Jianqi Zhao <jianzhao@microsoft.com> * initial changes (#29235) * adding supression for the breaking change in azure-sdk-for-go * adding correct package for this supression --------- Co-authored-by: GuptaVertika <149072034+GuptaVertika@users.noreply.github.com> Co-authored-by: saurabh83 <splitt@gmail.com> Co-authored-by: saurabh83 <saugu@microsoft.com> Co-authored-by: Abhishek Shah <16267081+abhi7860@users.noreply.github.com> Co-authored-by: Abhishek Shah <shabhis@microsoft.com> Co-authored-by: AFK1194 <arsheen.khatib@gmail.com> Co-authored-by: Arsheen Khatib (from Dev Box) <akhatib@microsoft.com> Co-authored-by: Eugenio Peña García <70240915+EugenioPena@users.noreply.github.com> Co-authored-by: daweiwang-microsoft <165709729+daweiwang-microsoft@users.noreply.github.com> Co-authored-by: Bhupesh Kumar Bhatt <52891188+bhupeshbhatt1985@users.noreply.github.com> Co-authored-by: Khushboo Baheti <37917868+Khushboo-Baheti@users.noreply.github.com> Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com> Co-authored-by: Ashutosh Mishra <163998769+ashutmi@users.noreply.github.com> Co-authored-by: jianzhao1992 <125631957+jianzhao1992@users.noreply.github.com> Co-authored-by: Jianqi Zhao <jianzhao@microsoft.com> Co-authored-by: nimaller <71352534+nimaller@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ARMReview
ARMSignedOff
<valid label in PR review process>add this label when ARM approve updates after review
resource-manager
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add connection resource uri to circuit authorization to indicate by which connection the auth is used.
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
New resource provider.
New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix OpenAPI spec quality issues in S360.
Other, please clarify:
Add new property. Add connection resource uri to circuit authorization to indicate by which connection the auth is used.
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
Suppressing failures
Getting help
First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.