Changed type of networkIdentifier from PublicIPAddress to SubResource #29469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ficial-2024-01-01' into guptavertika/release-network-Microsoft.Network-official-2024-01-01
…tions/PublicIPAddress to ./network.json#/definitions/SubResource
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge. |
Swagger Validation Report
|
| Compared specs (v0.10.9) | new version | base version |
|---|---|---|
| virtualNetwork.json | 2024-01-01(c9666b4) | 2023-11-01(main) |
️⚠️LintDiff: 0 Warnings warning [Detail]
| Compared specs (v2.2.2) | new version | base version |
|---|---|---|
| package-2024-01 | package-2024-01(c9666b4) | package-2024-01(guptavertika/release-network-Microsoft.Network-official-2024-01-01) |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The resource name parameter 'virtualNetworkName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2024-01-01/virtualNetwork.json#L37 |
|
Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.Network/stable/2024-01-01/virtualNetwork.json#L38 |
|
A 202 response should include an Location response header. Location: Microsoft.Network/stable/2024-01-01/virtualNetwork.json#L67 |
|
Query parameter $expand should be removed. Point Get's MUST not have query parameters other than api version. Location: Microsoft.Network/stable/2024-01-01/virtualNetwork.json#L99 |
|
A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'VirtualNetworks_CreateOrUpdate' Request Model: 'parameters[2].schema' Response Model: 'responses[200].schema' Location: Microsoft.Network/stable/2024-01-01/virtualNetwork.json#L154 |
|
The resource name parameter 'virtualNetworkName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2024-01-01/virtualNetwork.json#L385 |
|
The resource name parameter 'subnetName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2024-01-01/virtualNetwork.json#L385 |
|
Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.Network/stable/2024-01-01/virtualNetwork.json#L386 |
|
A 202 response should include an Location response header. Location: Microsoft.Network/stable/2024-01-01/virtualNetwork.json#L428 |
|
Query parameter $expand should be removed. Point Get's MUST not have query parameters other than api version. Location: Microsoft.Network/stable/2024-01-01/virtualNetwork.json#L454 |
|
A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'Subnets_CreateOrUpdate' Request Model: 'parameters[3].schema' Response Model: 'responses[200].schema' Location: Microsoft.Network/stable/2024-01-01/virtualNetwork.json#L516 |
|
Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/virtualNetworks/{virtualNetworkName}/subnets/{subnetName}/PrepareNetworkPolicies' Location: Microsoft.Network/stable/2024-01-01/virtualNetwork.json#L603 |
|
The resource name parameter 'virtualNetworkName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2024-01-01/virtualNetwork.json#L603 |
|
The resource name parameter 'subnetName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2024-01-01/virtualNetwork.json#L603 |
|
200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. Location: Microsoft.Network/stable/2024-01-01/virtualNetwork.json#L604 |
|
A 202 response should include an Location response header. Location: Microsoft.Network/stable/2024-01-01/virtualNetwork.json#L649 |
|
Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/virtualNetworks/{virtualNetworkName}/subnets/{subnetName}/UnprepareNetworkPolicies' Location: Microsoft.Network/stable/2024-01-01/virtualNetwork.json#L670 |
|
The resource name parameter 'virtualNetworkName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2024-01-01/virtualNetwork.json#L670 |
|
The resource name parameter 'subnetName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2024-01-01/virtualNetwork.json#L670 |
|
200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. Location: Microsoft.Network/stable/2024-01-01/virtualNetwork.json#L671 |
|
A 202 response should include an Location response header. Location: Microsoft.Network/stable/2024-01-01/virtualNetwork.json#L716 |
|
Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/virtualNetworks/{virtualNetworkName}/subnets/{subnetName}/ResourceNavigationLinks' Location: Microsoft.Network/stable/2024-01-01/virtualNetwork.json#L737 |
|
The resource name parameter 'virtualNetworkName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2024-01-01/virtualNetwork.json#L737 |
|
The resource name parameter 'subnetName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2024-01-01/virtualNetwork.json#L737 |
|
x-ms-pageable extension must be specified for LIST APIs.Location: Microsoft.Network/stable/2024-01-01/virtualNetwork.json#L738 |
|
Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/virtualNetworks/{virtualNetworkName}/subnets/{subnetName}/ServiceAssociationLinks' Location: Microsoft.Network/stable/2024-01-01/virtualNetwork.json#L791 |
|
The resource name parameter 'virtualNetworkName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2024-01-01/virtualNetwork.json#L791 |
|
The resource name parameter 'subnetName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2024-01-01/virtualNetwork.json#L791 |
|
x-ms-pageable extension must be specified for LIST APIs.Location: Microsoft.Network/stable/2024-01-01/virtualNetwork.json#L792 |
|
The resource name parameter 'virtualNetworkName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2024-01-01/virtualNetwork.json#L845 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
This was referenced Jun 17, 2024
AzureRestAPISpecReview
added
ARMReview
resource-manager
WaitForARMFeedback
This was referenced Jun 17, 2024
TimLovellSmith
approved these changes
Jun 17, 2024
TimLovellSmith
added
the
ARMSignedOff
openapi-pipeline-app
bot
removed
the
WaitForARMFeedback
GuptaVertika
merged commit 16b65b5
into
Azure:guptavertika/release-network-Microsoft.Network-official-2024-01-01
25 of 29 checks passed
rkmanda
pushed a commit
that referenced
this pull request
Jun 19, 2024
…29302) * Adds base for updating Microsoft.Network from version stable/2023-11-01 to version 2024-01-01 * Updates readme * Updates API version in new specs and examples * Add examples for Subnet peering and v6 Subnet peering. (#28827) Add examples for Subnet peering and v6 Subnet peering. --------- Co-authored-by: saurabh83 <saugu@microsoft.com> * Init (#29127) Co-authored-by: Abhishek Shah <shabhis@microsoft.com> * Adding the new response code to the 2024-01-01 version release of swagger to match the bugfix in 2023-11-01 (#29048) Co-authored-by: Arsheen Khatib (from Dev Box) <akhatib@microsoft.com> * Added NoHealthyBackendsBehavior (#28868) Added the property "NoHealthyBackendsBehavior" to the Probe properties. * VirtualNetworkGatewayConnection using key vault for authentication. (#28760) * Add parameters for cert based auth connection * retrigger checks * retrigger checks * lintDiff * Trigger Build * revert PATCH changes * fix * change managed identity to v5 * add format and description * rresolving conflict * resolving readme file * Revert "VirtualNetworkGatewayConnection using key vault for authentication. (#28760)" This reverts commit c37ec24. * Lint diff error suppress * Guptavertika/release network microsoft.network official 2024 01 01 (#29367) * added networkidentifier under vnet->subet->serviceendpoint * added format :armid and updated description * corrected the type * fixed response * response type fixed example --------- Co-authored-by: Bhupesh Bhatt <bhupeshbhatt@microsoft.com> * Adding GET operaton for Network Virtual Appliance Inbound Secuirty Rule (#29339) (#29375) * Fix for PR VirtualNetworkGatewayConnection using key vault for authentication. (#29357) (#29376) * Fix * Fix2 --------- Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com> * Add CrossConnection Name as an optional query parameter in List ExpressRoute CrossConnection (#29251) * Add CrossConnection name as an optional query parameter for List CrossConnection * update example * Addressing comments * Change to OData filtering * Fix the parameter reference * Update --------- Co-authored-by: Jianqi Zhao <jianzhao@microsoft.com> * initial changes (#29235) * Changed type of networkIdentifier from PublicIPAddress to SubResource (#29469) * added networkidentifier under vnet->subet->serviceendpoint * added format :armid and updated description * corrected the type * fixed response * response type fixed example * Changed type of networkIdentifier from ./publicIpAddress.json#/definitions/PublicIPAddress to ./network.json#/definitions/SubResource --------- Co-authored-by: Bhupesh Bhatt <bhupeshbhatt@microsoft.com> --------- Co-authored-by: saurabh83 <splitt@gmail.com> Co-authored-by: saurabh83 <saugu@microsoft.com> Co-authored-by: Abhishek Shah <16267081+abhi7860@users.noreply.github.com> Co-authored-by: Abhishek Shah <shabhis@microsoft.com> Co-authored-by: AFK1194 <arsheen.khatib@gmail.com> Co-authored-by: Arsheen Khatib (from Dev Box) <akhatib@microsoft.com> Co-authored-by: Eugenio Peña García <70240915+EugenioPena@users.noreply.github.com> Co-authored-by: daweiwang-microsoft <165709729+daweiwang-microsoft@users.noreply.github.com> Co-authored-by: Bhupesh Kumar Bhatt <52891188+bhupeshbhatt1985@users.noreply.github.com> Co-authored-by: Bhupesh Bhatt <bhupeshbhatt@microsoft.com> Co-authored-by: Ashutosh Mishra <163998769+ashutmi@users.noreply.github.com> Co-authored-by: Khushboo Baheti <37917868+Khushboo-Baheti@users.noreply.github.com> Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com> Co-authored-by: jianzhao1992 <125631957+jianzhao1992@users.noreply.github.com> Co-authored-by: Jianqi Zhao <jianzhao@microsoft.com> Co-authored-by: nimaller <71352534+nimaller@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting helpsection at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PRandDue diligence checklist.write accessper aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queuedstate, please add a comment with contents/azp run.This should result in a new comment denoting a
PR validation pipelinehas started and the checks should be updated after few minutes.