Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appgwv2 changes #3192

Merged
merged 1 commit into from
Jun 7, 2018
Merged

Conversation

akshaysngupta
Copy link
Member

@akshaysngupta akshaysngupta commented Jun 7, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Jun 7, 2018

Automation for azure-libraries-for-java

Encountered a Subprocess error: (azure-libraries-for-java)

Command: ['/usr/local/bin/autorest', '/tmp/tmpvckajsd_/rest/specification/network/resource-manager/readme.md', '--azure-libraries-for-java-folder=/tmp/tmpvckajsd_/sdk', '--fluent', '--java', '--multiapi', '--verbose']
Finished with return code -9
and output:

AutoRest code generation utility [version: 2.0.4262; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4278/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4278)
   Loading AutoRest extension '@microsoft.azure/autorest.java' (~2.1.32->2.1.70)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)

@AutorestCI
Copy link

AutorestCI commented Jun 7, 2018

Automation for azure-sdk-for-node

Encountered a Subprocess error: (azure-sdk-for-node)

Command: ['/usr/local/bin/autorest', '/tmp/tmpgzpdjyam/rest/specification/network/resource-manager/readme.md', '--license-header=MICROSOFT_MIT_NO_VERSION', '--node-sdks-folder=/tmp/tmpgzpdjyam/sdk', '--nodejs', '--use=@microsoft.azure/autorest.nodejs@^2.1.43']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4262; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4278/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4278)
   Loading AutoRest extension '@microsoft.azure/autorest.nodejs' (^2.1.43->2.1.59)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
Shutting Down
FATAL: nodejs/generate - FAILED
FATAL: Error: [Exception] AutoRest extension '@microsoft.azure/autorest.nodejs' terminated.
Process() cancelled due to exception : [Exception] AutoRest extension '@microsoft.azure/autorest.nodejs' terminated.

@AutorestCI
Copy link

AutorestCI commented Jun 7, 2018

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@AutorestCI
Copy link

AutorestCI commented Jun 7, 2018

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Jun 7, 2018

Automation for azure-sdk-for-go

A PR has been created for you:
Azure/azure-sdk-for-go#1989

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda dsgouda merged commit 420f89e into Azure:Network-2018-06-01 Jun 7, 2018
@bsiegel bsiegel removed the review label Jun 7, 2018
EvgenyAgafonchikov pushed a commit to EvgenyAgafonchikov/azure-rest-api-specs that referenced this pull request Jun 19, 2018
lmazuel pushed a commit that referenced this pull request Jun 21, 2018
…1) (#3261)

* Added Network 2018-06-01; VM ref fix (#3118)

* Init 2018-06-01 (copy from 2018-05-01)

* Make VM reference in NIC readonly

* Updated version in readme

* New VPN Client Protocol (#3133)

* Added new VPN protocol

* indents

* Add examples for Express Route Circuit APIs (#3182)

* Add examples for Express Route Circuit APIs

* Fix errors in expressRouteCircuit.json validations

* Fix errors in validate examples for ExR Circuit

* appgwv2 changes (#3192)

* AppGW FIPS mode (#3202)

* Release of Azure Networking Network-2018-06-01 branch (api-version 2018-04-01)

* Adding VirtualWan Swagger (#3204)

* Adding VirtualWan Swagger

* Adding the CRUD Apis for VpnConnections

* Updating VpnGateway examples

* Fixing build errors

* Addressing comments

* Addressing comments and editing VpnConnection definition and corresponding examples

* Addressing comments

* Removing enableRateLimiting property

* Addressing comments

* Changing the version to 2018-04-01 version

* Suppress ConnectionSharedKey model issue

* Reverted extra-changes in readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants