Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated NetworkConfigurationDiagnostic API + example - PLEASE close this PR. This feature will be in the next release #3901

Closed
wants to merge 9 commits into from
Closed

Updated NetworkConfigurationDiagnostic API + example - PLEASE close this PR. This feature will be in the next release #3901

wants to merge 9 commits into from

Conversation

irrogozh
Copy link
Member

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

Ajit Navasare and others added 9 commits September 12, 2018 15:09
@lmazuel
ServiceBus: 2018-01-01 Preview - for managing Namespace, IPFilter Rul…
5867e27 
…es, VirtualNetworkRules and Zone Redundant (#3754)

* 2018 Preview

* changed the preview swagger name

* corrected swagger

* fixed validation errors

* corrected the type in VirtualNetworkRuleListResult

* updated swagger, removed the opreations API

* preview move to the begining of the file

* fixed casing
@elemount @dsgouda
Add mariadb swagger spec (#3797)
1cff2ef 
* Add mariadb swagger spec

* Fix readme and set properties
@lmazuel
Swagger spec for disk.json + compute.json 2018-06 (#3854)
5fdf492 
* removing resourceUpdate, adding contents to disk and snapshot

* adding swagger spec for disk.json 2018-06-01

* Disks 2018-06-01 for Python

* update disk

* Update readme.md

* adding compute.json changes

* deleting duplicates

* Fix indent

* adding suppress

* Update suppression rules
@lmazuel
Update .travis.yml (#3888)
8b107a7
Generate readme.md file for azure-arm-mariadb until one is provided (#…
53e853a 
…3893)
@jhendrixMSFT
Fix Go SDK codegen for mariadb (#3892)
edee830 
Moved preview package under preview subdirectory.
Moved Go SDK config to its own config file.
@t-robalt @jianghaolu
[DO NOT MERGE] Added list support to VA policies (#3878)
19800d8 
* Added list support to VA policies

* Changed suffixes

* added missing examples

* Updated database example

* Changed operation name.

the suffix of "_ListBy..." should be a substring of the operation group, thus changed to Instance.
@asinn826 @sergey-shandar
Fix incorrect url and clarify subscription-level disable (unsure why …
b55dc2b 
…this came with so many commits) (#3886)

* add serial console reference

* update version

* Add readme.md

* update readme.md

* add config to readme

* update default parameter

* fix json

* fix camelcase error

* add x-ms-examples

* add renamed DisableConsoleExample.json

* fix json

* add operations, address github comments

* update operations path spec

* add more examples, some minor changes

* update x-ms-parameter-location

* trivial modification to error message to kickstart a new build process

* example updates

* update example again

* update api version

* modify api version reference

* one more api version reference

* (hopefully) final api version reference update

* update examples and codeowners

* trivial change to kickstart build again

* add python

* trivial change to kickstart build again

* Update CODEOWNERS

* clarify the subscription-level disable

* fix incorrect url
@irrogozh
Updated NetworkConfigurationDiagnostic API + example
ea178ff
@AutorestCI
Copy link

AutorestCI commented Sep 13, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

This PR contains more than 3 context, SDK generation is not enabled. Contexts found:

  • network/resource-manager
  • compute/resource-manager
  • servicebus/resource-manager
  • mariadb/resource-manager
  • sql/resource-manager
  • serialconsole/resource-manager

@AutorestCI AutorestCI mentioned this pull request Sep 13, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented Sep 13, 2018 •
edited
Loading

Automation for azure-sdk-for-python

This PR contains more than 3 context, SDK generation is not enabled. Contexts found:

  • serialconsole/resource-manager
  • network/resource-manager
  • sql/resource-manager
  • mariadb/resource-manager
  • compute/resource-manager
  • servicebus/resource-manager

@MikhailTryakhov
Copy link
Contributor

@irrogozh why is it going to master?

MikhailTryakhov
MikhailTryakhov suggested changes Sep 13, 2018
View reviewed changes
Copy link
Contributor

@MikhailTryakhov MikhailTryakhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like contains breaking changes, why is it going to master?
do you have approval for breaking changes?

@AutorestCI
Copy link

AutorestCI commented Sep 13, 2018 •
edited
Loading

Automation for azure-sdk-for-java

This PR contains more than 3 context, SDK generation is not enabled. Contexts found:

  • compute/resource-manager
  • servicebus/resource-manager
  • serialconsole/resource-manager
  • mariadb/resource-manager
  • network/resource-manager
  • sql/resource-manager

@AutorestCI
Copy link

AutorestCI commented Sep 13, 2018 •
edited
Loading

Automation for azure-sdk-for-go

This PR contains more than 3 context, SDK generation is not enabled. Contexts found:

  • serialconsole/resource-manager
  • servicebus/resource-manager
  • network/resource-manager
  • compute/resource-manager
  • sql/resource-manager
  • mariadb/resource-manager

@AutorestCI AutorestCI mentioned this pull request Sep 13, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented Sep 13, 2018 •
edited
Loading

Automation for azure-sdk-for-node

This PR contains more than 3 context, SDK generation is not enabled. Contexts found:

  • mariadb/resource-manager
  • serialconsole/resource-manager
  • compute/resource-manager
  • sql/resource-manager
  • servicebus/resource-manager
  • network/resource-manager

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@azuresdkci azuresdkci requested a review from dsgouda September 13, 2018 21:40
@dsgouda
Copy link
Contributor

dsgouda commented Sep 13, 2018

Reassigning since I won't be available for starting this evening

@dsgouda
Copy link
Contributor

dsgouda commented Sep 13, 2018

@MikhailTryakhov These are changes to the stable API that we just merged. PTAL

@irrogozh
Copy link
Member Author

Guys, I'll close this pr. We don't need it for Ignite. It will be in the next release. Will send it to network-October-release branch

@irrogozh irrogozh changed the title Updated NetworkConfigurationDiagnostic API + example Updated NetworkConfigurationDiagnostic API + example - PLEASE close this PR. This feature will be in the next release Sep 13, 2018
@MikhailTryakhov
Copy link
Contributor

@irrogozh you can retarget branch from here

@azuresdkci azuresdkci assigned lmazuel and unassigned dsgouda Sep 13, 2018
@azuresdkci azuresdkci requested a review from lmazuel September 13, 2018 22:36
@irrogozh irrogozh changed the base branch from master to network-october-release September 13, 2018 22:54
@lmazuel lmazuel closed this Sep 14, 2018
@lmazuel
Copy link
Member

lmazuel commented Sep 14, 2018

Ok, sorry messed up my links with myself, re-opening :p

@lmazuel lmazuel reopened this Sep 14, 2018
@lmazuel
Copy link
Member

lmazuel commented Sep 14, 2018

Seems I'm tired this morning, I actually wanted to close this PR....
See #3905 instead

@lmazuel lmazuel closed this Sep 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikhailTryakhov MikhailTryakhov MikhailTryakhov requested changes

@dsgouda dsgouda Awaiting requested review from dsgouda

@lmazuel lmazuel Awaiting requested review from lmazuel

Assignees

@lmazuel lmazuel

Labels
Reassign
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@irrogozh @AutorestCI @MikhailTryakhov @azuresdkci @dsgouda @lmazuel @elemount @jhendrixMSFT @t-robalt @asinn826