Remove aad and b2c auto-configuration conditional on resource conditions #25471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…zure#23597) * Unify spring configurations (Azure#22937) * Refactor Azure Spring projects structure (Azure#23004) * Mapping spring legacy props (Azure#23166) ** use file for property mapping ** add environmentpostprocessor after kv ** map multiple key vault use case * update readme for unified configuration (Azure#23452) Co-authored-by: Yi Liu <yiliu6@microsoft.com>
* refactor a spring-cloud-for-azure module * change dependency on azure-core-management to using dependency version * refactor azure-spring-boot-starter to azure-spring-cloud-starter * fix pipeline * address comments
…23883) * update versions in pom.xml * update versions in READMEs and CHNAGELOGs
Fix actuator details configuration missing
Update azure spring cloud 4.0 dependencies
…zure/azure-sdk-for-java into feature/azure-spring-cloud-4.0
* add properties * split clientfactory * refactor template and autoconfiguration * update binder * refactor * refactor the auto-configuration of sb * refactor health indicator * add ut * refactor sb health indicator * add ut for health indicator * modify service bus template api * modify IT * fix pipeline error * fix compiling errror * modify binder configuration * fix pipeline error * move entity name and type to common level * fix pipeline error * fix ut * remove invalid TODO Co-authored-by: Xiaolu Dai <xiada@microsoft.com>
This PR is mainly about - Remove the validation dependency spring-boot-starter-validation to simplify module dependency. - Add a new starter -- spring-cloud-azure-starter-data-cosmos
saragluna
requested review from
alzimmermsft,
anuchandy,
backwind1233,
chenrujun,
conniey,
g2vinay,
hallipr,
hui1110,
jialigit,
JonathanGiles,
joshfree,
lmolkova,
moarychan,
mssfang,
pallavit,
samvaity,
srnagar,
stliu,
weshaggard and
yiliuTo
as code owners
ghost
added
|
Chose the wrong targeting branch, will create a new one. |
saragluna
deleted the
xiada/feature/aad-remove-conditional-on-resource-condition
branch
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-java
that referenced
this pull request
Sep 12, 2023
Add 2023-09-01-preview for appplatform (Azure#25501) * Adds base for updating Microsoft.AppPlatform from version preview/2023-07-01-preview to version 2023-09-01-preview * Updates readme * Updates API version in new specs and examples * feat: fragment support swagger change (Azure#25314) * Add apiTryOutEnabledState properties for api portal for 2023-09-01-preview api (Azure#25322) * support war file deployment (Azure#25312) Co-authored-by: Yi Li <yili7@microsoft.com> * Fix exmaple for api portal api try-out feature (Azure#25337) * Add property `autoSync` in `KeyVaultCertificateProperties` (Azure#25331) * Add gateway apm reference (Azure#25408) * Add expand parameter for list deployment (Azure#25411) * Add expand parameter for list deployments API (Azure#25471) * change order of expand (Azure#25587) * Update readme.go.md (Azure#25634) * Update readme.go.md * Update readme.python.md * Update readme.ruby.md * Revert api portal try out feature (Azure#25677) Fix exmaple for api portal api try-out feature (Azure#25337)" * add API to list all server versions (Azure#25720) * add API to list all server versions * refine list supported server version API * refine description --------- Co-authored-by: Yi Li <yili7@microsoft.com> * use enum for autoSync (Azure#25722) * Update appplatform.json (Azure#25724) * certificate - rename enum (Azure#25723) * use enum for autoSync * rename enum * rename enum --------- Co-authored-by: guitarsheng <85543793+guitarsheng@users.noreply.github.com> Co-authored-by: Mason Chen <jiec@microsoft.com> Co-authored-by: Yi Li <109205537+yilims@users.noreply.github.com> Co-authored-by: Yi Li <yili7@microsoft.com> Co-authored-by: Jeff <1830237+domainname@users.noreply.github.com> Co-authored-by: ninpan-ms <71061174+ninpan-ms@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of aad and b2c starter comes with an
*.enable.config, which is not very neat for a starter project. But aad and b2c starter doesn't like other data plane sdk's starter, which could derive a condition, @ConditionalOnClass(***Client.class), so in this PR I added two opt-in switches for aad and b2c autoconfiguration.