Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prepped for merging into main] Adding in the remaining unit tests for constraints, filled out some TODOs #273

Merged
merged 22 commits into from
Apr 30, 2024

Conversation

tbarnes94
Copy link
Member

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)
Feature # (details)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Is it a breaking change which will impact consuming tool(s).

  • TestValidateDeployment_UniqueServiceSelectors [x]
  • TestValidateDeployment_RestrictedTaints [x]
  • TestValidateDeployment_PodEnforceAntiaffinity [x]
  • TestValidateDeployment_DisallowedBadPodDisruptionBudget [x]
  • TestValidateDeployment_All [x]

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@tbarnes94 tbarnes94 enabled auto-merge (squash) April 29, 2024 22:17
@tbarnes94 tbarnes94 changed the title Adding in the remaining unit tests for constraints, filled out some TODOs, renamed getObjectViolations -> getObjectResults Adding in the remaining unit tests for constraints, filled out some TODOs Apr 30, 2024
Copy link
Collaborator

@davidgamero davidgamero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm can we document that is merges main's changes and isn't just a huge new set of changes?

@tbarnes94 tbarnes94 merged commit 96d4e34 into staging Apr 30, 2024
141 checks passed
@tbarnes94 tbarnes94 deleted the tbarnes94/remaining-UTs branch April 30, 2024 21:05
@tbarnes94 tbarnes94 changed the title Adding in the remaining unit tests for constraints, filled out some TODOs [merging into main] Adding in the remaining unit tests for constraints, filled out some TODOs Apr 30, 2024
@tbarnes94 tbarnes94 changed the title [merging into main] Adding in the remaining unit tests for constraints, filled out some TODOs [prepped for merging into main] Adding in the remaining unit tests for constraints, filled out some TODOs Apr 30, 2024
@bfoley13 bfoley13 mentioned this pull request May 16, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants