Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoPR @azure/arm-hanaonazure] Microsoft.HanaOnAzure swagger: Update spec to add missing fields #5098

Closed

Conversation

openapi-sdkautomation[bot]
Copy link

Create to sync Azure/azure-rest-api-specs#14879

Installation Instructions

You can install the package @azure/arm-hanaonazure of this PR using the following command:

curl -L "https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/14879/azure-sdk-for-js/@azure_arm-hanaonazure/azure-arm-hanaonazure-3.0.0.tgz" -o azure-arm-hanaonazure-3.0.0.tgz
npm install azure-arm-hanaonazure-3.0.0.tgz

Direct Download

The generated package can be directly downloaded from here:

praveenkuttappan and others added 29 commits June 18, 2021 14:27
Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>
* Always use x-ms-date for Hmac

* Try to fix phone number tests

* Still another error in phone number tests

* Update phoneNumber session records

* Update phone numbers node sessions

* Manually fix node record sessions for phone numbers

* Update missed session files

Co-authored-by: JP Chen <jiach@microsoft.com>
This PR makes three changes to our deployment template:

- Add networkAcls to the Managed HSM properties
- Remove the 60 second sleep after activation
- Speed up challenge auth tests for KV Keys by using methods that don't require creating and deleting keys.

The first is now needed, and without it deployment will fail.
The second is no longer needed, since it looks like the az cli appropriately waits before coming back.
Finally, the third is something I noticed - there's no reason to create and purge keys which takes a long time in order to test CAE.
## What

- Bump @opentelemetry/api to 0.20.0 in @azure/core-tracing
- Move all packages that are on core-http to the next core-tracing version 
- Remove version collision check from the tracer cache

## Why

This is part of our effort to move everyone to OTel 0.20.0 - but we have to stage it due to a transitive dependency and a 
breaking change in OTel. This PR updates core-tracing to use the latest OTel, fixes any breaking changes, and moves 
packages that we can move to the latest version of core-tracing.

Once core-rest-pipeline 1.1.0 is GA'd we'll be able to move the rest of the packages over to the latest core-tracing as well.

Removing the version collision came out of an offline discussion after these changes were reviewed - since it's a common 
source of pain and hasn't added much benefit (tracer conflicts incompatibility was never a problem) we decided to remove 
that logic and always grab a unique symbol per OT compatibility. 

## Callouts

The packages that are already on core-v2 will _not_ be upgraded at this time - we'll coordinate that with the GA of core-rest-pipeline 1.1.0
…-persistence (Azure#15384)

* [identity] Remove machine-code-dependent codepaths (Azure#15024)

* [identityg Remove machine-code-dependent codepaths

* Linter fixes

* Disable broken perf test

* Added missing import back

* [identity] Add extension registration API and default credential stack

* [identity-native] Introducing identity-native

* [identity] Rework extension API.

* Remove identity native

* Identity-persistence module

* Adding identity-vscode module

* Updated rush configuration

* Moved identity perf back to linking local identity

* Symbolic refactor of extension system

* Renamed MsalCredentialOptions to CacheableCredentialOptions

* Use Symbol.for instead of hacking around SymbolConstructor

* Improved identity-vscode samples

* Use persistence by default if a persistence provider has been registered.

* Improved identity-persistence samples

* Rename to identity-cache-persistence

* Feedback from arch board for mainline identity package

* Rename CredentialPersistenceOptions, format and lint

* Revert sanitization of scopes.

* Regenerated API.md for mainline identity

* Add tests and finalize @azure/identity-cache-persistence

* Record tests for identity-cache-persistence

* Renamed sample files.

* Some changes for testing in identity

* Updated identity-vscode

* Remove async version of useIdentityExtension

* Added a couple of tests for default no-extension behavior

* Fixed tests in recorder

* Removed errant console.log

* Added basic tests of identity-vscode

* Fixed a couple of tests that have started caching correctly

* Added browser shim for extensions/consumer.ts

* Mock keytar using sinon in live/playback environments

* Disable persistence tests on node !== 12

* Addressed feedback in identity-cache-persistence

* Restore perf-test

* Removed sanitizeScopeUrl from recorder

* Update sdk/identity/identity/src/credentials/visualStudioCodeCredential.ts

Co-authored-by: Jeff Fisher <xirzec@xirzec.com>

* Fix gitignores

* Feedback for identity-vscode

* Changelog entry for recorder changes.

* core-http -> core-auth

* setter methods instead of setter props

* Some changes to docs and keywords

* Fixed linter warning

* Switch persistence tests from 12 to 14.

* Make the tests even refuse to import msal-node-extensions on anything other than Node 14

* Reverted changes to recorder

* master -> main

* More master -> main

* [identity] Make the samples extract only part of the token data

Co-authored-by: Jeff Fisher <xirzec@xirzec.com>
* Changes to create artifact in package directory
… fixing flaky tests to be more reliable. (Azure#15761)

Making changes to simplify a flaky test (and hopefully make it more reliable).

The main issue with the 'handle interrupted detach' method was that it relied on too many moving parts to work reliably. We could just eternally loop like we'd expect customers to do, but in the end we have a very simple test we're trying to perform - we want to receive, and while we're in the process of draining, cause a detach and have it early exit and reject/resolve immediately rather than waiting for the timeout.

I reworked the test to make that simpler by just removing the unneeded connection.idle() and just calling directly into the onDetached method. Because it happens prior to rhea even seeing that we're draining we should reliably win that race each time. 

There were a couple of other things changed for this PR as well:
- The max time per test was lowered accidentally. Bringing it back what's been used as the standard time in other libraries
- Fixed a spot in receiveMessages() where, if the link had been closed, we'd falsly return an empty array instead of throwing an exception indicating the link closed. This didn't appear to be related to the bug but it's incorrect and can hide bugs so I'd rather just throw the error than eat the condition and return an empty array. It's rare, but when it does happen the empty array response isn't right either - we're probably in the middle of a connection reset/change event.

Fixes Azure#13461
* Update links with master to use main

* Update ci.yml files

Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>
* Update pipeline generation tool version

Consume latest changes from pipeline generation tool in Azure/azure-sdk-tools#1708

* Update tool version to include fix for public ci

Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
…ll anymore (Azure#15783)

I’ve got some customers writing to me directly with some confusion regarding getToken returning null. We’ve got some remnants of this type, but at this point, Identity doesn’t return null (except for ClientSecretCredential in the browser, which is generally unusable outside of our tests). This PR is to update these docs and to give a bit of clarity on what errors we’re throwing.
…ure#15883)

Now that `@opentelemetry/api` GA'd at [1.0.0](https://www.npmjs.com/package/@opentelemetry/api) we can bump our 
own dependency to `@opentelemetry/api@1.0.0`

Reminder: not _all_ packages are on the latest @opentelemetry/api... those that depend on @azure/core-rest-pipeline 
cannot be upgraded yet.
This should allow our pipelines to pick these packages up for publication.
I recently added a few breaking changes to core-tracing which have impacted core-http but forgot to add changelog entries. This commit just addresses the changelog.
…5777)

and re-generate code.

* Don't set userAgentPrefix in convenience layer

* Update version constant prefix

* Use latest @autorest/typescript plugin
* arm-cosmosdb-release

* version update
## What

- Migrate @azure/keyvault-admin to core V2
- Migrate `KeyVaultBackupClient` and `KeyVaultAccessControlClient` to core CAE
- Bump our minimum `@azure/core-lro` version to 1.0.6

## Why

This PR proves out two important things: it demonstrates that core continuous access evaluation works for both container 
registry (already done) and Key Vault (this PR). It also demonstrates the migration path for Core V2 for Key Vault.

The change to core-lro addresses an issue where core-lro was incorrectly depending on core-http (Azure#15880)  That has been fixed on 1.0.6 
and allows package owners to migrate to core-rest-pipeline and remove core-http without seeing build breaks.


Resolves Azure#15522 
Resolves Azure#14306
* Move to @azure/msal-node-extensions 1.0.0-alpha.7

This version unpins the `keytar` dependency, resolving build issues for some developers, and allowing keytar 7.7.0 (which uses NAPI, reducing prebuild complexity).

* Update pnpm-lock
…tifications (Azure#15731)

* Feature: add sender display name within send typing notifications
* update Changelog
* update signaling package
* update swagger file
* Update ubuntu vm image

* Update vmImage names

* Update platform-matric.json

* Update platform-matric.json
xiao-lix and others added 28 commits June 28, 2021 14:55
…ers (Azure#15932)

* [Monitor Exporter] Separate tests into internal and public folders

* fix build

* put tests in internal

* prettier

* console log for testing

* testing

* format

* console

* try flush processor

* format

* remove console logs
## What

- Adds warning filter to ignore known rollup warnings that are safe to ignore
- Ignore `this has been rewritten to undefined` in synapse
- Ignore circular dependencies in synapse

## Why

These are both known warnings, are safe to ignore, and add noise to the build output unnecessarily. 

The first is totally safe to ignore:

```
var __spreadArray = (this && this.__spreadArray) || function (to, from) {
```

Is emitted from TypeScript in the OTel ESM and is safe to use.
The second is a known issue in OTel 1.0.0 that is not harmful at runtime.

Finally, we have precedent for doing the exact same thing in other packages like service-bus.
The watchful eyes of @vishnureddy17 found that we still have reference to Node.js 8 in our Contributing Guide!!

This PR fixes that.

Related to #7022
* Update identity to 2.0.0-beta.4 for quantum jobs

* Fix CI Errors

* Fix CI Errors
Based on the Retry-After specification, 503 should also be supported when considering the Retry-After header.

This also aligns with upcoming Identity plans.
…5853)

This PR enables PKCE on the InteractiveBrowserCredential.

We don’t have tests for this yet. I’ll make sure to test it manually, at least.

Fixes Azure#15168
…ludeVisualization option. (Azure#16058)

* Big update to use the latest stable swagger files for all of the Log Analytics services. Each reference is by git commit ID this time to prevent any accidental drift.

Also, added in the includeRender header (via the `includeVisualization` option).

Fixes Azure#15771

* Fixing codeowners to reflect the proper owners for the package:
@KarishmaGhiya - main owner
@maorleger - backup owner

* Formatting!
* Convenience Method to create a synonymmap object

* Update sdk/search/search-documents/src/synonymMapHelper.ts

Co-authored-by: Jeff Fisher <xirzec@xirzec.com>

* Fix for PR Comments

Co-authored-by: Jeff Fisher <xirzec@xirzec.com>
* [Identity] InteractiveBrowserCredential LoginHint

* formatting

* Update CHANGELOG.md
* Bring changes from JS docs metadata

* Move business logic inside Update-DocsMsMetadata.ps1

* Update with the latest changes in JS PR

* Update from latest PR feedback

* Add check for empty path to prevent crashes when creating relative paths

Co-authored-by: Daniel Jurek <djurek@microsoft.com>
This PR just updates the release dates for core releases that I plan to release:

- @azure/core-tracing
- @azure/core-http
- @azure/core-rest-pipeline
- @azure/core-client
- @azure/core-lro
- @azure/core-auth
- Switch to using rest instead of cli for querying work items
  as cli is limited to 1000 items only.
- Fix issues with Generated fields not being set.
- Correctly sort older workitems by version isntead of string.

Co-authored-by: Wes Haggard <Wes.Haggard@microsoft.com>
* [event-hubs] add AmqpAnnotatedMessage support

* undo experimental deletion of decode method from service bus

* address feedback
See Azure#16094 for details. This PR just updates core-client to 1.2.1 so I can release it
The release pipeline complains if there are empty sections in the changelog. Removing the empty section to correct this and unblock core-http release.
* Disable release date check

* Release check is not finding release date

Co-authored-by: Praveen Kuttappan <praveen.kuttappan@gmail.com>
…entCredentials (Azure#15837)

This PR adds `tenantId` to the `getTokenOptions`, and adds options on every Identity credential to allow multi-tenant authentication (which will be disabled by default).

Fixes Azure#15797
* Increment package version after release of azure-core-tracing

* Increment package version after release of azure-core-lro

* Increment package version after release of azure-core-rest-pipeline

* Run rush update

Co-authored-by: Maor Leger <malege@microsoft.com>
* Increment package version after release of azure-core-http

* Increment package version after release of azure-core-client
…ete (Azure#15989)

Fixing an issue where we could lose messages or provoke an alarming message from rhea (`Received transfer when credit was 0`)
    
The message loss issue is related to how we trigger 'drain' using 'addCredit(1)'. Our 'receiver.drain; receiver.addCredit(1)' pattern actually does add a credit, which shows up in the flow frame that gets sent for our drain. This has led to occasionally receiving more messages than we intended.
    
The second part of this was that we were masking this error because we had code that specifically threw out messages if more arrived than were requested. If the message was being auto-renewed it's possible for the message to appear to be missing, and if we were in receiveAndDelete the message is effectively lost at that point. That code is now removed (we defer to just allowing the extrra message, should a bug arise that causes that) and we log an error indicating it did happen.
    
The rhea error message appeared to be triggered by our accidentally allowing multiple overlapping 'drain's to occur (finalAction did not check to see if we were _already_ draining and would allow it to happen multiple times). Removing the concurrent drains fixed this issue but I didn't fully investigate why.

Fixes Azure#15606, Azure#15115
* Delete mgmt-ci.yml

* Delete mgmt-pr.yml
Merge c539ce1832645cfa0000459d75d2b1ac69808d6c into 8f7e0b2d62e33916458b9138a0fcac8c64a7ac44
@openapi-sdkautomation openapi-sdkautomation bot force-pushed the sdkAuto/14879/@azure_arm-hanaonazure branch from 15a3dd3 to d30ca40 Compare July 1, 2021 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.