Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoPR Microsoft.Azure.Management.Synapse] [Hub Generated] Review request for Microsoft.Synapse to add version preview/2021-06-01-preview #4416

Conversation

openapi-sdkautomation[bot]
Copy link

Create to sync Azure/azure-rest-api-specs#14814

Installation Instructions

In order to use the generated nuget package in your app, you will have to use it from a private feed.
To create a private feed, see the following link:
https://docs.microsoft.com/en-us/nuget/hosting-packages/local-feeds
This will allow you to create a new local feed and add the location of the new feed as one of the sources.

Direct Download

The generated package can be directly downloaded from here:

seanmcc-msft and others added 14 commits June 18, 2021 11:54
…val in Development env. (Azure#21969)

* if not on defaults, honor custom value.

* changelog.
Since track 1 SDKs are deprecated, remove the solution to avoid having
to type the solution name when building from sdk/keyvault each time.
This shouldn't affect the build which enumerates projects within service
directories.
Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>
* Add public ctor for SubscriptionValidationResponse

* Comment out package reference.
* Add Stable API Version for point-in-time restore.

* Newly generated SDK from latest swagger

* Updating testcases to fix the CI break.

* Fixing test errors

* Fixed failing tests

* Updated SDK Version and updated release notes.

* Bumping up AssemblyVersion/AssemblyFileVersion("3.1.0.0") from ("3.0.0.0")
Also gets rid of unnecessary, deprecated enableSoftDelete parameter.
Azure#21968)

* Fixed pipeline break

* 100% methods have protocol overloads

* API cleanup

* Update API file

* renamed message to content

* bug fix and parameter validation
* Add asserts to verify all actions are counted for pending queue

* Increase timeout of test
@openapi-sdkautomation openapi-sdkautomation bot force-pushed the sdkAuto/14814/Microsoft.Azure.Management.Synapse branch 3 times, most recently from 3603b74 to 9109cd8 Compare June 20, 2021 10:59
@openapi-sdkautomation openapi-sdkautomation bot force-pushed the sdkAuto/14814/Microsoft.Azure.Management.Synapse branch 3 times, most recently from dc8939a to e88a082 Compare June 29, 2021 12:21
kinelski and others added 23 commits June 29, 2021 07:02
…ctivity.Parent.SpanId (Azure#20434)

* Include ai.operation.parentId from ParentSpanId

* Refactor ParentSpanId test

* Revert unintentional change in TagTests

Co-authored-by: Magnus Gideryd <magnus.gideryd@visma.com>
* Continue renewing lock while processing

* Fix transaction tests

* Fix docs for SBClient
* Update AutoRest C# version to 3.0.0-beta.20210628.2

* Fix build

* Remove CodeGenSuppress from EventGrid

* Exclude Azure.Core.CodeGenSuppressAttribute from API listing

Co-authored-by: azure-sdk <azuresdk@microsoft.com>
* added key byte cache to the policy

* fixed a bug
* docstring fixes for Upload() and UploadAsync()

* fully qualified reference to BlockBlobClient

Co-authored-by: jschrepp-MSFT <41338290+jschrepp-MSFT@users.noreply.github.com>
- Replace myself with Anne as synapse owner as I'm off to adventures in Go-Land ™️

# All SDK Contribution checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.
- [ ] **Please open PR in `Draft` mode if it is:**
	- Work in progress or not intended to be merged.
	- Encountering multiple pipeline failures and working on fixes.
- [ ] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
- [ ] **I have read the [contribution guidelines](https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md).**
- [ ] **The pull request does not introduce [breaking changes](https://github.com/dotnet/corefx/blob/master/Documentation/coding-guidelines/breaking-change-rules.md).**

### [General Guidelines and Best Practices](https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md#general-guidelines)
- [ ] Title of the pull request is clear and informative.
- [ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, [see this page](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md).

### [Testing Guidelines](https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md#testing-guidelines)
- [ ] Pull request includes test coverage for the included changes.

### [SDK Generation Guidelines](https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md#sdk-generation-guidelines)
- [ ] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
- [ ] The `*.csproj` and `AssemblyInfo.cs` files have been updated with the new version of the SDK. Please double check nuget.org current release version.

## Additional management plane SDK specific contribution checklist: 
Note: Only applies to `Microsoft.Azure.Management.[RP]` or `Azure.ResourceManager.[RP]`
 
- [ ] Include updated [management metadata](https://github.com/Azure/azure-sdk-for-net/tree/main/eng/mgmt/mgmtmetadata).
- [ ] Update AzureRP.props to add/remove version info to maintain up to date API versions.

### Management plane SDK Troubleshooting
- If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add `new service` label and/or contact assigned reviewer.
- If the check fails at the `Verify Code Generation` step, please ensure:
	- Do not modify any code in generated folders.
	- Do not selectively include/remove generated files in the PR.
	- Do use `generate.ps1/cmd` to generate this PR instead of calling `autorest` directly.
	Please pay attention to the @microsoft.csharp version output after running `generate.ps1`. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.
	
	**Note: We have recently updated the PSH module called by `generate.ps1` to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command**:

	    `dotnet msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules`

### Old outstanding PR cleanup
 Please note:
	If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.
* Add System.Text.Json converter for EventGridEvent

* Usings

* Fix docs

* Use more efficient parse
Co-authored-by: Christopher Scott <chriscott@hotmail.com>
Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
- Update AutoRest C# version to 3.0.0-beta.20210628.4
- Fix WebPubSub to expect new generated code patterns
Using the same build tool version for mgmt track 1 build prop
… SQL DW Gen3 API (2020-04-01-preview) (Azure#21769)

* [Synapse] - Build SDK based on 2021-04-01-preview and add SQL v3 support

* Update session records

* Regenerate code based on the latest swagger

* Minor fix

Co-authored-by: Dongwei Wang <dongwwa@microsoft.com>
@openapi-sdkautomation openapi-sdkautomation bot force-pushed the sdkAuto/14814/Microsoft.Azure.Management.Synapse branch from e88a082 to 3f4296c Compare June 30, 2021 08:05
Merge 280142b80c1ebd805abd27f41054a976cf850538 into 91ac14531f0d05b3d6fcf4a817ea0defde59fe63
@openapi-sdkautomation openapi-sdkautomation bot force-pushed the sdkAuto/14814/Microsoft.Azure.Management.Synapse branch from 3f4296c to ad9402e Compare June 30, 2021 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.