Remove 2nd N.B.T.P package #2984

heng-liu · 2019-08-05T23:34:52Z

As there is no more NuGet insertion into SDK 2.x, there is no need to generate the NuGet.Build.Tasks.Pack.Sdk2x package in our code.

Bug

Fixes: NuGet/Home/8403

Regression: No

Last working version:
How are we preventing it in future:

Fix

Remove generating process for 2nd N.B.T.P package.
Download only one version of SDK(3.0) into cli folder.
Download SDK(2.2.3) runtime into cli folder for running netcoreapp2.1 apps.
Change NuGet.XPlat.FuncTest.csproj to test for SDK3 only.
Change Dotnet.Integration.Test to test for SDK3 only.
1. Change csproj file to target only netcoreapp3.0
2. Patch only for SDK3
3. Remove "#if NETCORE3_0" and "#else" from Dotnet.Integration.Test.
4. Remove generating temp global.json from MsbuildIntegrationTestFixture.cs for testing
Remove PackCommand_PackAsMsbuildTargets test.

Testing/Validation

Tests Added: No
Reason for not adding tests:
Validation:

…Integration test for SDK3 only

zivkan · 2019-08-05T23:50:36Z

Please don't add us as reviews unless it's ready for review, in which case you should take it out of draft mode.

…tcoreapp2.1 dlls

build/common.project.props

scripts/funcTests/runFuncTests.sh

nkolev92

A few small questions.

build/common.project.props

build/common.ps1

scripts/funcTests/runFuncTests.sh

…ing channel instead of version

nkolev92

👍

* remove 2nd N.B.T.P package; change Dotnet.Integration.Test and NuGet.XPlat.FuncTest to testing for SDK3 only; download SDK2 runtime only

Remove 2nd N.B.T.P package (#2984) remove WorkaroundNetStandard target, change SDK for build from 3.0 preview to 3.1 stable (#3161) * remove WorkaroundNetStandard target, change SDK for build from 3.0 preview to 3.1 stable version, fix error; change LockSDKVersion default value from empty string to false; apply Linux workaround in my change Retarget to netcore5.0 (#3162) * retarget to netcore5.0; Linux script workaround need to apply for downloading SDK for build add pkcs and cng packages Temporary fix on patching SDK, add System.Security.Cryptography.Pkcs.dll and update deps.json, use dll from .nuget/packages Address PR comments implement add cert to store on Mac; display openssl version (#3166) Implement timestamp integrity verification; Implement an equivalent NativeCms; enable signing APIs and tests (#3168) * implement timestamp integrity verification; implement ManagedCms; enable signing APIs and tests fix xplat verification branch after rebase (#3191) Fixes: NuGet/Home#9012 check different cross-platform error messages for self-signed cert test (#3208) Fixes: NuGet/Home#8933 Xplat Signing/Verification : Fix broken tests for setting privatekey of a X509Certificate2 (#3195) use workaround to set private key for X509Certificate2 (netcore), change ToRSA to workaround for netcore(especially for non-windows) enable PathTooLongException test (#3216) Fixes: NuGet/Home#8920 enable TrustedSignerActionsProvider on netcore, along with tests (#3213) Fixes: NuGet/Home#8921 Enable SignedPackageIntegrityVerificationTests for netcore5.0 (#3220) Enable SignedPackageIntegrityVerificationTests for netcore, remove extra preprocessors Enable timestamp provider test and fix 3 broken tests (#3210) enable all unit tests; enable 8 more tests; enable timestampProviderTest; fix 3 broken tests in TimestampProviderTests Fix 4 tests in SignatureTrustAndValidityVerificationProviderTests (#3242) fix untrusted msg for different platforms fixed broken tests using utility methods (#3263) disable outdated tests (#3274) enable 4 tests on Mac (#3275) fix 5 broken tests in SignatureTrustAndValidityVerificationProviderTests, add workaround for Linux (#3252) fix broken test case ExecuteCommandAsync_WithAmbiguousMatch_ThrowsAsync (#3291)

This reverts commit 8a3791e.

Remove 2nd N.B.T.P package (#2984) remove WorkaroundNetStandard target, change SDK for build from 3.0 preview to 3.1 stable (#3161) * remove WorkaroundNetStandard target, change SDK for build from 3.0 preview to 3.1 stable version, fix error; change LockSDKVersion default value from empty string to false; apply Linux workaround in my change Retarget to netcore5.0 (#3162) * retarget to netcore5.0; Linux script workaround need to apply for downloading SDK for build add pkcs and cng packages Temporary fix on patching SDK, add System.Security.Cryptography.Pkcs.dll and update deps.json, use dll from .nuget/packages Address PR comments implement add cert to store on Mac; display openssl version (#3166) Implement timestamp integrity verification; Implement an equivalent NativeCms; enable signing APIs and tests (#3168) * implement timestamp integrity verification; implement ManagedCms; enable signing APIs and tests fix xplat verification branch after rebase (#3191) Fixes: NuGet/Home#9012 check different cross-platform error messages for self-signed cert test (#3208) Fixes: NuGet/Home#8933 Xplat Signing/Verification : Fix broken tests for setting privatekey of a X509Certificate2 (#3195) use workaround to set private key for X509Certificate2 (netcore), change ToRSA to workaround for netcore(especially for non-windows) enable PathTooLongException test (#3216) Fixes: NuGet/Home#8920 enable TrustedSignerActionsProvider on netcore, along with tests (#3213) Fixes: NuGet/Home#8921 Enable SignedPackageIntegrityVerificationTests for netcore5.0 (#3220) Enable SignedPackageIntegrityVerificationTests for netcore, remove extra preprocessors Enable timestamp provider test and fix 3 broken tests (#3210) enable all unit tests; enable 8 more tests; enable timestampProviderTest; fix 3 broken tests in TimestampProviderTests Fix 4 tests in SignatureTrustAndValidityVerificationProviderTests (#3242) fix untrusted msg for different platforms fixed broken tests using utility methods (#3263) disable outdated tests (#3274) enable 4 tests on Mac (#3275) fix 5 broken tests in SignatureTrustAndValidityVerificationProviderTests, add workaround for Linux (#3252) fix broken test case ExecuteCommandAsync_WithAmbiguousMatch_ThrowsAsync (#3291)

* Signing: Support signature verification on .NET Core Remove 2nd N.B.T.P package (#2984) remove WorkaroundNetStandard target, change SDK for build from 3.0 preview to 3.1 stable (#3161) * remove WorkaroundNetStandard target, change SDK for build from 3.0 preview to 3.1 stable version, fix error; change LockSDKVersion default value from empty string to false; apply Linux workaround in my change Retarget to netcore5.0 (#3162) * retarget to netcore5.0; Linux script workaround need to apply for downloading SDK for build add pkcs and cng packages Temporary fix on patching SDK, add System.Security.Cryptography.Pkcs.dll and update deps.json, use dll from .nuget/packages Address PR comments implement add cert to store on Mac; display openssl version (#3166) Implement timestamp integrity verification; Implement an equivalent NativeCms; enable signing APIs and tests (#3168) * implement timestamp integrity verification; implement ManagedCms; enable signing APIs and tests fix xplat verification branch after rebase (#3191) Fixes: NuGet/Home#9012 check different cross-platform error messages for self-signed cert test (#3208) Fixes: NuGet/Home#8933 Xplat Signing/Verification : Fix broken tests for setting privatekey of a X509Certificate2 (#3195) use workaround to set private key for X509Certificate2 (netcore), change ToRSA to workaround for netcore(especially for non-windows) enable PathTooLongException test (#3216) Fixes: NuGet/Home#8920 enable TrustedSignerActionsProvider on netcore, along with tests (#3213) Fixes: NuGet/Home#8921 Enable SignedPackageIntegrityVerificationTests for netcore5.0 (#3220) Enable SignedPackageIntegrityVerificationTests for netcore, remove extra preprocessors Enable timestamp provider test and fix 3 broken tests (#3210) enable all unit tests; enable 8 more tests; enable timestampProviderTest; fix 3 broken tests in TimestampProviderTests Fix 4 tests in SignatureTrustAndValidityVerificationProviderTests (#3242) fix untrusted msg for different platforms fixed broken tests using utility methods (#3263) disable outdated tests (#3274) enable 4 tests on Mac (#3275) fix 5 broken tests in SignatureTrustAndValidityVerificationProviderTests, add workaround for Linux (#3252) fix broken test case ExecuteCommandAsync_WithAmbiguousMatch_ThrowsAsync (#3291) * Enable test ExecuteCommandAsync_WithMultiplePackagesAndInvalidCertificate_RaisesErrorsOnceAsync (#3342) * enable a test, change the comments; extend test limitation on Linux * Updated SDK version and removed the hardcoded version when reading from JSON file (#3372) * update Pkcs package to the preview3 version (#3382) * fix 2 warnings in CodeAnalysis (#3388) * fix 2 warnings in CodeAnalysis * disable dynamic revoke tests on Mac (#3373) * fix 1 test (#3371) * Fix more warnings reported by CodeAnalysis (#3393) * fix string warnings raised by CodeAnalysis * Retarget xplat verification to netcoreapp5.0 (#3386) * retarget netcoreapp5.0 (a workaround for net5.0) * fix all the rest warnings raised by code analysis (#3401) * Suppress CA1307 warning for string.GetHashCode() method (#3404) * Linux test failure due to generic exception (#3405) * add TFM netcoreapp5.0 to N.B.T.Console and N.P.Core projects (#3419) * add TFM netcoreapp5.0 to N.B.T.Console and N.P.Core projects * add PIN prompt for netcore (#3389) * Run dotnet nuget tests on multiple TFMs (#3387) * enabled mac assertions * Revert "enabled mac assertions" This reverts commit d8a52e2. * Enable test GetCertificateChain_WithUntrustedRoot_Throws on Mac (#3428) * run signing integration tests cross plat (#3415) * added GetNonce() to IRfc3161TimestampRequest interface (#3427) * disable test for netcore (#3445) * log Status and StatusInformation, fix 2 tests (#3268) * Disable verification during extraction for Mono, disable a test on Mono (#3451) * disable verification during extraction on mono,disable a mono test on Mac * adapt 2 newly added dotnet integration tests for multiple TFMs (#3460) * remove useless Sdk2x.targets * get TimestampTests working again (#3218) * get TimestampTests working again Fixes: NuGet/Home#8935 * change GetTimestampAsync into internal * fix runFuncTests.sh and InstallCLIforBuild.sh * address feedback * upgrade dotnet 5 to preview4 as preview5 is broken * Fix exception thrown in SigningTestFixture during disposing (#3464) Co-authored-by: Kartheek Penagamuri <52756182+kartheekp-ms@users.noreply.github.com> Co-authored-by: Andy Zivkovic <zivkan@users.noreply.github.com> Co-authored-by: Kat Marchán <kzm@zkat.tech>

remove 2nd N.B.T.P package, download only SDK3 in CLI, change Dotnet.…

2caac96

…Integration test for SDK3 only

heng-liu requested review from dominoFire, nkolev92, zivkan, dtivel and donnie-msft August 5, 2019 23:34

download 2 SDK versions in config.props

c30d566

heng-liu removed request for dominoFire, nkolev92, zivkan, dtivel and donnie-msft August 6, 2019 04:56

heng-liu added 2 commits August 6, 2019 10:56

download one SDK and change NuGet.XPlat.FuncTest to test for 1 SDK

49f4321

add downloading SDK2 runtime for running dotnet vstest commands on ne…

4e6779c

…tcoreapp2.1 dlls

heng-liu requested review from nkolev92, dtivel, zivkan, dominoFire and donnie-msft August 7, 2019 16:30

heng-liu marked this pull request as ready for review August 7, 2019 16:30

zivkan reviewed Aug 7, 2019

View reviewed changes

build/common.project.props Outdated Show resolved Hide resolved

scripts/funcTests/runFuncTests.sh Outdated Show resolved Hide resolved

remove CreatePackNupkg2X and add nopath for downloading SDK runtimes

ff5acea

heng-liu requested a review from zivkan August 7, 2019 23:40

nkolev92 reviewed Aug 8, 2019

View reviewed changes

build/common.project.props Outdated Show resolved Hide resolved

build/common.ps1 Outdated Show resolved Hide resolved

scripts/funcTests/runFuncTests.sh Outdated Show resolved Hide resolved

rename target to TestForLatestNetCoreOnly and download sdk runtime us…

1796ad9

…ing channel instead of version

heng-liu requested a review from nkolev92 August 8, 2019 18:34

nkolev92 approved these changes Aug 8, 2019

View reviewed changes

heng-liu merged this pull request into dev-feature-xplatVerification Aug 8, 2019

heng-liu added a commit that referenced this pull request Aug 8, 2019

Remove 2nd N.B.T.P package (#2984)

46cda53

* remove 2nd N.B.T.P package; change Dotnet.Integration.Test and NuGet.XPlat.FuncTest to testing for SDK3 only; download SDK2 runtime only

heng-liu added a commit that referenced this pull request Dec 15, 2019

Remove 2nd N.B.T.P package (#2984)

61493f1

* remove 2nd N.B.T.P package; change Dotnet.Integration.Test and NuGet.XPlat.FuncTest to testing for SDK3 only; download SDK2 runtime only

zkat pushed a commit that referenced this pull request Jan 16, 2020

Remove 2nd N.B.T.P package (#2984)

8a3791e

heng-liu mentioned this pull request Jan 17, 2020

fix xplat verification branch after rebase #3191

Merged

zkat pushed a commit that referenced this pull request Feb 20, 2020

Remove 2nd N.B.T.P package (#2984)

23a896d

heng-liu pushed a commit that referenced this pull request Mar 20, 2020

Revert "Remove 2nd N.B.T.P package (#2984)"

0dfd0c3

This reverts commit 8a3791e.

zkat added a commit that referenced this pull request Mar 20, 2020

Revert "Remove 2nd N.B.T.P package (#2984)"

6d006d3

This reverts commit 8a3791e.

kartheekp-ms pushed a commit that referenced this pull request Mar 28, 2020

Remove 2nd N.B.T.P package (#2984)

34ef47d

kartheekp-ms pushed a commit that referenced this pull request Apr 16, 2020

Remove 2nd N.B.T.P package (#2984)

30023ac

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove 2nd N.B.T.P package #2984

Remove 2nd N.B.T.P package #2984

heng-liu commented Aug 5, 2019 •

edited

Loading

zivkan commented Aug 5, 2019

nkolev92 left a comment

nkolev92 left a comment

Remove 2nd N.B.T.P package #2984

Remove 2nd N.B.T.P package #2984

Conversation

heng-liu commented Aug 5, 2019 • edited Loading

Bug

Fix

Testing/Validation

zivkan commented Aug 5, 2019

nkolev92 left a comment

Choose a reason for hiding this comment

nkolev92 left a comment

Choose a reason for hiding this comment

heng-liu commented Aug 5, 2019 •

edited

Loading