Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Level 1 chooses between trival and dense layout selection, depending on the layout score #3324

Closed
wants to merge 134 commits into from

Conversation

1ucian0
Copy link
Member

@1ucian0 1ucian0 commented Oct 25, 2019

On top of #3035, #3018, and #3321 (therefore, on hold).

Fixes #2845

@1ucian0
Copy link
Member Author

1ucian0 commented Nov 2, 2019

@kdk suggested a great possible optimization to rollback_if: Do not rollback (e.i. deepcopy) the dag if all the passes in the pass set are analysis pass (which is the case when layout selection).

Good news! Adding this optimization was trivial (see ec8e31a). I will rerun the tests.

@1ucian0
Copy link
Member Author

1ucian0 commented Nov 2, 2019

(because I'm getting full different set of values (probably related with changes in master or my machine is just less loaded) here are the new outputs:

Without rollback

The result is: 58.22561879

With rollback

The result is: 58.96733729300001

Comparing with level 2

Level 2 is running in: 346.168352814

Comparing against master

1.74x slower for qft.QftTranspileBench.time_ibmq_backend_transpile(2)

@1ucian0
Copy link
Member Author

1ucian0 commented Dec 30, 2019

Closing in favor of #3657

@1ucian0 1ucian0 closed this Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on hold Can not fix yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

optimization_level=1 always uses Trivial layout
2 participants