Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Purge some unused modules #26447

Merged
merged 1 commit into from
Aug 2, 2022
Merged

Chore: Purge some unused modules #26447

merged 1 commit into from
Aug 2, 2022

Conversation

tassoevan
Copy link
Contributor

@tassoevan tassoevan commented Aug 2, 2022

Proposed changes (including videos or screenshots)

The title says it all.

Issue(s)

Steps to test or reproduce

Further comments

Some React components appears to be are available via the barrel export pattern without a good reason, as in some cases ./MyComponent/MyComponent.tsx was imported instead of ./MyComponent/index.ts.

@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

Merging #26447 (ef496ef) into develop (0343424) will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #26447      +/-   ##
===========================================
+ Coverage    39.08%   39.10%   +0.01%     
===========================================
  Files          748      748              
  Lines        18647    18647              
  Branches      1424     1424              
===========================================
+ Hits          7288     7291       +3     
+ Misses       11137    11134       -3     
  Partials       222      222              
Flag Coverage Δ
e2e 39.10% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
apps/meteor/client/lib/rooms/roomTypes/public.ts 40.00% <0.00%> (-5.72%) ⬇️
apps/meteor/app/ui-utils/client/lib/openRoom.js 74.50% <0.00%> (-3.93%) ⬇️
apps/meteor/app/ui/client/lib/UserAction.ts 62.50% <0.00%> (-2.28%) ⬇️
...ps/meteor/app/ui-login/client/username/username.js 51.57% <0.00%> (-1.06%) ⬇️
...teor/app/ui-utils/client/lib/RoomHistoryManager.js 51.44% <0.00%> (-0.97%) ⬇️
apps/meteor/app/ui/client/views/app/room.js 49.59% <0.00%> (ø)
...ached-collection/client/models/CachedCollection.js 85.93% <0.00%> (+0.52%) ⬆️
...pps/meteor/app/ui-utils/client/lib/readMessages.js 64.55% <0.00%> (+2.53%) ⬆️
apps/meteor/app/ui-utils/client/lib/RoomManager.js 79.42% <0.00%> (+3.42%) ⬆️
apps/meteor/client/lib/meteorCallWrapper.ts 100.00% <0.00%> (+3.57%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

@tassoevan tassoevan force-pushed the refactor/purge-orphans branch from 38329b9 to ef496ef Compare August 2, 2022 18:10
@ggazzo ggazzo added the stat: ready to merge PR tested and approved waiting for merge label Aug 2, 2022
@tassoevan tassoevan marked this pull request as ready for review August 2, 2022 19:42
@tassoevan tassoevan requested review from a team as code owners August 2, 2022 19:42
@ggazzo ggazzo merged commit 4f18995 into develop Aug 2, 2022
@ggazzo ggazzo deleted the refactor/purge-orphans branch August 2, 2022 20:57
gabriellsh added a commit that referenced this pull request Aug 4, 2022
…ove-e2ee-threadlist

* 'develop' of github.com:RocketChat/Rocket.Chat: (200 commits)
  [FIX] Undefined MediaDevices error on HTTP (#26396)
  Chore: Codecov threshold (#26477)
  Chore: Tests intermitences (#26464)
  [FIX] Don't give errors on outbound voip call Request Terminated (#26373)
  Chore: Use Docker compose on CI (#26437)
  [FIX] DialPad call button from end to center (#26459)
  Chore: Parallelize e2e tests (#26390)
  [IMPROVE] use enter key to call using DialPad (#26454)
  Chore: Accounts/token to TS (#26434)
  Chore: Purge some unused modules (#26447)
  i18n: Language update from LingoHub 🤖 on 2022-08-01Z (#26429)
  Chore: Add end-to-end tests to teams listing in the `directory` endpoint (#26347)
  Chore: Cache playwright (#26432)
  [FIX] Empty results on `im.list` endpoint (#26438)
  [IMPROVE] Upgrade nivo and React Query (#26338)
  Chore: Upgrade Fuselage packages to next dist-tag (#26435)
  Chore: Omnichannel endpoints e2e tests (#26376)
  Chore: Refactor UserInfo to typescript (#26323)
  Chore: Rewrite Location modal to React (#26196)
  Chore: Rewrite SaveToWebdav Modal to React Component (#24365)
  ...
gabriellsh added a commit that referenced this pull request Aug 8, 2022
…homepage

* 'develop' of github.com:RocketChat/Rocket.Chat: (39 commits)
  Chore: ESLint warnings (#26504)
  Chore: Remove settings Fibers usage (#26465)
  Chore: Refactor create-target-channel util (#26493)
  Chore: useEndpointData deprecation (#26494)
  [NEW] Surface featured apps endpoint  (#26416)
  [FIX] Request at least one field in the payload of `/v1/users.setStatus` (#26490)
  Chore: Exit process on `unhandledRejection` on CI (#26467)
  [FIX] Clear push token on save user password (#26466)
  [FIX] Undefined MediaDevices error on HTTP (#26396)
  Chore: Codecov threshold (#26477)
  Chore: Tests intermitences (#26464)
  [FIX] Don't give errors on outbound voip call Request Terminated (#26373)
  Chore: Use Docker compose on CI (#26437)
  [FIX] DialPad call button from end to center (#26459)
  Chore: Parallelize e2e tests (#26390)
  [IMPROVE] use enter key to call using DialPad (#26454)
  Chore: Accounts/token to TS (#26434)
  Chore: Purge some unused modules (#26447)
  i18n: Language update from LingoHub 🤖 on 2022-08-01Z (#26429)
  Chore: Add end-to-end tests to teams listing in the `directory` endpoint (#26347)
  ...
@murtaza98 murtaza98 mentioned this pull request Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants