Chore: Rewrite Location modal to React #26196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabriellsh
force-pushed
the
refactor/locationModal
branch
from
b96bf61 to
dd82bda
Compare
gabriellsh
force-pushed
the
refactor/locationModal
branch
from
742916d to
78d0301
Compare
dougfabris
requested changes
Jul 28, 2022
apps/meteor/client/views/room/ShareLocation/ShareLocationModal.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/client/views/room/ShareLocation/ShareLocationModal.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/client/views/room/ShareLocation/ShareLocationModal.tsx
Outdated
Show resolved
Hide resolved
dougfabris
changed the title
…ctor/locationModal * 'develop' of github.com:RocketChat/Rocket.Chat: i18n: Makes the text less ambiguous (#20895) Chore: Missing some English translation keywords (#20131) Chore: Exclude private/public folders from typecheck (#26399) [NEW] Marketplace apps page new list view layout (#26181) Chore: Rewrite custom OAuth Modals to react (#26204) i18n: Manual sync from LingoHub (#26397) Chore: Options in BaseRaw model could possibly be undefined (#26395) [IMPROVE] Use single change stream to watch DB changes (#26336) [IMPROVE] Remove public and node_modules folders from TypeScript server watcher (#26391)
dougfabris
approved these changes
Jul 29, 2022
ggazzo
added
stat: ready to merge
Codecov Report
@@ Coverage Diff @@
## develop #26196 +/- ##
===========================================
+ Coverage 38.88% 38.95% +0.06%
===========================================
Files 751 753 +2
Lines 18797 18766 -31
Branches 1413 1414 +1
===========================================
+ Hits 7309 7310 +1
+ Misses 11271 11238 -33
- Partials 217 218 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. |
ggazzo
approved these changes
Aug 1, 2022
gabriellsh
added a commit
that referenced
this pull request
Aug 2, 2022
…history * 'develop' of github.com:RocketChat/Rocket.Chat: Chore: Cache playwright (#26432) [FIX] Empty results on `im.list` endpoint (#26438) [IMPROVE] Upgrade nivo and React Query (#26338) Chore: Upgrade Fuselage packages to next dist-tag (#26435) Chore: Omnichannel endpoints e2e tests (#26376) Chore: Refactor UserInfo to typescript (#26323) Chore: Rewrite Location modal to React (#26196) Chore: Rewrite SaveToWebdav Modal to React Component (#24365) [IMPROVE] validateParams to accept different validators per request method (#26357) Regression: Fix spacing problem on AppStatus component (#26421) Chore: Convert client/views/account/security folder to ts (#26413) i18n: Makes the text less ambiguous (#20895) Chore: Missing some English translation keywords (#20131) Chore: Exclude private/public folders from typecheck (#26399) [NEW] Marketplace apps page new list view layout (#26181) Chore: Rewrite custom OAuth Modals to react (#26204) i18n: Manual sync from LingoHub (#26397) Chore: Options in BaseRaw model could possibly be undefined (#26395) [IMPROVE] Use single change stream to watch DB changes (#26336)
carlosrodrigues94
pushed a commit
that referenced
this pull request
Aug 3, 2022
Co-authored-by: dougfabris <devfabris@gmail.com>
gabriellsh
added a commit
that referenced
this pull request
Aug 4, 2022
…ove-e2ee-threadlist * 'develop' of github.com:RocketChat/Rocket.Chat: (200 commits) [FIX] Undefined MediaDevices error on HTTP (#26396) Chore: Codecov threshold (#26477) Chore: Tests intermitences (#26464) [FIX] Don't give errors on outbound voip call Request Terminated (#26373) Chore: Use Docker compose on CI (#26437) [FIX] DialPad call button from end to center (#26459) Chore: Parallelize e2e tests (#26390) [IMPROVE] use enter key to call using DialPad (#26454) Chore: Accounts/token to TS (#26434) Chore: Purge some unused modules (#26447) i18n: Language update from LingoHub 🤖 on 2022-08-01Z (#26429) Chore: Add end-to-end tests to teams listing in the `directory` endpoint (#26347) Chore: Cache playwright (#26432) [FIX] Empty results on `im.list` endpoint (#26438) [IMPROVE] Upgrade nivo and React Query (#26338) Chore: Upgrade Fuselage packages to next dist-tag (#26435) Chore: Omnichannel endpoints e2e tests (#26376) Chore: Refactor UserInfo to typescript (#26323) Chore: Rewrite Location modal to React (#26196) Chore: Rewrite SaveToWebdav Modal to React Component (#24365) ...
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments