Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Not possible to deactivate users #26323

Merged
merged 13 commits into from
Aug 1, 2022
Merged

[FIX] Not possible to deactivate users #26323

merged 13 commits into from
Aug 1, 2022

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented Jul 20, 2022

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

  • Go to admin
  • Go to the users tab
  • try to deactivate a user
  • try to deactivate a user that is the last owner of a channel

Further comments

@dougfabris dougfabris added this to the 5.1.0 milestone Jul 20, 2022
@dougfabris dougfabris changed the title Chore: Convert UserInfo to typrescript Chore: Convert UserInfo to typescript Jul 20, 2022
@dougfabris dougfabris changed the title Chore: Convert UserInfo to typescript Chore: Refactor UserInfo to typescript Jul 21, 2022
@dougfabris dougfabris modified the milestones: 5.1.0, 5.0.1 Jul 22, 2022
@dougfabris dougfabris marked this pull request as ready for review July 26, 2022 23:05
@dougfabris dougfabris requested review from a team as code owners July 26, 2022 23:05
@codecov
Copy link

codecov bot commented Jul 28, 2022

Codecov Report

Merging #26323 (5f021eb) into develop (7794a0b) will increase coverage by 0.08%.
The diff coverage is 46.15%.

@@             Coverage Diff             @@
##           develop   #26323      +/-   ##
===========================================
+ Coverage    38.90%   38.99%   +0.08%     
===========================================
  Files          751      746       -5     
  Lines        18797    18680     -117     
  Branches      1413     1423      +10     
===========================================
- Hits          7313     7284      -29     
+ Misses       11267    11174      -93     
- Partials       217      222       +5     
Flag Coverage Δ
e2e 38.99% <46.15%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...views/room/contextualBar/Info/RoomInfo/RoomInfo.js 87.50% <ø> (ø)
...ws/admin/users/hooks/useChangeAdminStatusAction.ts 42.85% <42.85%> (ø)
...ews/admin/users/hooks/useChangeUserStatusAction.ts 42.85% <42.85%> (ø)
apps/meteor/client/hooks/useUserCustomFields.ts 46.66% <46.66%> (ø)
...ps/meteor/client/lib/utils/getUserEmailVerified.ts 100.00% <100.00%> (ø)
...textualBar/RoomMembers/List/RoomMembersWithData.js 91.89% <100.00%> (ø)
apps/meteor/client/hooks/useTimezoneTime.ts 0.00% <0.00%> (-76.93%) ⬇️
apps/meteor/client/hooks/useUTCClock.ts 33.33% <0.00%> (-66.67%) ⬇️
apps/meteor/app/ui-utils/client/lib/RoomManager.js 76.00% <0.00%> (-2.29%) ⬇️
apps/meteor/app/ui/client/views/app/room.js 49.38% <0.00%> (-0.21%) ⬇️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

@ggazzo ggazzo modified the milestones: 5.0.1, 5.1.0 Aug 1, 2022
@ggazzo ggazzo added the stat: ready to merge PR tested and approved waiting for merge label Aug 1, 2022
@kodiakhq kodiakhq bot merged commit 355819e into develop Aug 1, 2022
@kodiakhq kodiakhq bot deleted the chore/user-info branch August 1, 2022 15:46
@dougfabris dougfabris changed the title Chore: Refactor UserInfo to typescript [FIX] Not possible to deactivate users Aug 1, 2022
@dougfabris dougfabris modified the milestones: 5.1.0, 5.0.1 Aug 1, 2022
@murtaza98 murtaza98 mentioned this pull request Aug 2, 2022
gabriellsh added a commit that referenced this pull request Aug 2, 2022
…history

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Chore: Cache playwright (#26432)
  [FIX] Empty results on `im.list` endpoint (#26438)
  [IMPROVE] Upgrade nivo and React Query (#26338)
  Chore: Upgrade Fuselage packages to next dist-tag (#26435)
  Chore: Omnichannel endpoints e2e tests (#26376)
  Chore: Refactor UserInfo to typescript (#26323)
  Chore: Rewrite Location modal to React (#26196)
  Chore: Rewrite SaveToWebdav Modal to React Component (#24365)
  [IMPROVE] validateParams to accept different validators per request method (#26357)
  Regression: Fix spacing problem on AppStatus component (#26421)
  Chore: Convert client/views/account/security folder to ts (#26413)
  i18n: Makes the text less ambiguous (#20895)
  Chore: Missing some English translation keywords (#20131)
  Chore: Exclude private/public folders from typecheck (#26399)
  [NEW] Marketplace apps page new list view layout (#26181)
  Chore: Rewrite custom OAuth Modals to react (#26204)
  i18n: Manual sync from LingoHub (#26397)
  Chore: Options in BaseRaw model could possibly be undefined (#26395)
  [IMPROVE] Use single change stream to watch DB changes (#26336)
gabriellsh added a commit that referenced this pull request Aug 4, 2022
…ove-e2ee-threadlist

* 'develop' of github.com:RocketChat/Rocket.Chat: (200 commits)
  [FIX] Undefined MediaDevices error on HTTP (#26396)
  Chore: Codecov threshold (#26477)
  Chore: Tests intermitences (#26464)
  [FIX] Don't give errors on outbound voip call Request Terminated (#26373)
  Chore: Use Docker compose on CI (#26437)
  [FIX] DialPad call button from end to center (#26459)
  Chore: Parallelize e2e tests (#26390)
  [IMPROVE] use enter key to call using DialPad (#26454)
  Chore: Accounts/token to TS (#26434)
  Chore: Purge some unused modules (#26447)
  i18n: Language update from LingoHub 🤖 on 2022-08-01Z (#26429)
  Chore: Add end-to-end tests to teams listing in the `directory` endpoint (#26347)
  Chore: Cache playwright (#26432)
  [FIX] Empty results on `im.list` endpoint (#26438)
  [IMPROVE] Upgrade nivo and React Query (#26338)
  Chore: Upgrade Fuselage packages to next dist-tag (#26435)
  Chore: Omnichannel endpoints e2e tests (#26376)
  Chore: Refactor UserInfo to typescript (#26323)
  Chore: Rewrite Location modal to React (#26196)
  Chore: Rewrite SaveToWebdav Modal to React Component (#24365)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
eng day stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants