Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Rewrite SaveToWebdav Modal to React Component #24365

Merged
merged 6 commits into from
Aug 1, 2022

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented Jan 31, 2022

Proposed changes (including videos or screenshots)

before

Screen Shot 2022-01-31 at 11 02 34

after

Screen Shot 2022-01-31 at 10 58 04

Issue(s)

Steps to test or reproduce

  • Make sure to enable Webdav and add at least one account
  • Upload a file into a channel and then Save to WebDAV

Screen Shot 2022-01-31 at 11 01 28

Further comments

@dougfabris dougfabris force-pushed the improve/saveToWebdav branch from 42b4954 to c0015cc Compare July 5, 2022 18:49
@dougfabris dougfabris requested review from a team as code owners July 5, 2022 18:49
@dougfabris dougfabris added this to the 5.1.0 milestone Jul 6, 2022
@dougfabris dougfabris changed the title [IMPROVE] Rewrite SaveToWebdav Modal to React Component Chore: Rewrite SaveToWebdav Modal to React Component Jul 28, 2022
@codecov
Copy link

codecov bot commented Jul 29, 2022

Codecov Report

Merging #24365 (ec527b4) into develop (b9f5bcc) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #24365      +/-   ##
===========================================
- Coverage    38.90%   38.90%   -0.01%     
===========================================
  Files          751      751              
  Lines        18797    18795       -2     
  Branches      1413     1413              
===========================================
- Hits          7313     7312       -1     
+ Misses       11267    11266       -1     
  Partials       217      217              
Flag Coverage Δ
e2e 38.90% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
apps/meteor/app/webdav/client/index.js 36.36% <ø> (+5.59%) ⬆️
...app/ui-message/client/popup/messagePopupChannel.js 50.00% <0.00%> (-50.00%) ⬇️
apps/meteor/client/lib/utils/waitUntilFind.ts 75.00% <0.00%> (-25.00%) ⬇️
...pps/meteor/app/ui-utils/client/lib/readMessages.js 62.02% <0.00%> (-2.54%) ⬇️
apps/meteor/app/apps/client/orchestrator.ts 32.43% <0.00%> (ø)
apps/meteor/app/ui/client/views/app/room.js 49.79% <0.00%> (+0.20%) ⬆️
apps/meteor/app/ui-utils/client/lib/RoomManager.js 77.71% <0.00%> (+1.71%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@dougfabris dougfabris force-pushed the improve/saveToWebdav branch from 973a893 to ec527b4 Compare July 29, 2022 18:40
@dougfabris dougfabris requested a review from gabriellsh July 29, 2022 20:27
@ggazzo ggazzo added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Jul 29, 2022
@kodiakhq kodiakhq bot merged commit a40eba3 into develop Aug 1, 2022
@kodiakhq kodiakhq bot deleted the improve/saveToWebdav branch August 1, 2022 13:38
gabriellsh added a commit that referenced this pull request Aug 2, 2022
…history

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Chore: Cache playwright (#26432)
  [FIX] Empty results on `im.list` endpoint (#26438)
  [IMPROVE] Upgrade nivo and React Query (#26338)
  Chore: Upgrade Fuselage packages to next dist-tag (#26435)
  Chore: Omnichannel endpoints e2e tests (#26376)
  Chore: Refactor UserInfo to typescript (#26323)
  Chore: Rewrite Location modal to React (#26196)
  Chore: Rewrite SaveToWebdav Modal to React Component (#24365)
  [IMPROVE] validateParams to accept different validators per request method (#26357)
  Regression: Fix spacing problem on AppStatus component (#26421)
  Chore: Convert client/views/account/security folder to ts (#26413)
  i18n: Makes the text less ambiguous (#20895)
  Chore: Missing some English translation keywords (#20131)
  Chore: Exclude private/public folders from typecheck (#26399)
  [NEW] Marketplace apps page new list view layout (#26181)
  Chore: Rewrite custom OAuth Modals to react (#26204)
  i18n: Manual sync from LingoHub (#26397)
  Chore: Options in BaseRaw model could possibly be undefined (#26395)
  [IMPROVE] Use single change stream to watch DB changes (#26336)
carlosrodrigues94 pushed a commit that referenced this pull request Aug 3, 2022
Co-authored-by: Pierre Lehnen <55164754+pierre-lehnen-rc@users.noreply.github.com>
gabriellsh added a commit that referenced this pull request Aug 4, 2022
…ove-e2ee-threadlist

* 'develop' of github.com:RocketChat/Rocket.Chat: (200 commits)
  [FIX] Undefined MediaDevices error on HTTP (#26396)
  Chore: Codecov threshold (#26477)
  Chore: Tests intermitences (#26464)
  [FIX] Don't give errors on outbound voip call Request Terminated (#26373)
  Chore: Use Docker compose on CI (#26437)
  [FIX] DialPad call button from end to center (#26459)
  Chore: Parallelize e2e tests (#26390)
  [IMPROVE] use enter key to call using DialPad (#26454)
  Chore: Accounts/token to TS (#26434)
  Chore: Purge some unused modules (#26447)
  i18n: Language update from LingoHub 🤖 on 2022-08-01Z (#26429)
  Chore: Add end-to-end tests to teams listing in the `directory` endpoint (#26347)
  Chore: Cache playwright (#26432)
  [FIX] Empty results on `im.list` endpoint (#26438)
  [IMPROVE] Upgrade nivo and React Query (#26338)
  Chore: Upgrade Fuselage packages to next dist-tag (#26435)
  Chore: Omnichannel endpoints e2e tests (#26376)
  Chore: Refactor UserInfo to typescript (#26323)
  Chore: Rewrite Location modal to React (#26196)
  Chore: Rewrite SaveToWebdav Modal to React Component (#24365)
  ...
@murtaza98 murtaza98 mentioned this pull request Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants