Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: removing useEndpointData from license api #26634

Merged
merged 6 commits into from
Nov 21, 2022

Conversation

hugocostadev
Copy link
Contributor

@hugocostadev hugocostadev commented Aug 19, 2022

Proposed changes (including videos or screenshots)

The deprecated hook useEndpointData was removed and changed to useMethod + useQueryseparated in a hook.

In useQuery options we added an option to keep the cache as Infinity until the queries are invalidated or the page refreshes, also the query keys were changed to consolidate the keys and manage the cache in the best way possible to avoid unnecessary API calls.

In settings changed or user action that impact the License status was added a method to invalidate the cache for license query keys

E.g: queryClient.invalidateQueries(['licenses']);

Issue(s)

Steps to test or reproduce

Further comments

@codecov
Copy link

codecov bot commented Aug 22, 2022

Codecov Report

Merging #26634 (fb34a4c) into develop (90fe2ed) will increase coverage by 0.83%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #26634      +/-   ##
===========================================
+ Coverage    40.48%   41.32%   +0.83%     
===========================================
  Files          840      814      -26     
  Lines        18329    17833     -496     
  Branches      2052     1987      -65     
===========================================
- Hits          7421     7369      -52     
+ Misses       10622    10177     -445     
- Partials       286      287       +1     
Flag Coverage Δ
e2e 41.32% <100.00%> (+0.83%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@hugocostadev hugocostadev marked this pull request as ready for review August 22, 2022 15:41
@hugocostadev hugocostadev requested a review from a team as a code owner August 22, 2022 15:41
@ggazzo ggazzo added this to the 5.4.0 milestone Nov 2, 2022
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Nov 18, 2022
apps/meteor/client/hooks/useIsEnterprise.ts Outdated Show resolved Hide resolved
apps/meteor/client/hooks/useLicense.ts Outdated Show resolved Hide resolved
apps/meteor/client/hooks/useLicense.ts Outdated Show resolved Hide resolved
@kodiakhq kodiakhq bot merged commit 9256e1f into develop Nov 21, 2022
@kodiakhq kodiakhq bot deleted the chore/license-removing-use-endpoint-data branch November 21, 2022 14:49
gabriellsh added a commit that referenced this pull request Nov 21, 2022
…age-ignore-reactivity

* 'develop' of github.com:RocketChat/Rocket.Chat: (23 commits)
  Chore: removing useEndpointData from license api (#26634)
  Chore: Create unique index for `E2EKey` field (#27301)
  [FIX] LDAP "Sync Roles" option doesn't work for custom roles (#26842)
  Chore: UserAvatar wrapper missing key in RoomForeword (#27300)
  Chore: Add deprecation warning to settings (#27295)
  Chore: Refactor LeaveTeam to Typescript (#27197)
  [FIX] Sidebar context menu in searchList (#23830)
  [NEW] Federation events coverage expansion (#27119)
  [FIX] Message Parser version upgrade (#27284)
  [FIX] Replace regex not compatible with safari (#27294)
  [NEW] Emphasis Elements (italic, strike and bold) in Message Parser Components (#27003)
  [FIX] Set default value "false" for global search. (#25568)
  Regression: Custom fields form not showing in user profile nor admin (#27244)
  [FIX] Sort RecordList items in REVERSE chronological order, not FORWARD (#27201)
  Chore: Remove unused css (#27289)
  Chore: also send thread to channel translations (#27242)
  [FIX] Marketplace app details page back-button behavior (#27062)
  Chore: Add tests for omni-jobs & add more context in system messages for jobs (#27048)
  Chore: Fix missing license for forks (#27258)
  i18n: Language update from LingoHub 🤖 on 2022-11-14Z (#27255)
  ...
@ggazzo ggazzo mentioned this pull request Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
eng day stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants