-
Notifications
You must be signed in to change notification settings - Fork 10.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Sort RecordList items in REVERSE chronological order, not FORWARD #27201
[FIX] Sort RecordList items in REVERSE chronological order, not FORWARD #27201
Conversation
@tassoevan This relates to commit 4bfa63c (client/lib/lists/RecordList.ts:36). Please confirm whether "_updatedAt DESC" was the intended sort, or whether you really do want "_updatedAt ASC". |
788030e
to
3bfdc6c
Compare
test-ee has failed twice, with From https://github.com/RocketChat/Rocket.Chat/actions/runs/3470198854/jobs/5798656544
How can we move this PR forward? |
Hey @nmagedman don't worry about that. We are aware of the Btw, thanks for the contribution :) ! |
…age-ignore-reactivity * 'develop' of github.com:RocketChat/Rocket.Chat: (23 commits) Chore: removing useEndpointData from license api (#26634) Chore: Create unique index for `E2EKey` field (#27301) [FIX] LDAP "Sync Roles" option doesn't work for custom roles (#26842) Chore: UserAvatar wrapper missing key in RoomForeword (#27300) Chore: Add deprecation warning to settings (#27295) Chore: Refactor LeaveTeam to Typescript (#27197) [FIX] Sidebar context menu in searchList (#23830) [NEW] Federation events coverage expansion (#27119) [FIX] Message Parser version upgrade (#27284) [FIX] Replace regex not compatible with safari (#27294) [NEW] Emphasis Elements (italic, strike and bold) in Message Parser Components (#27003) [FIX] Set default value "false" for global search. (#25568) Regression: Custom fields form not showing in user profile nor admin (#27244) [FIX] Sort RecordList items in REVERSE chronological order, not FORWARD (#27201) Chore: Remove unused css (#27289) Chore: also send thread to channel translations (#27242) [FIX] Marketplace app details page back-button behavior (#27062) Chore: Add tests for omni-jobs & add more context in system messages for jobs (#27048) Chore: Fix missing license for forks (#27258) i18n: Language update from LingoHub 🤖 on 2022-11-14Z (#27255) ...
Proposed changes (including videos or screenshots)
Sort items in the Files sidebar in reverse chronological order (newest at top, oldest at bottom), as it did before RC v3.11.0.
Issue(s)
Fixes #27185
Steps to test or reproduce
See Issue
Further comments
RecordList is a generic widget for use in several parts of the codebase. It remains to be seen whether Date DESC is the correct sort order for all of them, although it does seem reasonable that it ought to be.