Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Custom fields form not showing in user profile nor admin #27244

Merged
merged 4 commits into from
Nov 17, 2022

Conversation

gabriellsh
Copy link
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@gabriellsh gabriellsh requested a review from a team as a code owner November 11, 2022 18:39
@codecov
Copy link

codecov bot commented Nov 12, 2022

Codecov Report

Merging #27244 (9820f7e) into develop (54b2b7f) will decrease coverage by 0.04%.
The diff coverage is n/a.

❗ Current head 9820f7e differs from pull request most recent head 9c0324b. Consider uploading reports for the commit 9c0324b to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27244      +/-   ##
===========================================
- Coverage    40.24%   40.20%   -0.05%     
===========================================
  Files          847      847              
  Lines        18430    18422       -8     
  Branches      2052     2050       -2     
===========================================
- Hits          7417     7406      -11     
- Misses       10727    10728       +1     
- Partials       286      288       +2     
Flag Coverage Δ
e2e 40.20% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@gabriellsh gabriellsh added this to the 5.4.0 milestone Nov 14, 2022
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Nov 17, 2022
@kodiakhq kodiakhq bot merged commit 12cd58e into develop Nov 17, 2022
@kodiakhq kodiakhq bot deleted the fix/customFieldsForm branch November 17, 2022 21:01
gabriellsh added a commit that referenced this pull request Nov 21, 2022
…age-ignore-reactivity

* 'develop' of github.com:RocketChat/Rocket.Chat: (23 commits)
  Chore: removing useEndpointData from license api (#26634)
  Chore: Create unique index for `E2EKey` field (#27301)
  [FIX] LDAP "Sync Roles" option doesn't work for custom roles (#26842)
  Chore: UserAvatar wrapper missing key in RoomForeword (#27300)
  Chore: Add deprecation warning to settings (#27295)
  Chore: Refactor LeaveTeam to Typescript (#27197)
  [FIX] Sidebar context menu in searchList (#23830)
  [NEW] Federation events coverage expansion (#27119)
  [FIX] Message Parser version upgrade (#27284)
  [FIX] Replace regex not compatible with safari (#27294)
  [NEW] Emphasis Elements (italic, strike and bold) in Message Parser Components (#27003)
  [FIX] Set default value "false" for global search. (#25568)
  Regression: Custom fields form not showing in user profile nor admin (#27244)
  [FIX] Sort RecordList items in REVERSE chronological order, not FORWARD (#27201)
  Chore: Remove unused css (#27289)
  Chore: also send thread to channel translations (#27242)
  [FIX] Marketplace app details page back-button behavior (#27062)
  Chore: Add tests for omni-jobs & add more context in system messages for jobs (#27048)
  Chore: Fix missing license for forks (#27258)
  i18n: Language update from LingoHub 🤖 on 2022-11-14Z (#27255)
  ...
@ggazzo ggazzo mentioned this pull request Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants